[INFO] fetching crate carddown 0.1.6... [INFO] checking carddown-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate carddown 0.1.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate carddown 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate carddown 0.1.6 [INFO] finished tweaking crates.io crate carddown 0.1.6 [INFO] tweaked toml for crates.io crate carddown 0.1.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate carddown 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4d388faef10ed5a96ca2a0e6714da9a1f4387d92073b1098f22522033b2a03f [INFO] running `Command { std: "docker" "start" "-a" "b4d388faef10ed5a96ca2a0e6714da9a1f4387d92073b1098f22522033b2a03f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4d388faef10ed5a96ca2a0e6714da9a1f4387d92073b1098f22522033b2a03f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4d388faef10ed5a96ca2a0e6714da9a1f4387d92073b1098f22522033b2a03f", kill_on_drop: false }` [INFO] [stdout] b4d388faef10ed5a96ca2a0e6714da9a1f4387d92073b1098f22522033b2a03f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9687cba20748d228090023709184fdd69e2a45cacae3bf80baf294220589946 [INFO] running `Command { std: "docker" "start" "-a" "a9687cba20748d228090023709184fdd69e2a45cacae3bf80baf294220589946", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling blake3 v1.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking carddown v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | #[arg(long, default_values_t = ["md".to_string(), "txt".to_string(), "org".to_string()])] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | #[arg(long, default_values_t = ["md".to_string(), "txt".to_string(), "org".to_string()])] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 124 | let file_types: HashSet<&str> = HashSet::from_iter(file_types.iter().map(|s| s.as_str())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | / WalkDir::new(folder) [INFO] [stdout] 126 | | .into_iter() [INFO] [stdout] 127 | | .filter_map(|e| e.ok()) [INFO] [stdout] 128 | | .filter(|e| e.file_type().is_file()) [INFO] [stdout] ... | [INFO] [stdout] 136 | | .map(|e| card::parse_file(&PathBuf::from(e.path()))) [INFO] [stdout] 137 | | .collect::>>>() [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|xs| xs.into_iter().flatten().collect()) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 142 | db: CardDb, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | tags: HashSet, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / db.into_values() [INFO] [stdout] 151 | | .filter(|c| { [INFO] [stdout] 152 | | if let Some(last_revised) = c.last_revised { [INFO] [stdout] 153 | | if cram_mode { [INFO] [stdout] ... | [INFO] [stdout] 164 | | .filter(|c| include_orphans || !c.orphan) [INFO] [stdout] 165 | | .filter(|c| !(matches!(leech_method, LeechMethod::Skip) && c.leech)) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 88 | let data: Vec = ron::from_str( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(data [INFO] [stdout] | ________^ [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|entry| (entry.card.id, entry)) [INFO] [stdout] 97 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:142:31 [INFO] [stdout] | [INFO] [stdout] 142 | .map(|card| (card.id, CardEntry::new(card.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carddown` (bin "carddown") due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | #[arg(long, default_values_t = ["md".to_string(), "txt".to_string(), "org".to_string()])] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | #[arg(long, default_values_t = ["md".to_string(), "txt".to_string(), "org".to_string()])] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 124 | let file_types: HashSet<&str> = HashSet::from_iter(file_types.iter().map(|s| s.as_str())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | / WalkDir::new(folder) [INFO] [stdout] 126 | | .into_iter() [INFO] [stdout] 127 | | .filter_map(|e| e.ok()) [INFO] [stdout] 128 | | .filter(|e| e.file_type().is_file()) [INFO] [stdout] ... | [INFO] [stdout] 136 | | .map(|e| card::parse_file(&PathBuf::from(e.path()))) [INFO] [stdout] 137 | | .collect::>>>() [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|xs| xs.into_iter().flatten().collect()) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 142 | db: CardDb, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | tags: HashSet, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / db.into_values() [INFO] [stdout] 151 | | .filter(|c| { [INFO] [stdout] 152 | | if let Some(last_revised) = c.last_revised { [INFO] [stdout] 153 | | if cram_mode { [INFO] [stdout] ... | [INFO] [stdout] 164 | | .filter(|c| include_orphans || !c.orphan) [INFO] [stdout] 165 | | .filter(|c| !(matches!(leech_method, LeechMethod::Skip) && c.leech)) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 88 | let data: Vec = ron::from_str( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(data [INFO] [stdout] | ________^ [INFO] [stdout] 95 | | .into_iter() [INFO] [stdout] 96 | | .map(|entry| (entry.card.id, entry)) [INFO] [stdout] 97 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:142:31 [INFO] [stdout] | [INFO] [stdout] 142 | .map(|card| (card.id, CardEntry::new(card.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carddown` (bin "carddown" test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "a9687cba20748d228090023709184fdd69e2a45cacae3bf80baf294220589946", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9687cba20748d228090023709184fdd69e2a45cacae3bf80baf294220589946", kill_on_drop: false }` [INFO] [stdout] a9687cba20748d228090023709184fdd69e2a45cacae3bf80baf294220589946