[INFO] fetching crate captcha_oxide_core 0.1.1... [INFO] checking captcha_oxide_core-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate captcha_oxide_core 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate captcha_oxide_core 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate captcha_oxide_core 0.1.1 [INFO] finished tweaking crates.io crate captcha_oxide_core 0.1.1 [INFO] tweaked toml for crates.io crate captcha_oxide_core 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28f4842958e9531eaeb644e8de3a0918091c3b6135efb2420c99fdd8d43eb35d [INFO] running `Command { std: "docker" "start" "-a" "28f4842958e9531eaeb644e8de3a0918091c3b6135efb2420c99fdd8d43eb35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28f4842958e9531eaeb644e8de3a0918091c3b6135efb2420c99fdd8d43eb35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28f4842958e9531eaeb644e8de3a0918091c3b6135efb2420c99fdd8d43eb35d", kill_on_drop: false }` [INFO] [stdout] 28f4842958e9531eaeb644e8de3a0918091c3b6135efb2420c99fdd8d43eb35d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3eb9bbb15c2d1eb75bae00a89dc704ebb70e4ce5d4e1cd528464f54654bd828 [INFO] running `Command { std: "docker" "start" "-a" "c3eb9bbb15c2d1eb75bae00a89dc704ebb70e4ce5d4e1cd528464f54654bd828", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking captcha_oxide_core v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn captcha(args: TokenStream, item: &TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | expand_captcha_attr(args, item).unwrap_or_else(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/classified_fields.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 31 | let type_state_generics = ('T'..='Z') [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | phantoms: generics [INFO] [stdout] | _______________________^ [INFO] [stdout] 49 | | .params [INFO] [stdout] 50 | | .iter() [INFO] [stdout] 51 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 62 | | .map(|(i, x)| parse_quote!(#i: std::marker::PhantomData<#x>)) [INFO] [stdout] 63 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/classified_fields.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 31 | let type_state_generics = ('T'..='Z') [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | optional: fields [INFO] [stdout] | _______________________^ [INFO] [stdout] 66 | | .named [INFO] [stdout] 67 | | .iter() [INFO] [stdout] 68 | | .filter(|&x| Self::is_optional_field(x)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/type_state.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 21 | type_state_generics: Vec, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | missing_structs: fields [INFO] [stdout] | ______________________________^ [INFO] [stdout] 27 | | .iter() [INFO] [stdout] 28 | | .map(|field| { [INFO] [stdout] 29 | | let ident = field.ident.as_ref().unwrap().to_pascal_case(); [INFO] [stdout] ... | [INFO] [stdout] 37 | | }) [INFO] [stdout] 38 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/type_state.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 21 | type_state_generics: Vec, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | provided_structs: fields [INFO] [stdout] | _______________________________^ [INFO] [stdout] 40 | | .iter() [INFO] [stdout] 41 | | .map(|field| { [INFO] [stdout] 42 | | let ident = field.ident.as_ref().unwrap().to_pascal_case(); [INFO] [stdout] ... | [INFO] [stdout] 80 | | }) [INFO] [stdout] 81 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `captcha_oxide_core` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn captcha(args: TokenStream, item: &TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | expand_captcha_attr(args, item).unwrap_or_else(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/classified_fields.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 31 | let type_state_generics = ('T'..='Z') [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | phantoms: generics [INFO] [stdout] | _______________________^ [INFO] [stdout] 49 | | .params [INFO] [stdout] 50 | | .iter() [INFO] [stdout] 51 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 62 | | .map(|(i, x)| parse_quote!(#i: std::marker::PhantomData<#x>)) [INFO] [stdout] 63 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/classified_fields.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 31 | let type_state_generics = ('T'..='Z') [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | optional: fields [INFO] [stdout] | _______________________^ [INFO] [stdout] 66 | | .named [INFO] [stdout] 67 | | .iter() [INFO] [stdout] 68 | | .filter(|&x| Self::is_optional_field(x)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/type_state.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 21 | type_state_generics: Vec, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | missing_structs: fields [INFO] [stdout] | ______________________________^ [INFO] [stdout] 27 | | .iter() [INFO] [stdout] 28 | | .map(|field| { [INFO] [stdout] 29 | | let ident = field.ident.as_ref().unwrap().to_pascal_case(); [INFO] [stdout] ... | [INFO] [stdout] 37 | | }) [INFO] [stdout] 38 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros/expansion/attr/captcha/builder/type_state.rs:39:31 [INFO] [stdout] | [INFO] [stdout] 21 | type_state_generics: Vec, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | provided_structs: fields [INFO] [stdout] | _______________________________^ [INFO] [stdout] 40 | | .iter() [INFO] [stdout] 41 | | .map(|field| { [INFO] [stdout] 42 | | let ident = field.ident.as_ref().unwrap().to_pascal_case(); [INFO] [stdout] ... | [INFO] [stdout] 80 | | }) [INFO] [stdout] 81 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `captcha_oxide_core` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c3eb9bbb15c2d1eb75bae00a89dc704ebb70e4ce5d4e1cd528464f54654bd828", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3eb9bbb15c2d1eb75bae00a89dc704ebb70e4ce5d4e1cd528464f54654bd828", kill_on_drop: false }` [INFO] [stdout] c3eb9bbb15c2d1eb75bae00a89dc704ebb70e4ce5d4e1cd528464f54654bd828