[INFO] fetching crate capitan-lib 0.3.0... [INFO] checking capitan-lib-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate capitan-lib 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate capitan-lib 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate capitan-lib 0.3.0 [INFO] finished tweaking crates.io crate capitan-lib 0.3.0 [INFO] tweaked toml for crates.io crate capitan-lib 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31654e61bc7c5777b5b2a99934bd3c578ea3a924b6acf926a8a21d988e4b9102 [INFO] running `Command { std: "docker" "start" "-a" "31654e61bc7c5777b5b2a99934bd3c578ea3a924b6acf926a8a21d988e4b9102", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31654e61bc7c5777b5b2a99934bd3c578ea3a924b6acf926a8a21d988e4b9102", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31654e61bc7c5777b5b2a99934bd3c578ea3a924b6acf926a8a21d988e4b9102", kill_on_drop: false }` [INFO] [stdout] 31654e61bc7c5777b5b2a99934bd3c578ea3a924b6acf926a8a21d988e4b9102 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55526962098e9f700df5aa3274d9bdb07e199f2c5b78dd830b2dfaba4c12c93f [INFO] running `Command { std: "docker" "start" "-a" "55526962098e9f700df5aa3274d9bdb07e199f2c5b78dd830b2dfaba4c12c93f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking capitan-lib v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:29:64 [INFO] [stdout] | [INFO] [stdout] 29 | async fn catch(&mut self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | _______________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | self.0.catch(error).await?; [INFO] [stdout] 31 | | Ok(()) [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:34:64 [INFO] [stdout] | [INFO] [stdout] 34 | async fn abort(&mut self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | _______________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | self.0.abort(error).await?; [INFO] [stdout] 36 | | Ok(()) [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | async fn catch(&self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | ___________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | | self.0.catch(error).await?; [INFO] [stdout] 59 | | Ok(()) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:62:60 [INFO] [stdout] | [INFO] [stdout] 62 | async fn abort(&self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | ___________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | | self.0.abort(error).await?; [INFO] [stdout] 64 | | Ok(()) [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/isolated.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 26 | fn to_dyn(self) -> DynamicIsolatedService [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | DynamicIsolatedService(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/isolated.rs:38:73 [INFO] [stdout] | [INFO] [stdout] 38 | async fn spawn_service(&self, mut service: T, id: usize) -> Res<()> { [INFO] [stdout] | _______________________________________----------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let services = self.services.clone(); [INFO] [stdout] 40 | | let channel = self.notifier_channel.0.clone(); [INFO] [stdout] 41 | | let handle = tokio::spawn(async move { [INFO] [stdout] ... | [INFO] [stdout] 84 | | Ok(()) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/shared.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 24 | fn to_dyn(self) -> (DynamicSharedService, Weak) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let p = Arc::new(self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let s = Arc::downgrade(&p); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | (DynamicSharedService(p), s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/shared.rs:38:69 [INFO] [stdout] | [INFO] [stdout] 38 | async fn spawn_service(&self, service: T, id: usize) -> Res<()> { [INFO] [stdout] | ___________________________________----------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let service = Arc::new(service); [INFO] [stdout] 40 | | let services = self.services.clone(); [INFO] [stdout] 41 | | let channel = self.notifier_channel.0.clone(); [INFO] [stdout] ... | [INFO] [stdout] 87 | | Ok(()) [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:29:64 [INFO] [stdout] | [INFO] [stdout] 29 | async fn catch(&mut self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | _______________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | self.0.catch(error).await?; [INFO] [stdout] 31 | | Ok(()) [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:34:64 [INFO] [stdout] | [INFO] [stdout] 34 | async fn abort(&mut self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | _______________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | self.0.abort(error).await?; [INFO] [stdout] 36 | | Ok(()) [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | async fn catch(&self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | ___________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | | self.0.catch(error).await?; [INFO] [stdout] 59 | | Ok(()) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/dynamic.rs:62:60 [INFO] [stdout] | [INFO] [stdout] 62 | async fn abort(&self, error: anyhow::Error) -> Res<()> { [INFO] [stdout] | ___________________________--------------------_____________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | | self.0.abort(error).await?; [INFO] [stdout] 64 | | Ok(()) [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/isolated.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 26 | fn to_dyn(self) -> DynamicIsolatedService [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | DynamicIsolatedService(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/isolated.rs:38:73 [INFO] [stdout] | [INFO] [stdout] 38 | async fn spawn_service(&self, mut service: T, id: usize) -> Res<()> { [INFO] [stdout] | _______________________________________----------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let services = self.services.clone(); [INFO] [stdout] 40 | | let channel = self.notifier_channel.0.clone(); [INFO] [stdout] 41 | | let handle = tokio::spawn(async move { [INFO] [stdout] ... | [INFO] [stdout] 84 | | Ok(()) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/shared.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 24 | fn to_dyn(self) -> (DynamicSharedService, Weak) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let p = Arc::new(self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let s = Arc::downgrade(&p); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | (DynamicSharedService(p), s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/shared.rs:38:69 [INFO] [stdout] | [INFO] [stdout] 38 | async fn spawn_service(&self, service: T, id: usize) -> Res<()> { [INFO] [stdout] | ___________________________________----------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let service = Arc::new(service); [INFO] [stdout] 40 | | let services = self.services.clone(); [INFO] [stdout] 41 | | let channel = self.notifier_channel.0.clone(); [INFO] [stdout] ... | [INFO] [stdout] 87 | | Ok(()) [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `capitan-lib` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `capitan-lib` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "55526962098e9f700df5aa3274d9bdb07e199f2c5b78dd830b2dfaba4c12c93f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55526962098e9f700df5aa3274d9bdb07e199f2c5b78dd830b2dfaba4c12c93f", kill_on_drop: false }` [INFO] [stdout] 55526962098e9f700df5aa3274d9bdb07e199f2c5b78dd830b2dfaba4c12c93f