[INFO] fetching crate canopeners 0.2.0... [INFO] checking canopeners-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate canopeners 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate canopeners 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate canopeners 0.2.0 [INFO] finished tweaking crates.io crate canopeners 0.2.0 [INFO] tweaked toml for crates.io crate canopeners 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding binrw v0.13.3 (latest: v0.14.0) [INFO] [stderr] Adding binrw_derive v0.13.3 (latest: v0.14.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8511b4712d25b5c5f6e6874099bddb9c539f09e6071b6e4893a2ded1fd1ae6eb [INFO] running `Command { std: "docker" "start" "-a" "8511b4712d25b5c5f6e6874099bddb9c539f09e6071b6e4893a2ded1fd1ae6eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8511b4712d25b5c5f6e6874099bddb9c539f09e6071b6e4893a2ded1fd1ae6eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8511b4712d25b5c5f6e6874099bddb9c539f09e6071b6e4893a2ded1fd1ae6eb", kill_on_drop: false }` [INFO] [stdout] 8511b4712d25b5c5f6e6874099bddb9c539f09e6071b6e4893a2ded1fd1ae6eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 78ca3eae89be271fa5ffeb44ad5ea92256c9ce9d42671e557ff1399270587acd [INFO] running `Command { std: "docker" "start" "-a" "78ca3eae89be271fa5ffeb44ad5ea92256c9ce9d42671e557ff1399270587acd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling binrw_derive v0.13.3 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling binrw v0.13.3 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking byte_conv v0.1.1 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking embedded-can v0.4.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling neli-proc-macros v0.1.3 [INFO] [stderr] Checking neli v0.6.4 [INFO] [stderr] Checking socketcan v3.3.0 [INFO] [stderr] Checking canopeners v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | #[br(try_calc = enums::EmergencyErrorCode::decode(error_code_raw))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | #[br(try_calc = enums::EmergencyErrorCode::decode(error_code_raw))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / Emergency::read(&mut std::io::Cursor::new(data)) [INFO] [stdout] 156 | | .map_err(|e| CanOpenError::ParseError(format!("binrw err: {e}"))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / Emergency::read(&mut std::io::Cursor::new(data)) [INFO] [stdout] 156 | | .map_err(|e| CanOpenError::ParseError(format!("binrw err: {e}"))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 316 | let payload = SdoCmdInitiatePayload::decode(frame)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 318 | | index, [INFO] [stdout] 319 | | sub_index, [INFO] [stdout] 320 | | payload, [INFO] [stdout] 321 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 455 | let payload = SdoCmdInitiatePayload::decode(frame)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 457 | | index, [INFO] [stdout] 458 | | sub_index, [INFO] [stdout] 459 | | payload, [INFO] [stdout] 460 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:616:22 [INFO] [stdout] | [INFO] [stdout] 612 | pub fn new_write(node_id: u8, index: u16, sub_index: u8, data: Box<[u8]>) -> Sdo { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 616 | command: SdoCmd::InitiateDownloadRx(SdoCmdInitiateDownloadRx { [INFO] [stdout] | ______________________^ [INFO] [stdout] 617 | | index, [INFO] [stdout] 618 | | sub_index, [INFO] [stdout] 619 | | payload: SdoCmdInitiatePayload::Expedited(data), [INFO] [stdout] 620 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:765:9 [INFO] [stdout] | [INFO] [stdout] 765 | Guard::read(&mut std::io::Cursor::new(&data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 316 | let payload = SdoCmdInitiatePayload::decode(frame)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 318 | | index, [INFO] [stdout] 319 | | sub_index, [INFO] [stdout] 320 | | payload, [INFO] [stdout] 321 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:945:12 [INFO] [stdout] | [INFO] [stdout] 944 | let socket = socketcan::CanSocket::open(interface_name).expect("no iface"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | Ok(Conn { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:12 [INFO] [stdout] | [INFO] [stdout] 455 | let payload = SdoCmdInitiatePayload::decode(frame)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 457 | | index, [INFO] [stdout] 458 | | sub_index, [INFO] [stdout] 459 | | payload, [INFO] [stdout] 460 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:616:22 [INFO] [stdout] | [INFO] [stdout] 612 | pub fn new_write(node_id: u8, index: u16, sub_index: u8, data: Box<[u8]>) -> Sdo { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 616 | command: SdoCmd::InitiateDownloadRx(SdoCmdInitiateDownloadRx { [INFO] [stdout] | ______________________^ [INFO] [stdout] 617 | | index, [INFO] [stdout] 618 | | sub_index, [INFO] [stdout] 619 | | payload: SdoCmdInitiatePayload::Expedited(data), [INFO] [stdout] 620 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:765:9 [INFO] [stdout] | [INFO] [stdout] 765 | Guard::read(&mut std::io::Cursor::new(&data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:945:12 [INFO] [stdout] | [INFO] [stdout] 944 | let socket = socketcan::CanSocket::open(interface_name).expect("no iface"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | Ok(Conn { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `canopeners` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `canopeners` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "78ca3eae89be271fa5ffeb44ad5ea92256c9ce9d42671e557ff1399270587acd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78ca3eae89be271fa5ffeb44ad5ea92256c9ce9d42671e557ff1399270587acd", kill_on_drop: false }` [INFO] [stdout] 78ca3eae89be271fa5ffeb44ad5ea92256c9ce9d42671e557ff1399270587acd