[INFO] fetching crate canonical_host 0.5.0... [INFO] checking canonical_host-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate canonical_host 0.5.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate canonical_host 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate canonical_host 0.5.0 [INFO] finished tweaking crates.io crate canonical_host 0.5.0 [INFO] tweaked toml for crates.io crate canonical_host 0.5.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding arbitrary v0.3.3 (latest: v1.3.2) [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.3.1 (latest: v1.0.2) [INFO] [stderr] Adding canonical v0.5.3 (latest: v0.7.1) [INFO] [stderr] Adding canonical_derive v0.5.0 (latest: v0.7.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding derive_arbitrary v0.3.3 (latest: v1.3.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.1.5 (latest: v0.4.12) [INFO] [stderr] Adding parking_lot v0.7.1 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.4.0 (latest: v0.9.10) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] [stderr] Adding seahash v3.0.7 (latest: v4.1.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b038d6dba73055da811af33aa6114384a8f8186f734cacc412988b93a849d78 [INFO] running `Command { std: "docker" "start" "-a" "1b038d6dba73055da811af33aa6114384a8f8186f734cacc412988b93a849d78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b038d6dba73055da811af33aa6114384a8f8186f734cacc412988b93a849d78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b038d6dba73055da811af33aa6114384a8f8186f734cacc412988b93a849d78", kill_on_drop: false }` [INFO] [stdout] 1b038d6dba73055da811af33aa6114384a8f8186f734cacc412988b93a849d78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b035d0e80e8462c86fafb634ec927ebb57aa157397366329dd8a21f8f52f9aa [INFO] running `Command { std: "docker" "start" "-a" "3b035d0e80e8462c86fafb634ec927ebb57aa157397366329dd8a21f8f52f9aa", kill_on_drop: false }` [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling arrayref v0.3.8 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling constant_time_eq v0.1.5 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling derive_arbitrary v0.3.3 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking seahash v3.0.7 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Compiling blake2b_simd v0.3.1 [INFO] [stderr] Compiling arbitrary v0.3.3 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking appendix v0.2.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking canonical v0.5.3 [INFO] [stderr] Compiling canonical_derive v0.5.0 [INFO] [stderr] Checking canonical_host v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `MemSink` is never constructed [INFO] [stdout] --> src/mem_store.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | struct MemSink { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DiskSink` is never constructed [INFO] [stdout] --> src/disk_store.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | struct DiskSink { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk_store.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Ok(DiskStore(Arc::new(RwLock::new(DiskStoreInner::new(path)?)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk_store.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let index = Index::new(&index_dir)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut data = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | index, [INFO] [stdout] 79 | | data_path, [INFO] [stdout] 80 | | data, [INFO] [stdout] 81 | | data_offset, [INFO] [stdout] 82 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new>(from: T, store: &S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let id = store.put(&from)?; [INFO] [stdout] 22 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | id, [INFO] [stdout] 24 | | store: store.clone(), [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let t = self.store.get(&self.id)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(CastMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | remote: self, [INFO] [stdout] 38 | | value: t, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `canonical_host` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stdout] warning: struct `MemSink` is never constructed [INFO] [stdout] --> src/mem_store.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | struct MemSink { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `DiskSink` is never constructed [INFO] [stdout] --> src/disk_store.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | struct DiskSink { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `canonical_host` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk_store.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Ok(DiskStore(Arc::new(RwLock::new(DiskStoreInner::new(path)?)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disk_store.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let index = Index::new(&index_dir)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let mut data = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | index, [INFO] [stdout] 79 | | data_path, [INFO] [stdout] 80 | | data, [INFO] [stdout] 81 | | data_offset, [INFO] [stdout] 82 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new>(from: T, store: &S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let id = store.put(&from)?; [INFO] [stdout] 22 | Ok(Remote { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | id, [INFO] [stdout] 24 | | store: store.clone(), [INFO] [stdout] 25 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | let t = self.store.get(&self.id)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(CastMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | remote: self, [INFO] [stdout] 38 | | value: t, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "3b035d0e80e8462c86fafb634ec927ebb57aa157397366329dd8a21f8f52f9aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b035d0e80e8462c86fafb634ec927ebb57aa157397366329dd8a21f8f52f9aa", kill_on_drop: false }` [INFO] [stdout] 3b035d0e80e8462c86fafb634ec927ebb57aa157397366329dd8a21f8f52f9aa