[INFO] fetching crate camo-derive 0.5.0... [INFO] checking camo-derive-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate camo-derive 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate camo-derive 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate camo-derive 0.5.0 [INFO] finished tweaking crates.io crate camo-derive 0.5.0 [INFO] tweaked toml for crates.io crate camo-derive 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89a8851ca0576f26e41b0693eadc28f1a381c062e0c812edcd32d52e48862536 [INFO] running `Command { std: "docker" "start" "-a" "89a8851ca0576f26e41b0693eadc28f1a381c062e0c812edcd32d52e48862536", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89a8851ca0576f26e41b0693eadc28f1a381c062e0c812edcd32d52e48862536", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89a8851ca0576f26e41b0693eadc28f1a381c062e0c812edcd32d52e48862536", kill_on_drop: false }` [INFO] [stdout] 89a8851ca0576f26e41b0693eadc28f1a381c062e0c812edcd32d52e48862536 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52b05a1a5f3d51c2b5f34b18bee026a5d250d5615d1f6f1fb0dcce582eb65393 [INFO] running `Command { std: "docker" "start" "-a" "52b05a1a5f3d51c2b5f34b18bee026a5d250d5615d1f6f1fb0dcce582eb65393", kill_on_drop: false }` [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking camo-derive v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:527:14 [INFO] [stdout] | [INFO] [stdout] 526 | fn from(value: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:543:14 [INFO] [stdout] | [INFO] [stdout] 542 | fn from(value: Type) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 543 | Self(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn derive(input: DeriveInput) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | match Impl::from_input(input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 81 | fn from_input(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let name = input.ident.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let generics = input.generics.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let container = ast::Container::from_input(input)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | name, [INFO] [stdout] 87 | | generics, [INFO] [stdout] 88 | | container, [INFO] [stdout] 89 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn from_input(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let item = ast::Item::from_input(input)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | [INFO] [stdout] 123 | Ok(Self { serde, item }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 305 | visibility: Visibility, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | name: Ident, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | generics: Generics, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | data: DataStruct, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | ) -> Result { [INFO] [stdout] 310 | Ok(ast::Struct { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | visibility: ast::Visibility::from_visibility(visibility)?, [INFO] [stdout] 312 | | name: name.to_string(), [INFO] [stdout] 313 | | parameters: generics [INFO] [stdout] ... | [INFO] [stdout] 318 | | content: ast::StructContent::from_fields(data.fields)?, [INFO] [stdout] 319 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:352:28 [INFO] [stdout] | [INFO] [stdout] 351 | .map(|field| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | Ok(ast::NamedField { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 353 | | name: field.ident.as_ref().expect("named field").to_string(), [INFO] [stdout] 354 | | ty: ast::Type::from_ty(field.ty)?, [INFO] [stdout] 355 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 389 | visibility: Visibility, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | name: Ident, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | generics: Generics, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | data: DataEnum, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | ) -> Result { [INFO] [stdout] 394 | Ok(ast::Enum { [INFO] [stdout] | ____________^ [INFO] [stdout] 395 | | visibility: ast::Visibility::from_visibility(visibility)?, [INFO] [stdout] 396 | | name: name.to_string(), [INFO] [stdout] 397 | | parameters: generics [INFO] [stdout] ... | [INFO] [stdout] 406 | | .collect::>()?, [INFO] [stdout] 407 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:430:12 [INFO] [stdout] | [INFO] [stdout] 412 | fn from_variant(variant: Variant) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | let content = ast::VariantContent::from_fields(variant.fields)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 429 | [INFO] [stdout] 430 | Ok(ast::Variant { [INFO] [stdout] | ____________^ [INFO] [stdout] 431 | | serde, [INFO] [stdout] 432 | | name: variant.ident.to_string(), [INFO] [stdout] 433 | | content, [INFO] [stdout] 434 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:496:28 [INFO] [stdout] | [INFO] [stdout] 495 | .map(|field| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | Ok(ast::NamedField { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 497 | | name: field.ident.as_ref().unwrap().to_string(), [INFO] [stdout] 498 | | ty: ast::Type::from_ty(field.ty)?, [INFO] [stdout] 499 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:563:12 [INFO] [stdout] | [INFO] [stdout] 562 | fn from_type_reference(ty: TypeReference) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 563 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 564 | | lifetime: ast::Lifetime { [INFO] [stdout] 565 | | name: ty.lifetime.expect("missing lifetime").ident.to_string(), [INFO] [stdout] 566 | | }, [INFO] [stdout] 567 | | ty: Box::new(ast::Type::from_ty(*ty.elem)?), [INFO] [stdout] 568 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:588:12 [INFO] [stdout] | [INFO] [stdout] 573 | fn from_type_path(ty: TypePath) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 581 | let segments: Vec<_> = ty [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | Ok(ast::TypePath { segments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive.rs:594:12 [INFO] [stdout] | [INFO] [stdout] 593 | fn from_segment(segment: PathSegment) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 594 | Ok(ast::PathSegment { [INFO] [stdout] | ____________^ [INFO] [stdout] 595 | | name: segment.ident.to_string(), [INFO] [stdout] 596 | | arguments: match segment.arguments { [INFO] [stdout] 597 | | PathArguments::None => Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 604 | | }, [INFO] [stdout] 605 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `camo-derive` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "52b05a1a5f3d51c2b5f34b18bee026a5d250d5615d1f6f1fb0dcce582eb65393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52b05a1a5f3d51c2b5f34b18bee026a5d250d5615d1f6f1fb0dcce582eb65393", kill_on_drop: false }` [INFO] [stdout] 52b05a1a5f3d51c2b5f34b18bee026a5d250d5615d1f6f1fb0dcce582eb65393