[INFO] fetching crate camgi 0.9.0... [INFO] checking camgi-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate camgi 0.9.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate camgi 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate camgi 0.9.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate camgi 0.9.0 [INFO] tweaked toml for crates.io crate camgi 0.9.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate camgi 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f538a85e3daee4744dcf871f7e4904f3f77758f041b4a4880707471ded95c02 [INFO] running `Command { std: "docker" "start" "-a" "0f538a85e3daee4744dcf871f7e4904f3f77758f041b4a4880707471ded95c02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f538a85e3daee4744dcf871f7e4904f3f77758f041b4a4880707471ded95c02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f538a85e3daee4744dcf871f7e4904f3f77758f041b4a4880707471ded95c02", kill_on_drop: false }` [INFO] [stdout] 0f538a85e3daee4744dcf871f7e4904f3f77758f041b4a4880707471ded95c02 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01b74932682c432c13019dd5bc101fbd5e43a96e35f11cb6bd6d55901b8cc9c7 [INFO] running `Command { std: "docker" "start" "-a" "01b74932682c432c13019dd5bc101fbd5e43a96e35f11cb6bd6d55901b8cc9c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking cpufeatures v0.2.7 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking net2 v0.2.38 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking filetime v0.2.21 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.96 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking xattr v0.2.3 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking rustls-pemfile v1.0.2 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking headers v0.3.8 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking html-builder v0.3.0 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling uuid-macro-internal v1.3.4 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling pin-project-internal v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking uuid v1.3.4 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking pin-project v1.1.0 [INFO] [stderr] Checking tungstenite v0.18.0 [INFO] [stderr] Checking infer v0.9.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking camgi v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn from(mustgather: MustGather) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut buffer = Buffer::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let mut html = buffer.html().attr("lang='en'"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(Html { buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 42 | let clusteroperators = get_resources::(&manifestpath); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let machines = get_resources::(&manifestpath); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let machinesets = get_resources::(&manifestpath); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let nodes = get_resources::(&manifestpath); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let csrs = get_resources::(&manifestpath); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let clusterautoscalers = get_resources::(&manifestpath); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let machineautoscalers = get_resources::(&manifestpath); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let baremetalhosts = get_resources::(&manifestpath); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let controlplanemachinesets = get_resources::(&manifestpath); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let mapipods = get_pods(&manifestpath); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let mcopods = get_pods(&manifestpath); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let ccmopods = get_pods(&manifestpath); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let ccmpods = get_pods(&manifestpath); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | Ok(MustGather { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | title, [INFO] [stdout] 132 | | version, [INFO] [stdout] 133 | | platformtype, [INFO] [stdout] ... | [INFO] [stdout] 146 | | ccmpods, [INFO] [stdout] 147 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:216:18 [INFO] [stdout] | [INFO] [stdout] 216 | .map(|r| r.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:237:11 [INFO] [stdout] | [INFO] [stdout] 233 | let version = match Manifest::from(manifestpath) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | match version.as_yaml()["status"]["platformStatus"]["type"].as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:253:11 [INFO] [stdout] | [INFO] [stdout] 249 | let version = match Manifest::from(manifestpath) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | match version.as_yaml()["status"]["desired"]["version"].as_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 324 | .map(|r| r.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mustgather.rs:350:18 [INFO] [stdout] | [INFO] [stdout] 350 | .map(|m| m.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `camgi` (bin "camgi") due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "01b74932682c432c13019dd5bc101fbd5e43a96e35f11cb6bd6d55901b8cc9c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01b74932682c432c13019dd5bc101fbd5e43a96e35f11cb6bd6d55901b8cc9c7", kill_on_drop: false }` [INFO] [stdout] 01b74932682c432c13019dd5bc101fbd5e43a96e35f11cb6bd6d55901b8cc9c7