[INFO] fetching crate calculator-rs 0.1.2... [INFO] checking calculator-rs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate calculator-rs 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate calculator-rs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate calculator-rs 0.1.2 [INFO] finished tweaking crates.io crate calculator-rs 0.1.2 [INFO] tweaked toml for crates.io crate calculator-rs 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92876207caac091b64afa04c96e4564415494f2fd6d4d4a8e29fd6d4006fc327 [INFO] running `Command { std: "docker" "start" "-a" "92876207caac091b64afa04c96e4564415494f2fd6d4d4a8e29fd6d4006fc327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92876207caac091b64afa04c96e4564415494f2fd6d4d4a8e29fd6d4006fc327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92876207caac091b64afa04c96e4564415494f2fd6d4d4a8e29fd6d4006fc327", kill_on_drop: false }` [INFO] [stdout] 92876207caac091b64afa04c96e4564415494f2fd6d4d4a8e29fd6d4006fc327 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db5aa5a37a81ce7885cdc8e9f0e9dcac6f23f034a37890f0b2ea6195c628aeff [INFO] running `Command { std: "docker" "start" "-a" "db5aa5a37a81ce7885cdc8e9f0e9dcac6f23f034a37890f0b2ea6195c628aeff", kill_on_drop: false }` [INFO] [stderr] Checking calculator-rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `augment` is never used [INFO] [stdout] --> src/parse.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 103 | trait Operator: Sized { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 107 | fn augment(self, parser: &mut Parser) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 123 | fn build(&self, lhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | / match self { [INFO] [stdout] 126 | | PrefixOperator::Minus => ast::Operation::Negate(lhs), [INFO] [stdout] 127 | | PrefixOperator::Plus => ast::Operation::Assert(lhs), [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 165 | fn build(&self, lhs: ast::Expression, rhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let rhs = Box::new(rhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / match self { [INFO] [stdout] 169 | | InfixOperator::Add => ast::Operation::Add(lhs, rhs), [INFO] [stdout] 170 | | InfixOperator::Divide => ast::Operation::Divide(lhs, rhs), [INFO] [stdout] 171 | | InfixOperator::Exponentiate => ast::Operation::Exponentiate(lhs, rhs), [INFO] [stdout] ... | [INFO] [stdout] 174 | | InfixOperator::Modulo => ast::Operation::Modulo(lhs, rhs), [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 218 | fn build(&self, lhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | / match self { [INFO] [stdout] 221 | | PostfixOperator::Factorial => ast::Operation::Factorial(lhs), [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator-rs` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `augment` is never used [INFO] [stdout] --> src/parse.rs:107:8 [INFO] [stdout] | [INFO] [stdout] 103 | trait Operator: Sized { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 107 | fn augment(self, parser: &mut Parser) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 123 | fn build(&self, lhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | / match self { [INFO] [stdout] 126 | | PrefixOperator::Minus => ast::Operation::Negate(lhs), [INFO] [stdout] 127 | | PrefixOperator::Plus => ast::Operation::Assert(lhs), [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 165 | fn build(&self, lhs: ast::Expression, rhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let rhs = Box::new(rhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | / match self { [INFO] [stdout] 169 | | InfixOperator::Add => ast::Operation::Add(lhs, rhs), [INFO] [stdout] 170 | | InfixOperator::Divide => ast::Operation::Divide(lhs, rhs), [INFO] [stdout] 171 | | InfixOperator::Exponentiate => ast::Operation::Exponentiate(lhs, rhs), [INFO] [stdout] ... | [INFO] [stdout] 174 | | InfixOperator::Modulo => ast::Operation::Modulo(lhs, rhs), [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 218 | fn build(&self, lhs: ast::Expression) -> ast::Expression { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let lhs = Box::new(lhs); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | / match self { [INFO] [stdout] 221 | | PostfixOperator::Factorial => ast::Operation::Factorial(lhs), [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator-rs` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "db5aa5a37a81ce7885cdc8e9f0e9dcac6f23f034a37890f0b2ea6195c628aeff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db5aa5a37a81ce7885cdc8e9f0e9dcac6f23f034a37890f0b2ea6195c628aeff", kill_on_drop: false }` [INFO] [stdout] db5aa5a37a81ce7885cdc8e9f0e9dcac6f23f034a37890f0b2ea6195c628aeff