[INFO] fetching crate cache_browns 0.0.1-poc.0... [INFO] checking cache_browns-0.0.1-poc.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cache_browns 0.0.1-poc.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cache_browns 0.0.1-poc.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cache_browns 0.0.1-poc.0 [INFO] finished tweaking crates.io crate cache_browns 0.0.1-poc.0 [INFO] tweaked toml for crates.io crate cache_browns 0.0.1-poc.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding interruptible_polling v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9198be43241c292217acbc6d5d254c2ce3e8ba75aa7e04cebfa63a74b82702a [INFO] running `Command { std: "docker" "start" "-a" "c9198be43241c292217acbc6d5d254c2ce3e8ba75aa7e04cebfa63a74b82702a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9198be43241c292217acbc6d5d254c2ce3e8ba75aa7e04cebfa63a74b82702a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9198be43241c292217acbc6d5d254c2ce3e8ba75aa7e04cebfa63a74b82702a", kill_on_drop: false }` [INFO] [stdout] c9198be43241c292217acbc6d5d254c2ce3e8ba75aa7e04cebfa63a74b82702a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ab2f7910c191857ed06efecae3ecdb5375e6eb97cf52156f277f29078915f08 [INFO] running `Command { std: "docker" "start" "-a" "3ab2f7910c191857ed06efecae3ecdb5375e6eb97cf52156f277f29078915f08", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking interruptible_polling v0.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking cache_browns v0.0.1-poc.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydration/polling.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | let value = self.shared_inner_state.store.write().unwrap().get(key); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | / value [INFO] [stdout] 97 | | .map(|value| { [INFO] [stdout] 98 | | CacheLookupSuccess::new( [INFO] [stdout] 99 | | if self.shared_inner_state.data_source.is_valid(key, &value) { [INFO] [stdout] ... | [INFO] [stdout] 106 | | ) [INFO] [stdout] 107 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 79 | fn put(&mut self, key: &Key, value: Value) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / Record { [INFO] [stdout] 85 | | key: (*key).clone(), [INFO] [stdout] 86 | | value, [INFO] [stdout] 87 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 225 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / index [INFO] [stdout] 232 | | .entry(key) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 278 | fn deserialize(buffered_reader: BufReader) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | serde_json::from_reader(buffered_reader).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 299 | fn deserialize(buffered_reader: BufReader) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | serde_json::from_reader(buffered_reader).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cache_browns` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydration/polling.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | let value = self.shared_inner_state.store.write().unwrap().get(key); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | / value [INFO] [stdout] 97 | | .map(|value| { [INFO] [stdout] 98 | | CacheLookupSuccess::new( [INFO] [stdout] 99 | | if self.shared_inner_state.data_source.is_valid(key, &value) { [INFO] [stdout] ... | [INFO] [stdout] 106 | | ) [INFO] [stdout] 107 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydration/polling.rs:215:37 [INFO] [stdout] | [INFO] [stdout] 215 | .map_or(false, |v| *v.lock().unwrap() == Some(*value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 79 | fn put(&mut self, key: &Key, value: Value) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / Record { [INFO] [stdout] 85 | | key: (*key).clone(), [INFO] [stdout] 86 | | value, [INFO] [stdout] 87 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 225 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / index [INFO] [stdout] 232 | | .entry(key) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 278 | fn deserialize(buffered_reader: BufReader) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | serde_json::from_reader(buffered_reader).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store/discrete_files.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 299 | fn deserialize(buffered_reader: BufReader) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | serde_json::from_reader(buffered_reader).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cache_browns` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3ab2f7910c191857ed06efecae3ecdb5375e6eb97cf52156f277f29078915f08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ab2f7910c191857ed06efecae3ecdb5375e6eb97cf52156f277f29078915f08", kill_on_drop: false }` [INFO] [stdout] 3ab2f7910c191857ed06efecae3ecdb5375e6eb97cf52156f277f29078915f08