[INFO] fetching crate cab 0.6.0... [INFO] checking cab-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cab 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cab 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cab 0.6.0 [INFO] finished tweaking crates.io crate cab 0.6.0 [INFO] tweaked toml for crates.io crate cab 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cab 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ea83755fa067eb671e92db11d2d663ba899bd7fe96e147277974fc15edd5236 [INFO] running `Command { std: "docker" "start" "-a" "4ea83755fa067eb671e92db11d2d663ba899bd7fe96e147277974fc15edd5236", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ea83755fa067eb671e92db11d2d663ba899bd7fe96e147277974fc15edd5236", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ea83755fa067eb671e92db11d2d663ba899bd7fe96e147277974fc15edd5236", kill_on_drop: false }` [INFO] [stdout] 4ea83755fa067eb671e92db11d2d663ba899bd7fe96e147277974fc15edd5236 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18737cad78a91e3dcd290fac7f8dfd4240363e44d565a1c44036adf756d17190 [INFO] running `Command { std: "docker" "start" "-a" "18737cad78a91e3dcd290fac7f8dfd4240363e44d565a1c44036adf756d17190", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling time-macros v0.2.15 [INFO] [stderr] Checking deranged v0.3.9 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking lzxd v0.2.5 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking time v0.3.30 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking cab v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 198 | mut writer: W, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | Ok(CabinetWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 322 | | writer: InnerCabinetWriter::Raw(writer), [INFO] [stdout] 323 | | builder, [INFO] [stdout] 324 | | current_folder_index: 0, [INFO] [stdout] 325 | | next_file_index: 0, [INFO] [stdout] 326 | | offset_within_folder: 0, [INFO] [stdout] 327 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:401:15 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn finish(mut self) -> io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | self.shutdown()?; [INFO] [stdout] 401 | match self.writer.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:527:12 [INFO] [stdout] | [INFO] [stdout] 502 | mut writer: W, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let compressor = match compression_type { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 527 | Ok(FolderWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 528 | | writer, [INFO] [stdout] 529 | | compressor, [INFO] [stdout] 530 | | folder_entry_offset, [INFO] [stdout] ... | [INFO] [stdout] 534 | | data_block_buffer: Vec::with_capacity(MAX_UNCOMPRESSED_BLOCK_SIZE), [INFO] [stdout] 535 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cabinet.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(mut reader: R) -> io::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok(Cabinet { [INFO] [stdout] | ____________^ [INFO] [stdout] 113 | | inner: CabinetInner { [INFO] [stdout] 114 | | cabinet_set_id, [INFO] [stdout] 115 | | cabinet_set_index, [INFO] [stdout] ... | [INFO] [stdout] 121 | | }, [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cab` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "18737cad78a91e3dcd290fac7f8dfd4240363e44d565a1c44036adf756d17190", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18737cad78a91e3dcd290fac7f8dfd4240363e44d565a1c44036adf756d17190", kill_on_drop: false }` [INFO] [stdout] 18737cad78a91e3dcd290fac7f8dfd4240363e44d565a1c44036adf756d17190