[INFO] fetching crate c8 1.0.1... [INFO] checking c8-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate c8 1.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate c8 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate c8 1.0.1 [INFO] finished tweaking crates.io crate c8 1.0.1 [INFO] tweaked toml for crates.io crate c8 1.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate c8 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 408aa9a58d65056f07d4fac8898b50603092a1db9811f93e7bcddc08ec3e82d2 [INFO] running `Command { std: "docker" "start" "-a" "408aa9a58d65056f07d4fac8898b50603092a1db9811f93e7bcddc08ec3e82d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "408aa9a58d65056f07d4fac8898b50603092a1db9811f93e7bcddc08ec3e82d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "408aa9a58d65056f07d4fac8898b50603092a1db9811f93e7bcddc08ec3e82d2", kill_on_drop: false }` [INFO] [stdout] 408aa9a58d65056f07d4fac8898b50603092a1db9811f93e7bcddc08ec3e82d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 767f81b1730bb596506f055409f241c8c675cf36cfafd1bfcdd4cf7853b6fe2f [INFO] running `Command { std: "docker" "start" "-a" "767f81b1730bb596506f055409f241c8c675cf36cfafd1bfcdd4cf7853b6fe2f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Compiling parking_lot_core v0.9.4 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling rustix v0.36.5 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking linux-raw-sys v0.1.3 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling time-core v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking unicode-segmentation v1.10.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling time-macros v0.2.6 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling x11 v2.20.0 [INFO] [stderr] Compiling device_query v1.1.2 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking itoa v1.0.4 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking hound v3.5.0 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking spin_sleep v1.1.1 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking time v0.3.17 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking simple_logger v4.0.0 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking is-terminal v0.4.1 [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking rodio v0.17.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tui-logger v0.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Compiling clap_derive v4.1.0 [INFO] [stderr] Checking ansi-to-tui v2.0.0 [INFO] [stderr] Checking clap v4.1.4 [INFO] [stderr] Checking c8 v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `command_line` is never read [INFO] [stdout] --> src/dbg/mod.rs:984:9 [INFO] [stdout] | [INFO] [stdout] 970 | pub struct DebuggerWidgetBorders { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 984 | pub command_line: Borders, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 83 | let default_panic_hook = std::panic::take_hook(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let (_audio_stream, audio_controller) = spawn_audio_stream(); [INFO] [stdout] | ------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let vm = VM::new(rom, cpf, audio_controller); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let dbg = if debug { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let runner = Runner::new(vm, dbg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let (render_controller, render_thread) = spawn_render_thread(runner.c8(), logging); [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let run_thread = spawn_run_thread(runner, render_controller, debug, logging); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match run_thread.join().expect("Failed to join run thread") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command_line` is never read [INFO] [stdout] --> src/dbg/mod.rs:984:9 [INFO] [stdout] | [INFO] [stdout] 970 | pub struct DebuggerWidgetBorders { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 984 | pub command_line: Borders, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 83 | let default_panic_hook = std::panic::take_hook(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let (_audio_stream, audio_controller) = spawn_audio_stream(); [INFO] [stdout] | ------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let vm = VM::new(rom, cpf, audio_controller); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let dbg = if debug { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let runner = Runner::new(vm, dbg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let (render_controller, render_thread) = spawn_render_thread(runner.c8(), logging); [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let run_thread = spawn_run_thread(runner, render_controller, debug, logging); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match run_thread.join().expect("Failed to join run thread") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch8/run.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn exit(self) -> RunResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let Runner { [INFO] [stdout] 234 | thread_continue_sender, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | thread_handle, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | thread_handle.join().expect("Runner exited without result") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch8/run.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn exit(self) -> RunResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let Runner { [INFO] [stdout] 234 | thread_continue_sender, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | thread_handle, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | thread_handle.join().expect("Runner exited without result") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:101:6 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn spawn_render_thread(c8: C8Lock, logging: bool) -> (RenderController, JoinHandle<()>) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let (render_sender, render_receiver) = channel::<()>(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let render_thread_handle = thread::spawn(move || { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | (RenderController(render_sender), render_thread_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:101:6 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn spawn_render_thread(c8: C8Lock, logging: bool) -> (RenderController, JoinHandle<()>) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let (render_sender, render_receiver) = channel::<()>(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let render_thread_handle = thread::spawn(move || { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | (RenderController(render_sender), render_thread_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c8` (bin "c8") due to 4 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `c8` (bin "c8" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "767f81b1730bb596506f055409f241c8c675cf36cfafd1bfcdd4cf7853b6fe2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "767f81b1730bb596506f055409f241c8c675cf36cfafd1bfcdd4cf7853b6fe2f", kill_on_drop: false }` [INFO] [stdout] 767f81b1730bb596506f055409f241c8c675cf36cfafd1bfcdd4cf7853b6fe2f