[INFO] fetching crate c5store 0.2.6... [INFO] checking c5store-0.2.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate c5store 0.2.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate c5store 0.2.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate c5store 0.2.6 [INFO] finished tweaking crates.io crate c5store 0.2.6 [INFO] tweaked toml for crates.io crate c5store 0.2.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding asn1-rs v0.5.2 (latest: v0.6.2) [INFO] [stderr] Adding asn1-rs-derive v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding asn1-rs-impl v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding der-parser v8.2.0 (latest: v9.0.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding multimap v0.8.3 (latest: v0.10.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding shellexpand v2.1.2 (latest: v3.1.0) [INFO] [stderr] Adding skiplist v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66153f720cb0369783fc0e4ceee0ce32c6a10ae6c7c942c45cef861faa20fabf [INFO] running `Command { std: "docker" "start" "-a" "66153f720cb0369783fc0e4ceee0ce32c6a10ae6c7c942c45cef861faa20fabf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66153f720cb0369783fc0e4ceee0ce32c6a10ae6c7c942c45cef861faa20fabf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66153f720cb0369783fc0e4ceee0ce32c6a10ae6c7c942c45cef861faa20fabf", kill_on_drop: false }` [INFO] [stdout] 66153f720cb0369783fc0e4ceee0ce32c6a10ae6c7c942c45cef861faa20fabf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b863e6239db061d1de52dd3edf6ed31cd5db772844d177eb84270ec84868dd4 [INFO] running `Command { std: "docker" "start" "-a" "1b863e6239db061d1de52dd3edf6ed31cd5db772844d177eb84270ec84868dd4", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking shellexpand v2.1.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling asn1-rs-derive v0.4.0 [INFO] [stderr] Compiling asn1-rs-impl v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking asn1-rs v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking der-parser v8.2.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking curve25519-parser v0.4.0 [INFO] [stderr] Checking skiplist v0.4.0 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ecies_25519 v0.1.2 [INFO] [stderr] Checking multimap v0.8.3 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking c5store v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder [INFO] [stdout] --> src/lib.rs:115:50 [INFO] [stdout] | [INFO] [stdout] 115 | thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder [INFO] [stdout] --> src/lib.rs:115:50 [INFO] [stdout] | [INFO] [stdout] 115 | thread_pool: Arc::new(ScheduledThreadPool::with_name("c5Store_change_notifier", 1)), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder [INFO] [stdout] --> src/lib.rs:356:52 [INFO] [stdout] | [INFO] [stdout] 356 | _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `scheduled_thread_pool::ScheduledThreadPool::with_name`: use ScheduledThreadPool::builder [INFO] [stdout] --> src/lib.rs:356:52 [INFO] [stdout] | [INFO] [stdout] 356 | _scheduled_thread_pool: ScheduledThreadPool::with_name("c5store_mgr", 8), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_bytes` is never used [INFO] [stdout] --> src/value.rs:598:17 [INFO] [stdout] | [INFO] [stdout] 596 | impl C5DataValue { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] 597 | [INFO] [stdout] 598 | pub(crate) fn as_bytes(&self) -> Option> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn with_hasher(hash_builder: S) -> HashsetMultiMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | HashsetMultiMap { [INFO] [stdout] 60 | _inner_map: HashMap::with_hasher(hash_builder) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn with_capacity_and_hasher(capacity: usize, hash_builder: S) -> HashsetMultiMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | HashsetMultiMap { [INFO] [stdout] 69 | _inner_map: HashMap::with_capacity_and_hasher(capacity, hash_builder) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:500:92 [INFO] [stdout] | [INFO] [stdout] 500 | C5DataValue::Array(inner_value) => Result::Ok(inner_value.into_iter().map(|vec_item| vec_item.try_into().unwrap()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:512:92 [INFO] [stdout] | [INFO] [stdout] 512 | C5DataValue::Array(inner_value) => Result::Ok(inner_value.into_iter().map(|vec_item| vec_item.try_into().unwrap()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Base64SecretDecryptor` is never constructed [INFO] [stdout] --> src/secrets.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | pub (in crate) struct Base64SecretDecryptor {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `as_bytes` is never used [INFO] [stdout] --> src/value.rs:598:17 [INFO] [stdout] | [INFO] [stdout] 596 | impl C5DataValue { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] 597 | [INFO] [stdout] 598 | pub(crate) fn as_bytes(&self) -> Option> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn with_hasher(hash_builder: S) -> HashsetMultiMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | HashsetMultiMap { [INFO] [stdout] 60 | _inner_map: HashMap::with_hasher(hash_builder) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn with_capacity_and_hasher(capacity: usize, hash_builder: S) -> HashsetMultiMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | HashsetMultiMap { [INFO] [stdout] 69 | _inner_map: HashMap::with_capacity_and_hasher(capacity, hash_builder) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:500:92 [INFO] [stdout] | [INFO] [stdout] 500 | C5DataValue::Array(inner_value) => Result::Ok(inner_value.into_iter().map(|vec_item| vec_item.try_into().unwrap()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:512:92 [INFO] [stdout] | [INFO] [stdout] 512 | C5DataValue::Array(inner_value) => Result::Ok(inner_value.into_iter().map(|vec_item| vec_item.try_into().unwrap()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c5store` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `c5store` (lib) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1b863e6239db061d1de52dd3edf6ed31cd5db772844d177eb84270ec84868dd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b863e6239db061d1de52dd3edf6ed31cd5db772844d177eb84270ec84868dd4", kill_on_drop: false }` [INFO] [stdout] 1b863e6239db061d1de52dd3edf6ed31cd5db772844d177eb84270ec84868dd4