[INFO] fetching crate c3d-rs 0.1.7... [INFO] checking c3d-rs-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate c3d-rs 0.1.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate c3d-rs 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate c3d-rs 0.1.7 [INFO] finished tweaking crates.io crate c3d-rs 0.1.7 [INFO] tweaked toml for crates.io crate c3d-rs 0.1.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51737fc33f41c992bff7081ac9859ee7e12662bcd1f7b9e023171487eadeb3d6 [INFO] running `Command { std: "docker" "start" "-a" "51737fc33f41c992bff7081ac9859ee7e12662bcd1f7b9e023171487eadeb3d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51737fc33f41c992bff7081ac9859ee7e12662bcd1f7b9e023171487eadeb3d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51737fc33f41c992bff7081ac9859ee7e12662bcd1f7b9e023171487eadeb3d6", kill_on_drop: false }` [INFO] [stdout] 51737fc33f41c992bff7081ac9859ee7e12662bcd1f7b9e023171487eadeb3d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06c9252e308620c6e0bb3f285e59b246f651ce8384b9917dc0c5534c2f09a99f [INFO] running `Command { std: "docker" "start" "-a" "06c9252e308620c6e0bb3f285e59b246f651ce8384b9917dc0c5534c2f09a99f", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking serde_fmt v1.0.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking value-bag-serde1 v1.9.0 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking c3d-rs v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/lib.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parameter` is never read [INFO] [stdout] --> src/lib.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub struct C3dReader<'a, R: Read + Seek> { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 68 | header: &'a HeaderBlock, [INFO] [stdout] 69 | parameter: &'a ParameterBlock, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_chars_size`, `id`, `offset`, and `desc_chars_size` are never read [INFO] [stdout] --> src/lib.rs:611:5 [INFO] [stdout] | [INFO] [stdout] 609 | pub struct ParameterFormat { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 610 | // indicates "locked" if value is negative. [INFO] [stdout] 611 | name_chars_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 612 | id: i8, [INFO] [stdout] | ^^ [INFO] [stdout] 613 | pub name: String, [INFO] [stdout] 614 | offset: i16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 619 | desc_chars_size: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParameterFormat` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(mut file: T) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | file.seek(SeekFrom::Start(0))?; [INFO] [stdout] 36 | let handle = Rc::new(RefCell::new(file)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | Ok(C3dAdapter { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | header: None, [INFO] [stdout] 40 | | parameter: None, [INFO] [stdout] 41 | | handle, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 84 | mut handle: std::cell::RefMut<'a, R>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(C3dReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 139 | | header, [INFO] [stdout] 140 | | parameter, [INFO] [stdout] 141 | | handle, [INFO] [stdout] ... | [INFO] [stdout] 148 | | analog_gen_scale, [INFO] [stdout] 149 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:190:32 [INFO] [stdout] | [INFO] [stdout] 190 | ... arr.clone().read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:194:32 [INFO] [stdout] | [INFO] [stdout] 194 | ... arr.clone().read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 242 | (arr.clone()).read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:247:33 [INFO] [stdout] | [INFO] [stdout] 247 | ... (arr.clone()).read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:250:33 [INFO] [stdout] | [INFO] [stdout] 250 | ... (arr.clone()).read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:487:33 [INFO] [stdout] | [INFO] [stdout] 487 | ... (arr.clone()).read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&mut &[u8]` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:493:33 [INFO] [stdout] | [INFO] [stdout] 493 | ... (arr.clone()).read_exact(&mut buf).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c3d-rs` (lib) due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "06c9252e308620c6e0bb3f285e59b246f651ce8384b9917dc0c5534c2f09a99f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06c9252e308620c6e0bb3f285e59b246f651ce8384b9917dc0c5534c2f09a99f", kill_on_drop: false }` [INFO] [stdout] 06c9252e308620c6e0bb3f285e59b246f651ce8384b9917dc0c5534c2f09a99f