[INFO] fetching crate c-gull 0.17.0... [INFO] checking c-gull-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate c-gull 0.17.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate c-gull 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate c-gull 0.17.0 [INFO] finished tweaking crates.io crate c-gull 0.17.0 [INFO] tweaked toml for crates.io crate c-gull 0.17.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gimli v0.30.0 (latest: v0.31.0) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd4466312b4a63a9015135fc1da361ff0f7bcce9f2ee51b72d580123f69d5a50 [INFO] running `Command { std: "docker" "start" "-a" "fd4466312b4a63a9015135fc1da361ff0f7bcce9f2ee51b72d580123f69d5a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd4466312b4a63a9015135fc1da361ff0f7bcce9f2ee51b72d580123f69d5a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd4466312b4a63a9015135fc1da361ff0f7bcce9f2ee51b72d580123f69d5a50", kill_on_drop: false }` [INFO] [stdout] fd4466312b4a63a9015135fc1da361ff0f7bcce9f2ee51b72d580123f69d5a50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dee1da99cfe5c2fe839b2b74b153e7be9e53940b690176acc78a56ed92a13563 [INFO] running `Command { std: "docker" "start" "-a" "dee1da99cfe5c2fe839b2b74b153e7be9e53940b690176acc78a56ed92a13563", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking gimli v0.30.0 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling c-scape v0.17.0 [INFO] [stderr] Checking posix-regex v0.1.1 [INFO] [stderr] Checking tz-rs v0.6.14 [INFO] [stderr] Checking errno v0.3.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking realpath-ext v0.1.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking cstr_core v0.2.6 [INFO] [stderr] Checking printf-compat v0.1.1 [INFO] [stderr] Checking unwinding v0.2.2 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rustix-futex-sync v0.2.3 [INFO] [stderr] Checking rustix-openpty v0.1.1 [INFO] [stderr] Checking origin v0.20.2 [INFO] [stderr] Checking c-gull v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 65 | fn convert_res(result: Result) -> Option { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | use errno::{set_errno, Errno}; [INFO] [stdout] 67 | / result [INFO] [stdout] 68 | | .map_err(|err| set_errno(Errno(err.raw_os_error()))) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 20 | let mut sh = std::process::Command::new("/bin/sh"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match sh.status() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 21 | let mut lock = LOCK.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match file.read_exact(unsafe { [INFO] [stdout] | ___________^ [INFO] [stdout] 31 | | slice::from_raw_parts_mut(entry as *mut utmpx as *mut u8, size_of::()) [INFO] [stdout] 32 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 120 | let mut lock = LOCK.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | match &mut lock.get_mut().unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:123:62 [INFO] [stdout] | [INFO] [stdout] 123 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:140:62 [INFO] [stdout] | [INFO] [stdout] 140 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:152:62 [INFO] [stdout] | [INFO] [stdout] 152 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:163:62 [INFO] [stdout] | [INFO] [stdout] 163 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 65 | fn convert_res(result: Result) -> Option { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | use errno::{set_errno, Errno}; [INFO] [stdout] 67 | / result [INFO] [stdout] 68 | | .map_err(|err| set_errno(Errno(err.raw_os_error()))) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/system.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 20 | let mut sh = std::process::Command::new("/bin/sh"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match sh.status() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:30:11 [INFO] [stdout] | [INFO] [stdout] 21 | let mut lock = LOCK.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match file.read_exact(unsafe { [INFO] [stdout] | ___________^ [INFO] [stdout] 31 | | slice::from_raw_parts_mut(entry as *mut utmpx as *mut u8, size_of::()) [INFO] [stdout] 32 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 120 | let mut lock = LOCK.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | match &mut lock.get_mut().unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:123:62 [INFO] [stdout] | [INFO] [stdout] 123 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:140:62 [INFO] [stdout] | [INFO] [stdout] 140 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c-gull` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:152:62 [INFO] [stdout] | [INFO] [stdout] 152 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utmp.rs:163:62 [INFO] [stdout] | [INFO] [stdout] 163 | lock.get_or_init(|| (PathBuf::from("/var/run/utmp"), None, unsafe { zeroed() })); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c-gull` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "dee1da99cfe5c2fe839b2b74b153e7be9e53940b690176acc78a56ed92a13563", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dee1da99cfe5c2fe839b2b74b153e7be9e53940b690176acc78a56ed92a13563", kill_on_drop: false }` [INFO] [stdout] dee1da99cfe5c2fe839b2b74b153e7be9e53940b690176acc78a56ed92a13563