[INFO] fetching crate c-closures 0.3.1... [INFO] checking c-closures-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate c-closures 0.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate c-closures 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate c-closures 0.3.1 [INFO] finished tweaking crates.io crate c-closures 0.3.1 [INFO] tweaked toml for crates.io crate c-closures 0.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bindgen v0.53.3 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cexpr v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clang-sys v0.29.3 (latest: v1.8.1) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding libloading v0.5.2 (latest: v0.8.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding shlex v0.1.1 (latest: v1.3.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding which v3.1.1 (latest: v6.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f703997cda98936b899ff534f26a7be59db9638ac56541436bd6fb4ccd6192d [INFO] running `Command { std: "docker" "start" "-a" "4f703997cda98936b899ff534f26a7be59db9638ac56541436bd6fb4ccd6192d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f703997cda98936b899ff534f26a7be59db9638ac56541436bd6fb4ccd6192d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f703997cda98936b899ff534f26a7be59db9638ac56541436bd6fb4ccd6192d", kill_on_drop: false }` [INFO] [stdout] 4f703997cda98936b899ff534f26a7be59db9638ac56541436bd6fb4ccd6192d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fca7f186ef9c586ede7a58dfa7fb3d98f93733fa7109dc2bc73ed092f829cb82 [INFO] running `Command { std: "docker" "start" "-a" "fca7f186ef9c586ede7a58dfa7fb3d98f93733fa7109dc2bc73ed092f829cb82", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling clang-sys v0.29.3 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling bindgen v0.53.3 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Compiling c-closures v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn fn_mut(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | data: Box::into_raw(Box::new(f)) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:33 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn fn_not_mut(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | data: Box::into_raw(Box::new(f)) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn fn_once(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | Self::fn_mut(move |arg| match f.take() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 132 | | Some(f) => f(arg), [INFO] [stdout] 133 | | None => { [INFO] [stdout] 134 | | error!("Function marked as single-use was called more than once, the closure will not be called as that would segfault. A... [INFO] [stdout] 135 | | abort() [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:39 [INFO] [stdout] | [INFO] [stdout] 130 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | Self::fn_mut(move |arg| match f.take() { [INFO] [stdout] | --- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | arg.map(|arg| Box::into_raw(Box::new(f(arg))) as *mut c_void) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | Box::from_raw(t as *mut T); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 206 | let _ = Box::from_raw(t as *mut T); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c-closures` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/c-closures-4d60e1e19e49052e/out/bindings.rs:3:1284 [INFO] [stdout] | [INFO] [stdout] 3 | ...t_eq ! (unsafe { & (* (:: std :: ptr :: null :: < Closure > ())) . function as * const _ as usize } , 0usize , concat ! ("Offset of fi... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deref_nullptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/c-closures-4d60e1e19e49052e/out/bindings.rs:3:1490 [INFO] [stdout] | [INFO] [stdout] 3 | ...t_eq ! (unsafe { & (* (:: std :: ptr :: null :: < Closure > ())) . data as * const _ as usize } , 8usize , concat ! ("Offset of field:... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/c-closures-4d60e1e19e49052e/out/bindings.rs:3:1688 [INFO] [stdout] | [INFO] [stdout] 3 | ...t_eq ! (unsafe { & (* (:: std :: ptr :: null :: < Closure > ())) . delete_data as * const _ as usize } , 16usize , concat ! ("Offset o... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/c-closures-4d60e1e19e49052e/out/bindings.rs:3:1901 [INFO] [stdout] | [INFO] [stdout] 3 | ...t_eq ! (unsafe { & (* (:: std :: ptr :: null :: < Closure > ())) . delete_ret as * const _ as usize } , 24usize , concat ! ("Offset of... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:33 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn fn_mut(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | data: Box::into_raw(Box::new(f)) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:33 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn fn_not_mut(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | data: Box::into_raw(Box::new(f)) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn fn_once(f: Function) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | Self::fn_mut(move |arg| match f.take() { [INFO] [stdout] | ______________________^ [INFO] [stdout] 132 | | Some(f) => f(arg), [INFO] [stdout] 133 | | None => { [INFO] [stdout] 134 | | error!("Function marked as single-use was called more than once, the closure will not be called as that would segfault. A... [INFO] [stdout] 135 | | abort() [INFO] [stdout] 136 | | } [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:131:39 [INFO] [stdout] | [INFO] [stdout] 130 | let mut f = Some(f); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | Self::fn_mut(move |arg| match f.take() { [INFO] [stdout] | --- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:33 [INFO] [stdout] | [INFO] [stdout] 200 | arg.map(|arg| Box::into_raw(Box::new(f(arg))) as *mut c_void) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | Box::from_raw(t as *mut T); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 206 | let _ = Box::from_raw(t as *mut T); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `c-closures` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fca7f186ef9c586ede7a58dfa7fb3d98f93733fa7109dc2bc73ed092f829cb82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fca7f186ef9c586ede7a58dfa7fb3d98f93733fa7109dc2bc73ed092f829cb82", kill_on_drop: false }` [INFO] [stdout] fca7f186ef9c586ede7a58dfa7fb3d98f93733fa7109dc2bc73ed092f829cb82