[INFO] fetching crate byml 0.1.4... [INFO] checking byml-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate byml 0.1.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate byml 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate byml 0.1.4 [INFO] finished tweaking crates.io crate byml 0.1.4 [INFO] tweaked toml for crates.io crate byml 0.1.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding binread v1.4.1 (latest: v2.2.0) [INFO] [stderr] Adding binread_derive v1.4.3 (latest: v2.1.0) [INFO] [stderr] Adding cached v0.20.0 (latest: v0.53.1) [INFO] [stderr] Adding cached_proc_macro v0.4.0 (latest: v0.23.0) [INFO] [stderr] Adding darling v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding parse_int v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding paste v0.1.18 (latest: v1.0.15) [INFO] [stderr] Adding strsim v0.9.3 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding yaz0 v0.1.2 (latest: v0.3.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 92fbcf2d5c907cc89708e2134eaa721a6a0c9f0577f23c17cba96db66fa09c16 [INFO] running `Command { std: "docker" "start" "-a" "92fbcf2d5c907cc89708e2134eaa721a6a0c9f0577f23c17cba96db66fa09c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "92fbcf2d5c907cc89708e2134eaa721a6a0c9f0577f23c17cba96db66fa09c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92fbcf2d5c907cc89708e2134eaa721a6a0c9f0577f23c17cba96db66fa09c16", kill_on_drop: false }` [INFO] [stdout] 92fbcf2d5c907cc89708e2134eaa721a6a0c9f0577f23c17cba96db66fa09c16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a7328bce2216dab43bb99435089a0e1e29bcf99cb035bf65e9f1ce111f83b0d [INFO] running `Command { std: "docker" "start" "-a" "3a7328bce2216dab43bb99435089a0e1e29bcf99cb035bf65e9f1ce111f83b0d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking async-mutex v1.4.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking parse_int v0.4.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking yaz0 v0.1.2 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling binwrite_derive v0.2.1 [INFO] [stderr] Compiling binread_derive v1.4.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking binwrite v0.2.1 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling cached_proc_macro v0.4.0 [INFO] [stderr] Checking binread v1.4.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking cached v0.20.0 [INFO] [stderr] Checking byml v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `seek_convenience` has been stable since 1.51.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(seek_convenience)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `seek_convenience` has been stable since 1.51.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(seek_convenience)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/parse.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 39 | version: u16, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `entries` and `offsets` are never read [INFO] [stdout] --> src/parse.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | struct StringTable { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 48 | entries: U24, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 49 | #[br(count = entries.0)] [INFO] [stdout] 50 | offsets: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StringTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic` and `entries` are never read [INFO] [stdout] --> src/parse.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 243 | struct ArrayHeader { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 244 | magic: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 245 | #[br(map = |x: U24| x.0 as u32)] [INFO] [stdout] 246 | entries: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ArrayHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/write.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StringTable` is never constructed [INFO] [stdout] --> src/write.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | struct StringTable { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AlignedCStr` is never constructed [INFO] [stdout] --> src/write.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 166 | struct AlignedCStr { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/forked/parser.rs:96:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(src: T) -> Parser { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Parser { [INFO] [stdout] 96 | scanner: Scanner::new(src), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `byml` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/parse.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 39 | version: u16, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `entries` and `offsets` are never read [INFO] [stdout] --> src/parse.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | struct StringTable { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 48 | entries: U24, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 49 | #[br(count = entries.0)] [INFO] [stdout] 50 | offsets: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StringTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic` and `entries` are never read [INFO] [stdout] --> src/parse.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 243 | struct ArrayHeader { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 244 | magic: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 245 | #[br(map = |x: U24| x.0 as u32)] [INFO] [stdout] 246 | entries: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ArrayHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/write.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `StringTable` is never constructed [INFO] [stdout] --> src/write.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | struct StringTable { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AlignedCStr` is never constructed [INFO] [stdout] --> src/write.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 166 | struct AlignedCStr { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/forked/parser.rs:96:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(src: T) -> Parser { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Parser { [INFO] [stdout] 96 | scanner: Scanner::new(src), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `byml` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3a7328bce2216dab43bb99435089a0e1e29bcf99cb035bf65e9f1ce111f83b0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a7328bce2216dab43bb99435089a0e1e29bcf99cb035bf65e9f1ce111f83b0d", kill_on_drop: false }` [INFO] [stdout] 3a7328bce2216dab43bb99435089a0e1e29bcf99cb035bf65e9f1ce111f83b0d