[INFO] fetching crate bwavfile 2.0.1... [INFO] checking bwavfile-2.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bwavfile 2.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate bwavfile 2.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bwavfile 2.0.1 [INFO] finished tweaking crates.io crate bwavfile 2.0.1 [INFO] tweaked toml for crates.io crate bwavfile 2.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate bwavfile 2.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49c1201fc65b1247a8f4897932174b50ab745cbacffcc46dd667fa05181ed8ca [INFO] running `Command { std: "docker" "start" "-a" "49c1201fc65b1247a8f4897932174b50ab745cbacffcc46dd667fa05181ed8ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49c1201fc65b1247a8f4897932174b50ab745cbacffcc46dd667fa05181ed8ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49c1201fc65b1247a8f4897932174b50ab745cbacffcc46dd667fa05181ed8ca", kill_on_drop: false }` [INFO] [stdout] 49c1201fc65b1247a8f4897932174b50ab745cbacffcc46dd667fa05181ed8ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d323863a64e49cdfc16ec6afe877f3fa9df30ab3a36a76faa30fee4330b450a4 [INFO] running `Command { std: "docker" "start" "-a" "d323863a64e49cdfc16ec6afe877f3fa9df30ab3a36a76faa30fee4330b450a4", kill_on_drop: false }` [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking bwavfile v2.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `signature` and `length_field` are never read [INFO] [stdout] --> src/parser.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | ReadHeader { [INFO] [stdout] | ---------- fields in this variant [INFO] [stdout] 24 | signature: FourCC, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | length_field: u32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `signature` is never read [INFO] [stdout] --> src/parser.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 27 | ReadRF64Header { [INFO] [stdout] | -------------- field in this variant [INFO] [stdout] 28 | signature: FourCC, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `file_size` and `long_sizes` are never read [INFO] [stdout] --> src/parser.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 30 | ReadDS64 { [INFO] [stdout] | -------- fields in this variant [INFO] [stdout] 31 | file_size: u64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 32 | long_sizes: HashMap, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WriteWavAudioData` is never used [INFO] [stdout] --> src/fmt.rs:432:7 [INFO] [stdout] | [INFO] [stdout] 432 | trait WriteWavAudioData { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn make(stream: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let newmap: HashMap = HashMap::new(); [INFO] [stdout] 72 | let mut the_stream = stream; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | the_stream.seek(Start(0))?; [INFO] [stdout] 74 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | stream: the_stream, [INFO] [stdout] 76 | | state: State::New, [INFO] [stdout] 77 | | ds64state: newmap, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 144 | let event: Event; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok((event, next_state)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 229 | let event; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok((event, state)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wavereader.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(mut inner: R, format: WaveFmt, start: u64, length: u64) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(AudioFrameReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | inner, [INFO] [stdout] 68 | | format, [INFO] [stdout] 69 | | start, [INFO] [stdout] 70 | | length, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wavewriter.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 137 | fn begin(mut inner: WaveWriter, ident: FourCC) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(WaveChunkWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | ident, [INFO] [stdout] 145 | | inner, [INFO] [stdout] 146 | | content_start_pos, [INFO] [stdout] 147 | | length, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wavewriter.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn audio_frame_writer(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let mut chunk = self.chunk(ELM1_SIG)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let closed = chunk.end()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | let inner = closed.chunk(DATA_SIG)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | Ok(AudioFrameWriter::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bwavfile` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d323863a64e49cdfc16ec6afe877f3fa9df30ab3a36a76faa30fee4330b450a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d323863a64e49cdfc16ec6afe877f3fa9df30ab3a36a76faa30fee4330b450a4", kill_on_drop: false }` [INFO] [stdout] d323863a64e49cdfc16ec6afe877f3fa9df30ab3a36a76faa30fee4330b450a4