[INFO] fetching crate bvr 0.0.4... [INFO] checking bvr-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bvr 0.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bvr 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate bvr 0.0.4 [INFO] finished tweaking crates.io crate bvr 0.0.4 [INFO] tweaked toml for crates.io crate bvr 0.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate bvr 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 275cb886213966cf580a6bea24305836fc2965bc23f43da93a54fd2c0876f9e4 [INFO] running `Command { std: "docker" "start" "-a" "275cb886213966cf580a6bea24305836fc2965bc23f43da93a54fd2c0876f9e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "275cb886213966cf580a6bea24305836fc2965bc23f43da93a54fd2c0876f9e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "275cb886213966cf580a6bea24305836fc2965bc23f43da93a54fd2c0876f9e4", kill_on_drop: false }` [INFO] [stdout] 275cb886213966cf580a6bea24305836fc2965bc23f43da93a54fd2c0876f9e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf14058874afa59df84a692ce252b9943497ac19aee8cfdfa8fe7d96a6f5d542 [INFO] running `Command { std: "docker" "start" "-a" "cf14058874afa59df84a692ce252b9943497ac19aee8cfdfa8fe7d96a6f5d542", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking fdeflate v0.3.3 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling x11rb v0.12.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking clap_builder v4.4.14 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking gethostname v0.3.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking lru v0.12.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking memmap2 v0.9.3 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking shlex v1.2.0 [INFO] [stderr] Compiling wayland-scanner v0.31.0 [INFO] [stderr] Compiling wayland-backend v0.3.2 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking tree_magic_mini v3.0.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking x11rb-protocol v0.12.0 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Checking wayland-client v0.31.1 [INFO] [stderr] Checking wayland-protocols v0.31.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking bvr-core v0.0.4 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking clap v4.4.14 [INFO] [stderr] Checking ratatui v0.25.0 [INFO] [stderr] Checking wl-clipboard-rs v0.8.0 [INFO] [stderr] Checking arboard v3.3.0 [INFO] [stderr] Checking bvr v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(name: String, buf: SegBuffer) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut compositor = Compositor::new(&buf); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let composite = compositor.create_composite(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Self { [INFO] [stdout] 49 | view: ViewCache::new(composite), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:50:25 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(name: String, buf: SegBuffer) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut compositor = Compositor::new(&buf); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let composite = compositor.create_composite(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | compositor: Compositor::new(&buf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:279:40 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn export_file(&mut self, mut file: File) -> Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | self.buf [INFO] [stdout] 279 | .write_to_file(&mut file, &self.compositor.create_composite()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/viewer.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub(crate) fn new(composite: LineSet) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | cache: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bvr` (bin "bvr") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(name: String, buf: SegBuffer) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut compositor = Compositor::new(&buf); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let composite = compositor.create_composite(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Self { [INFO] [stdout] 49 | view: ViewCache::new(composite), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:50:25 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(name: String, buf: SegBuffer) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut compositor = Compositor::new(&buf); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let composite = compositor.create_composite(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | compositor: Compositor::new(&buf), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/instance.rs:279:40 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn export_file(&mut self, mut file: File) -> Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | self.buf [INFO] [stdout] 279 | .write_to_file(&mut file, &self.compositor.create_composite()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cli/components/viewer.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub(crate) fn new(composite: LineSet) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | cache: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bvr` (bin "bvr" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "cf14058874afa59df84a692ce252b9943497ac19aee8cfdfa8fe7d96a6f5d542", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf14058874afa59df84a692ce252b9943497ac19aee8cfdfa8fe7d96a6f5d542", kill_on_drop: false }` [INFO] [stdout] cf14058874afa59df84a692ce252b9943497ac19aee8cfdfa8fe7d96a6f5d542