[INFO] fetching crate bustubx 0.3.0... [INFO] checking bustubx-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bustubx 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate bustubx 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bustubx 0.3.0 [INFO] finished tweaking crates.io crate bustubx 0.3.0 [INFO] tweaked toml for crates.io crate bustubx 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding crossterm v0.27.0 (latest: v0.28.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding derive-new v0.5.9 (latest: v0.7.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding sqlparser v0.34.0 (latest: v0.50.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed366fafa79baa133228480feb448ac9c7cafe73ee4a361a154aac6fb1540e09 [INFO] running `Command { std: "docker" "start" "-a" "ed366fafa79baa133228480feb448ac9c7cafe73ee4a361a154aac6fb1540e09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed366fafa79baa133228480feb448ac9c7cafe73ee4a361a154aac6fb1540e09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed366fafa79baa133228480feb448ac9c7cafe73ee4a361a154aac6fb1540e09", kill_on_drop: false }` [INFO] [stdout] ed366fafa79baa133228480feb448ac9c7cafe73ee4a361a154aac6fb1540e09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a7472d16175b4d6e057466465c0e30b7b942ea65bc3e1abe86eacaa73dfa231 [INFO] running `Command { std: "docker" "start" "-a" "6a7472d16175b4d6e057466465c0e30b7b942ea65bc3e1abe86eacaa73dfa231", kill_on_drop: false }` [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking sqlparser v0.34.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive-with v0.5.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking bustubx v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::storage::codec::TablePageCodec` [INFO] [stdout] --> src/catalog/information.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::storage::codec::TablePageCodec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::storage::codec::BPlusTreePageCodec` [INFO] [stdout] --> src/common/util.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::storage::codec::BPlusTreePageCodec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/execution/physical_plan/values.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `catalog::Schema` [INFO] [stdout] --> src/execution/physical_plan/values.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | catalog::Schema, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::storage::codec::TablePageCodec` [INFO] [stdout] --> src/catalog/information.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::storage::codec::TablePageCodec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::storage::codec::BPlusTreePageCodec` [INFO] [stdout] --> src/common/util.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::storage::codec::BPlusTreePageCodec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/execution/physical_plan/values.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `catalog::Schema` [INFO] [stdout] --> src/execution/physical_plan/values.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | catalog::Schema, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `fetch_tree_internal_page` and `delete_page` are never used [INFO] [stdout] --> src/buffer/buffer_pool.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl BufferPoolManager { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn fetch_tree_internal_page( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 187 | pub fn delete_page(&self, page_id: PageId) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `destroy` is never used [INFO] [stdout] --> src/buffer/page.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl Page { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn destroy(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/catalog/catalog.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct CatalogSchema { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 29 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CatalogSchema` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/catalog/catalog.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | pub struct CatalogTable { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 44 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CatalogTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `pretty_format_index_tree` is never used [INFO] [stdout] --> src/common/util.rs:74:15 [INFO] [stdout] | [INFO] [stdout] 74 | pub(crate) fn pretty_format_index_tree(index: &BPlusTreeIndex) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `disk_manager` and `temp_dir` are never read [INFO] [stdout] --> src/database.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Database { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 21 | disk_manager: Arc, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | temp_dir: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `join_type` is never read [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct PhysicalNestedLoopJoin { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 18 | pub join_type: JoinType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhysicalNestedLoopJoin` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `table_schema` is never read [INFO] [stdout] --> src/execution/physical_plan/update.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PhysicalUpdate { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 13 | pub table: TableReference, [INFO] [stdout] 14 | pub table_schema: SchemaRef, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhysicalUpdate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/optimizer/logical_optimizer.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait LogicalOptimizerRule { [INFO] [stdout] | -------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `with_rules` is never used [INFO] [stdout] --> src/optimizer/logical_optimizer.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl LogicalOptimizer { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn with_rules(rules: Vec>) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `deallocate_page`, `freelist_push`, and `db_file_len` are never used [INFO] [stdout] --> src/storage/disk_manager.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl DiskManager { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 147 | pub fn deallocate_page(&self, page_id: PageId) -> BustubxResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 158 | fn freelist_push(&self, page_id: PageId) -> BustubxResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | pub fn db_file_len(&self) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root_page_id` and `write_set` are never read [INFO] [stdout] --> src/storage/index.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | struct Context { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 22 | pub root_page_id: PageId, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 23 | pub write_set: VecDeque, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/storage/index.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 46 | impl BPlusTreeIndex { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn delete(&self, key: &Tuple) -> BustubxResult<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 238 | pub fn get(&self, key: &Tuple) -> BustubxResult> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 328 | fn borrow_min_kv( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 337 | fn borrow_max_kv( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 346 | fn borrow( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 435 | fn find_sibling_pages( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 446 | fn merge( [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 526 | fn find_subtree_max_leafkv(&self, page_id: PageId) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_full` and `push` are never used [INFO] [stdout] --> src/storage/page/freelist_page.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl FreelistPage { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn is_full(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn push(&mut self, page_id: PageId) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_underflow` and `can_borrow` are never used [INFO] [stdout] --> src/storage/page/index_page.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl BPlusTreePage { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn is_underflow(&self, is_root: bool) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn can_borrow(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/storage/page/index_page.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 82 | impl BPlusTreeInternalPage { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn min_size(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 97 | pub fn key_at(&self, index: usize) -> &Tuple { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn values(&self) -> Vec { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub fn sibling_page_ids(&self, page_id: PageId) -> (Option, Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 145 | pub fn delete(&mut self, key: &Tuple) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 181 | pub fn delete_page_id(&mut self, page_id: PageId) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | pub fn reverse_split_off(&mut self, at: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | pub fn replace_key(&mut self, old_key: &Tuple, new_key: Tuple) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 217 | pub fn key_index(&self, key: &Tuple) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `min_size`, `reverse_split_off`, `delete`, `look_up`, and `key_index` are never used [INFO] [stdout] --> src/storage/page/index_page.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 296 | impl BPlusTreeLeafPage { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 323 | pub fn min_size(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 359 | pub fn reverse_split_off(&mut self, at: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 368 | pub fn delete(&mut self, key: &Tuple) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 377 | pub fn look_up(&self, key: &Tuple) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 382 | fn key_index(&self, key: &Tuple) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `update_tuple_meta` and `tuple_meta` are never used [INFO] [stdout] --> src/storage/page/table_page.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 80 | impl TablePage { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 156 | pub fn update_tuple_meta(&mut self, meta: TupleMeta, slot_num: u16) -> BustubxResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | pub fn tuple_meta(&self, slot_num: u16) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `update_tuple_meta` and `tuple_meta` are never used [INFO] [stdout] --> src/storage/table_heap.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl TableHeap { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 124 | pub fn update_tuple_meta(&self, meta: TupleMeta, rid: RecordId) -> BustubxResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 149 | pub fn tuple_meta(&self, rid: RecordId) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `LockMode` is never used [INFO] [stdout] --> src/transaction/lock_manager.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum LockMode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LockMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LockRequest` is never constructed [INFO] [stdout] --> src/transaction/lock_manager.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct LockRequest { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LockManager` is never constructed [INFO] [stdout] --> src/transaction/lock_manager.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct LockManager { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lock_table`, `unlock_table`, `lock_row`, `unlock_row`, and `unlock_all` are never used [INFO] [stdout] --> src/transaction/lock_manager.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl LockManager { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] 29 | pub fn lock_table( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn unlock_table(&self, _txn: Transaction, _table_ref: TableReference) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn lock_row( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn unlock_row( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub fn unlock_all(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Transaction` is never constructed [INFO] [stdout] --> src/transaction/transaction.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Transaction {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `IsolationLevel` is never used [INFO] [stdout] --> src/transaction/transaction_manager.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum IsolationLevel { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TransactionManager` is never constructed [INFO] [stdout] --> src/transaction/transaction_manager.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct TransactionManager {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `begin`, `commit`, and `abort` are never used [INFO] [stdout] --> src/transaction/transaction_manager.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl TransactionManager { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] 12 | pub fn begin(&self, _isolation_level: IsolationLevel) -> Transaction { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn commit(&self, _txn: Transaction) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn abort(&self, _txn: Transaction) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | replacer: Arc::new(RwLock::new(LRUKReplacer::new(num_pages, 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | page_table: Arc::new(DashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | free_list: Arc::new(RwLock::new(free_list)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(PageRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | page: self.pool[frame_id].clone(), [INFO] [stdout] 78 | | page_table: self.page_table.clone(), [INFO] [stdout] 79 | | replacer: self.replacer.clone(), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 124 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ) -> BustubxResult<(PageRef, TablePage)> { [INFO] [stdout] 126 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let (table_page, _) = TablePageCodec::decode(page.read().unwrap().data(), schema.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok((page, table_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 134 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ) -> BustubxResult<(PageRef, BPlusTreePage)> { [INFO] [stdout] 136 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let (tree_page, _) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | BPlusTreePageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 139 | Ok((page, tree_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 145 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> BustubxResult<(PageRef, BPlusTreeInternalPage)> { [INFO] [stdout] 147 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let (tree_internal_page, _) = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | BPlusTreeInternalPageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 150 | Ok((page, tree_internal_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 156 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | ) -> BustubxResult<(PageRef, BPlusTreeLeafPage)> { [INFO] [stdout] 158 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let (tree_leaf_page, _) = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | BPlusTreeLeafPageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 161 | Ok((page, tree_leaf_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tables: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(name: impl Into, table: Arc) -> Self { [INFO] [stdout] | ----------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | indexes: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn new(buffer_pool: Arc) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self { [INFO] [stdout] 62 | schemas: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn try_merge(schemas: impl IntoIterator) -> BustubxResult { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut columns = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Self::new_with_check(columns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 59 | let new_columns = indices [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Schema::new_with_check(new_columns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | Ok(self.columns[index].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/aggregate.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 29 | input: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | group_exprs: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | aggr_exprs: Vec, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | output_rows: Mutex::new(vec![]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/create_index.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 36 | let key_schema = Arc::new(self.table_schema.project(&key_indices)?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | start_bound: range.start_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | end_bound: range.end_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 29 | condition: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | left_input: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | right_input: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | left_tuple: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 53 | let left_tuple = self.left_tuple.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut left_next_tuple = if left_tuple.is_none() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/seq_scan.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(table: TableReference, table_schema: SchemaRef) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/sort.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(order_bys: Vec, input: Arc) -> Self { [INFO] [stdout] | --------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | all_tuples: Mutex::new(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/update.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 25 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | assignments: HashMap, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | selection: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | table_iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/logical_optimizer.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 108 | let result = inputs [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let new_inputs = result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | plan.with_new_inputs(&new_inputs).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/rule/merge_limit.rs:31:50 [INFO] [stdout] | [INFO] [stdout] 25 | let plan = LogicalPlan::Limit(Limit { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | .map(|opt_plan| opt_plan.or_else(|| Some(plan))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_plan/util.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 23 | let columns: Vec = match join_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Schema { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/logical_planner.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | let expr = self.bind_expr(&order_by.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(OrderByExpr { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | expr: Box::new(expr), [INFO] [stdout] 50 | | asc: order_by.asc.unwrap_or(true), [INFO] [stdout] 51 | | nulls_first: order_by.nulls_first.unwrap_or(false), [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_create_index.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | let mut columns_expr = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let table_schema = self.context.catalog.table_heap(&table)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(LogicalPlan::CreateIndex(CreateIndex { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | index_name, [INFO] [stdout] 28 | | table, [INFO] [stdout] 29 | | table_schema, [INFO] [stdout] 30 | | columns: columns_expr, [INFO] [stdout] 31 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_create_table.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(LogicalPlan::CreateTable(CreateTable { name, columns })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_insert.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 15 | let mut input = self.plan_set_expr(source.body.as_ref())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let table = self.bind_table_name(table_name)?; [INFO] [stdout] 17 | let table_schema = self.context.catalog.table_heap(&table)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let projected_schema = if columns_ident.is_empty() { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(LogicalPlan::Insert(Insert { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | table, [INFO] [stdout] 43 | | table_schema, [INFO] [stdout] 44 | | projected_schema, [INFO] [stdout] 45 | | input: Arc::new(input), [INFO] [stdout] 46 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_query.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 19 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let mut order_by_exprs = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(LogicalPlan::Sort(Sort { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | order_by: order_by_exprs, [INFO] [stdout] 33 | | input: Arc::new(input), [INFO] [stdout] 34 | | limit: None, [INFO] [stdout] 35 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_query.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 40 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(LogicalPlan::Limit(Limit { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | limit, [INFO] [stdout] 92 | | offset, [INFO] [stdout] 93 | | input: Arc::new(input), [INFO] [stdout] 94 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 77 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let columnized_exprs = exprs [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let schema = Arc::new(project_schema(&input, &columnized_exprs)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(LogicalPlan::Project(Project { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | exprs: columnized_exprs, [INFO] [stdout] 98 | | input: Arc::new(input), [INFO] [stdout] 99 | | schema, [INFO] [stdout] 100 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 246 | left: LogicalPlan, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | right: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | ) -> BustubxResult { [INFO] [stdout] 249 | let schema = Arc::new(build_join_schema( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(LogicalPlan::Join(Join { [INFO] [stdout] | ____________^ [INFO] [stdout] 255 | | left: Arc::new(left), [INFO] [stdout] 256 | | right: Arc::new(right), [INFO] [stdout] 257 | | join_type: JoinType::Cross, [INFO] [stdout] 258 | | condition: None, [INFO] [stdout] 259 | | schema, [INFO] [stdout] 260 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 295 | let mut result = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(LogicalPlan::Values(Values { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | schema: Arc::new(Schema::empty()), [INFO] [stdout] 307 | | values: result, [INFO] [stdout] 308 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_update.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 23 | let table_schema = self.context.catalog.table_heap(&table_ref)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let mut assignment_map = HashMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let selection = match selection { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(LogicalPlan::Update(Update { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | table: table_ref, [INFO] [stdout] 47 | | table_schema, [INFO] [stdout] 48 | | assignments: assignment_map, [INFO] [stdout] 49 | | selection, [INFO] [stdout] 50 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/codec/table_page.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn decode(bytes: &[u8], schema: SchemaRef) -> BustubxResult> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | TablePage { [INFO] [stdout] 29 | | schema, [INFO] [stdout] 30 | | header, [INFO] [stdout] ... | [INFO] [stdout] 33 | | BUSTUBX_PAGE_SIZE, [INFO] [stdout] 34 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/codec/tuple.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn decode(bytes: &[u8], schema: SchemaRef) -> BustubxResult> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok((Tuple::new(schema, data), total_offset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:596:26 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | start_bound: range.start_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:597:24 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | end_bound: range.end_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:598:24 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | leaf_page: BPlusTreeLeafPage::empty(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/index_page.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(schema: SchemaRef, max_size: u32) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | array: Vec::with_capacity(max_size as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/index_page.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn new(schema: SchemaRef, max_size: u32) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | array: Vec::with_capacity(max_size as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/table_page.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 219 | let (tuple, _) = TupleCodec::decode( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | Ok((meta, tuple)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/table_heap.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_new(schema: SchemaRef, buffer_pool: Arc) -> BustubxResult { [INFO] [stdout] | ----------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | // new a page and initialize [INFO] [stdout] 25 | let first_page = buffer_pool.new_page()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let first_page_id = first_page.read().unwrap().page_id; [INFO] [stdout] 27 | let table_page = TablePage::new(schema.clone(), INVALID_PAGE_ID); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | schema, [INFO] [stdout] 35 | | buffer_pool, [INFO] [stdout] 36 | | first_page_id: AtomicPageId::new(first_page_id), [INFO] [stdout] 37 | | last_page_id: AtomicPageId::new(first_page_id), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/tuple.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn project_with_schema(&self, projected_schema: SchemaRef) -> BustubxResult { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Self::new(projected_schema, projected_data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/tuple.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn try_merge(tuples: impl IntoIterator) -> BustubxResult { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut data = vec![]; [INFO] [stdout] 55 | let mut merged_schema = Schema::empty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Self::new(Arc::new(merged_schema), data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 48 previous errors; 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bustubx` (lib) due to 49 previous errors; 31 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/catalog/catalog.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct CatalogSchema { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 29 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CatalogSchema` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/catalog/catalog.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | pub struct CatalogTable { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 44 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CatalogTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `disk_manager` and `temp_dir` are never read [INFO] [stdout] --> src/database.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Database { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 21 | disk_manager: Arc, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | temp_dir: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `join_type` is never read [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct PhysicalNestedLoopJoin { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] 18 | pub join_type: JoinType, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhysicalNestedLoopJoin` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `table_schema` is never read [INFO] [stdout] --> src/execution/physical_plan/update.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PhysicalUpdate { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 13 | pub table: TableReference, [INFO] [stdout] 14 | pub table_schema: SchemaRef, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhysicalUpdate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `name` is never used [INFO] [stdout] --> src/optimizer/logical_optimizer.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait LogicalOptimizerRule { [INFO] [stdout] | -------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn name(&self) -> &str; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root_page_id` and `write_set` are never read [INFO] [stdout] --> src/storage/index.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | struct Context { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 22 | pub root_page_id: PageId, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 23 | pub write_set: VecDeque, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_subtree_max_leafkv` is never used [INFO] [stdout] --> src/storage/index.rs:526:8 [INFO] [stdout] | [INFO] [stdout] 46 | impl BPlusTreeIndex { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 526 | fn find_subtree_max_leafkv(&self, page_id: PageId) -> BustubxResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `LockMode` is never used [INFO] [stdout] --> src/transaction/lock_manager.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | pub enum LockMode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LockMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LockRequest` is never constructed [INFO] [stdout] --> src/transaction/lock_manager.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct LockRequest { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LockManager` is never constructed [INFO] [stdout] --> src/transaction/lock_manager.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct LockManager { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lock_table`, `unlock_table`, `lock_row`, `unlock_row`, and `unlock_all` are never used [INFO] [stdout] --> src/transaction/lock_manager.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl LockManager { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] 29 | pub fn lock_table( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn unlock_table(&self, _txn: Transaction, _table_ref: TableReference) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn lock_row( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn unlock_row( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub fn unlock_all(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Transaction` is never constructed [INFO] [stdout] --> src/transaction/transaction.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Transaction {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `IsolationLevel` is never used [INFO] [stdout] --> src/transaction/transaction_manager.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum IsolationLevel { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TransactionManager` is never constructed [INFO] [stdout] --> src/transaction/transaction_manager.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct TransactionManager {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `begin`, `commit`, and `abort` are never used [INFO] [stdout] --> src/transaction/transaction_manager.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl TransactionManager { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] 12 | pub fn begin(&self, _isolation_level: IsolationLevel) -> Transaction { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | pub fn commit(&self, _txn: Transaction) -> bool { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn abort(&self, _txn: Transaction) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:45:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | replacer: Arc::new(RwLock::new(LRUKReplacer::new(num_pages, 2))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | page_table: Arc::new(DashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(num_pages: usize, disk_manager: Arc) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let mut free_list = VecDeque::with_capacity(num_pages); [INFO] [stdout] 37 | let mut pool = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | free_list: Arc::new(RwLock::new(free_list)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | Ok(PageRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | page: self.pool[frame_id].clone(), [INFO] [stdout] 78 | | page_table: self.page_table.clone(), [INFO] [stdout] 79 | | replacer: self.replacer.clone(), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 124 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ) -> BustubxResult<(PageRef, TablePage)> { [INFO] [stdout] 126 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let (table_page, _) = TablePageCodec::decode(page.read().unwrap().data(), schema.clone())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Ok((page, table_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 134 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ) -> BustubxResult<(PageRef, BPlusTreePage)> { [INFO] [stdout] 136 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let (tree_page, _) = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | BPlusTreePageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 139 | Ok((page, tree_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 145 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> BustubxResult<(PageRef, BPlusTreeInternalPage)> { [INFO] [stdout] 147 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let (tree_internal_page, _) = [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | BPlusTreeInternalPageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 150 | Ok((page, tree_internal_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/buffer_pool.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 156 | key_schema: SchemaRef, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | ) -> BustubxResult<(PageRef, BPlusTreeLeafPage)> { [INFO] [stdout] 158 | let page = self.fetch_page(page_id)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let (tree_leaf_page, _) = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | BPlusTreeLeafPageCodec::decode(page.read().unwrap().data(), key_schema.clone())?; [INFO] [stdout] 161 | Ok((page, tree_leaf_page)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | tables: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(name: impl Into, table: Arc) -> Self { [INFO] [stdout] | ----------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | indexes: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/catalog.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn new(buffer_pool: Arc) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self { [INFO] [stdout] 62 | schemas: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn try_merge(schemas: impl IntoIterator) -> BustubxResult { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut columns = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Self::new_with_check(columns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 59 | let new_columns = indices [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Schema::new_with_check(new_columns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/schema.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | Ok(self.columns[index].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/aggregate.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 29 | input: Arc, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | group_exprs: Vec, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | aggr_exprs: Vec, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | output_rows: Mutex::new(vec![]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/create_index.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 36 | let key_schema = Arc::new(self.table_schema.project(&key_indices)?); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:30:26 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | start_bound: range.start_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | end_bound: range.end_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/index_scan.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 23 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 29 | condition: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | left_input: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | right_input: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | schema: SchemaRef, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | left_tuple: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/nested_loop_join.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 53 | let left_tuple = self.left_tuple.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut left_next_tuple = if left_tuple.is_none() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/seq_scan.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(table: TableReference, table_schema: SchemaRef) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/sort.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(order_bys: Vec, input: Arc) -> Self { [INFO] [stdout] | --------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | all_tuples: Mutex::new(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/execution/physical_plan/update.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 25 | table_schema: SchemaRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | assignments: HashMap, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | selection: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | table_iterator: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/logical_optimizer.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 108 | let result = inputs [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let new_inputs = result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | plan.with_new_inputs(&new_inputs).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/rule/merge_limit.rs:31:50 [INFO] [stdout] | [INFO] [stdout] 25 | let plan = LogicalPlan::Limit(Limit { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | .map(|opt_plan| opt_plan.or_else(|| Some(plan))) [INFO] [stdout] | -------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_plan/util.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 23 | let columns: Vec = match join_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Schema { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/logical_planner.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | let expr = self.bind_expr(&order_by.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(OrderByExpr { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | expr: Box::new(expr), [INFO] [stdout] 50 | | asc: order_by.asc.unwrap_or(true), [INFO] [stdout] 51 | | nulls_first: order_by.nulls_first.unwrap_or(false), [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_create_index.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | let mut columns_expr = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let table_schema = self.context.catalog.table_heap(&table)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(LogicalPlan::CreateIndex(CreateIndex { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | index_name, [INFO] [stdout] 28 | | table, [INFO] [stdout] 29 | | table_schema, [INFO] [stdout] 30 | | columns: columns_expr, [INFO] [stdout] 31 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_create_table.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(LogicalPlan::CreateTable(CreateTable { name, columns })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_insert.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 15 | let mut input = self.plan_set_expr(source.body.as_ref())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let table = self.bind_table_name(table_name)?; [INFO] [stdout] 17 | let table_schema = self.context.catalog.table_heap(&table)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let projected_schema = if columns_ident.is_empty() { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(LogicalPlan::Insert(Insert { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | table, [INFO] [stdout] 43 | | table_schema, [INFO] [stdout] 44 | | projected_schema, [INFO] [stdout] 45 | | input: Arc::new(input), [INFO] [stdout] 46 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_query.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 19 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let mut order_by_exprs = vec![]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(LogicalPlan::Sort(Sort { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | order_by: order_by_exprs, [INFO] [stdout] 33 | | input: Arc::new(input), [INFO] [stdout] 34 | | limit: None, [INFO] [stdout] 35 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_query.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 40 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(LogicalPlan::Limit(Limit { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | limit, [INFO] [stdout] 92 | | offset, [INFO] [stdout] 93 | | input: Arc::new(input), [INFO] [stdout] 94 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 77 | input: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let mut exprs = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let columnized_exprs = exprs [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let schema = Arc::new(project_schema(&input, &columnized_exprs)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(LogicalPlan::Project(Project { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | exprs: columnized_exprs, [INFO] [stdout] 98 | | input: Arc::new(input), [INFO] [stdout] 99 | | schema, [INFO] [stdout] 100 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 246 | left: LogicalPlan, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | right: LogicalPlan, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | ) -> BustubxResult { [INFO] [stdout] 249 | let schema = Arc::new(build_join_schema( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(LogicalPlan::Join(Join { [INFO] [stdout] | ____________^ [INFO] [stdout] 255 | | left: Arc::new(left), [INFO] [stdout] 256 | | right: Arc::new(right), [INFO] [stdout] 257 | | join_type: JoinType::Cross, [INFO] [stdout] 258 | | condition: None, [INFO] [stdout] 259 | | schema, [INFO] [stdout] 260 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_set_expr.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 295 | let mut result = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(LogicalPlan::Values(Values { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | schema: Arc::new(Schema::empty()), [INFO] [stdout] 307 | | values: result, [INFO] [stdout] 308 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/planner/logical_planner/plan_update.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 23 | let table_schema = self.context.catalog.table_heap(&table_ref)?.schema.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let mut assignment_map = HashMap::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let selection = match selection { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(LogicalPlan::Update(Update { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | table: table_ref, [INFO] [stdout] 47 | | table_schema, [INFO] [stdout] 48 | | assignments: assignment_map, [INFO] [stdout] 49 | | selection, [INFO] [stdout] 50 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/codec/table_page.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn decode(bytes: &[u8], schema: SchemaRef) -> BustubxResult> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | TablePage { [INFO] [stdout] 29 | | schema, [INFO] [stdout] 30 | | header, [INFO] [stdout] ... | [INFO] [stdout] 33 | | BUSTUBX_PAGE_SIZE, [INFO] [stdout] 34 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/codec/tuple.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn decode(bytes: &[u8], schema: SchemaRef) -> BustubxResult> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok((Tuple::new(schema, data), total_offset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:596:26 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | start_bound: range.start_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:597:24 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | end_bound: range.end_bound().cloned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/index.rs:598:24 [INFO] [stdout] | [INFO] [stdout] 593 | pub fn new>(index: Arc, range: R) -> Self { [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | leaf_page: BPlusTreeLeafPage::empty(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/index_page.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(schema: SchemaRef, max_size: u32) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | array: Vec::with_capacity(max_size as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/index_page.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn new(schema: SchemaRef, max_size: u32) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | array: Vec::with_capacity(max_size as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/page/table_page.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 219 | let (tuple, _) = TupleCodec::decode( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | Ok((meta, tuple)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/table_heap.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn try_new(schema: SchemaRef, buffer_pool: Arc) -> BustubxResult { [INFO] [stdout] | ----------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | // new a page and initialize [INFO] [stdout] 25 | let first_page = buffer_pool.new_page()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let first_page_id = first_page.read().unwrap().page_id; [INFO] [stdout] 27 | let table_page = TablePage::new(schema.clone(), INVALID_PAGE_ID); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | schema, [INFO] [stdout] 35 | | buffer_pool, [INFO] [stdout] 36 | | first_page_id: AtomicPageId::new(first_page_id), [INFO] [stdout] 37 | | last_page_id: AtomicPageId::new(first_page_id), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/tuple.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn project_with_schema(&self, projected_schema: SchemaRef) -> BustubxResult { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Self::new(projected_schema, projected_data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/tuple.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn try_merge(tuples: impl IntoIterator) -> BustubxResult { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut data = vec![]; [INFO] [stdout] 55 | let mut merged_schema = Schema::empty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Self::new(Arc::new(merged_schema), data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 48 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bustubx` (lib test) due to 49 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6a7472d16175b4d6e057466465c0e30b7b942ea65bc3e1abe86eacaa73dfa231", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a7472d16175b4d6e057466465c0e30b7b942ea65bc3e1abe86eacaa73dfa231", kill_on_drop: false }` [INFO] [stdout] 6a7472d16175b4d6e057466465c0e30b7b942ea65bc3e1abe86eacaa73dfa231