[INFO] fetching crate burner 0.2.3... [INFO] checking burner-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate burner 0.2.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate burner 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate burner 0.2.3 [INFO] finished tweaking crates.io crate burner 0.2.3 [INFO] tweaked toml for crates.io crate burner 0.2.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16abe8ce9a4f7053a2acfdfa3ea094999de7cdba9d15f5f5bbded3600a633292 [INFO] running `Command { std: "docker" "start" "-a" "16abe8ce9a4f7053a2acfdfa3ea094999de7cdba9d15f5f5bbded3600a633292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16abe8ce9a4f7053a2acfdfa3ea094999de7cdba9d15f5f5bbded3600a633292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16abe8ce9a4f7053a2acfdfa3ea094999de7cdba9d15f5f5bbded3600a633292", kill_on_drop: false }` [INFO] [stdout] 16abe8ce9a4f7053a2acfdfa3ea094999de7cdba9d15f5f5bbded3600a633292 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6a199619c86d99523527c7ab3af9a3a16c9240617bf1086fdf0b560c7e33f57 [INFO] running `Command { std: "docker" "start" "-a" "b6a199619c86d99523527c7ab3af9a3a16c9240617bf1086fdf0b560c7e33f57", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking burner v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/route.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Value` and `json` [INFO] [stdout] --> src/server.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_json::{Value, json}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/router.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/route.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Value` and `json` [INFO] [stdout] --> src/server.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_json::{Value, json}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/router.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `status_message` [INFO] [stdout] --> src/response.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let status_message = self.get_status_message(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_status_message` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/server.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/router.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn handle_request(&self, mut req: &mut Request, res: &mut Response, parent_path: &String) -> bool { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path`, `method`, and `handler` are never read [INFO] [stdout] --> src/route.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct MiddlewareRoute { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 29 | pub path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | pub method: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 31 | handler: Middleware [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `handle` is never used [INFO] [stdout] --> src/route.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl MiddlewareRoute { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn handle(&self, req: &Request, res: &Response){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/thread_pool.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | struct Worker { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 48 | id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/route.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | &(self.handler)(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = &(self.handler)(req, res); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/route.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | &(self.handler)(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = &(self.handler)(req, res); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | thread: Some(thread) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `burner` (lib) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `status_message` [INFO] [stdout] --> src/response.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let status_message = self.get_status_message(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_status_message` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/server.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | Err(err) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/router.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn handle_request(&self, mut req: &mut Request, res: &mut Response, parent_path: &String) -> bool { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path`, `method`, and `handler` are never read [INFO] [stdout] --> src/route.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct MiddlewareRoute { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 29 | pub path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | pub method: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 31 | handler: Middleware [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `handle` is never used [INFO] [stdout] --> src/route.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl MiddlewareRoute { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn handle(&self, req: &Request, res: &Response){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/thread_pool.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | struct Worker { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 48 | id: usize, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/route.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | &(self.handler)(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 23 | let _ = &(self.handler)(req, res); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/route.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | &(self.handler)(req, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = &(self.handler)(req, res); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 53 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | thread: Some(thread) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `burner` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b6a199619c86d99523527c7ab3af9a3a16c9240617bf1086fdf0b560c7e33f57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6a199619c86d99523527c7ab3af9a3a16c9240617bf1086fdf0b560c7e33f57", kill_on_drop: false }` [INFO] [stdout] b6a199619c86d99523527c7ab3af9a3a16c9240617bf1086fdf0b560c7e33f57