[INFO] fetching crate burn-dataset 0.14.0... [INFO] checking burn-dataset-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate burn-dataset 0.14.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate burn-dataset 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate burn-dataset 0.14.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate burn-dataset 0.14.0 [INFO] tweaked toml for crates.io crate burn-dataset 0.14.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate burn-dataset 0.14.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e1c9bfc31acff82ddad64f0f6c19f16cadd36fae3f97292b42adeca7f39e226 [INFO] running `Command { std: "docker" "start" "-a" "2e1c9bfc31acff82ddad64f0f6c19f16cadd36fae3f97292b42adeca7f39e226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e1c9bfc31acff82ddad64f0f6c19f16cadd36fae3f97292b42adeca7f39e226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e1c9bfc31acff82ddad64f0f6c19f16cadd36fae3f97292b42adeca7f39e226", kill_on_drop: false }` [INFO] [stdout] 2e1c9bfc31acff82ddad64f0f6c19f16cadd36fae3f97292b42adeca7f39e226 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3438cffe887f6d240783e690063da1983dc58b07af285d3a2ea496b2ca4278ed [INFO] running `Command { std: "docker" "start" "-a" "3438cffe887f6d240783e690063da1983dc58b07af285d3a2ea496b2ca4278ed", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.157 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking bitstream-io v2.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking rgb v0.8.48 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking sanitize-filename v0.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling derive-new v0.6.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking gix-fs v0.11.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking fake v2.9.2 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking gix-tempfile v14.0.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.19.0 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking ravif v0.11.10 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking serde_rusqlite v0.35.0 [INFO] [stderr] Checking r2d2_sqlite v0.24.0 [INFO] [stderr] Checking burn-dataset v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/sqlite.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn from_db_file>(db_file: P, split: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | // Create a connection pool [INFO] [stdout] 106 | let conn_pool = create_conn_pool(&db_file, false)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(SqliteDataset { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | db_file: db_file.as_ref().to_path_buf(), [INFO] [stdout] 123 | | split: split.to_string(), [INFO] [stdout] 124 | | conn_pool, [INFO] [stdout] ... | [INFO] [stdout] 129 | | phantom: PhantomData, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/sqlite.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 268 | db_file: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | let manager = SqliteConnectionManager::file(db_file).with_flags(sqlite_flags); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Pool::new(manager).map_err(SqliteDatasetError::ConnectionPool) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `burn-dataset` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/sqlite.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn from_db_file>(db_file: P, split: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | // Create a connection pool [INFO] [stdout] 106 | let conn_pool = create_conn_pool(&db_file, false)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(SqliteDataset { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | db_file: db_file.as_ref().to_path_buf(), [INFO] [stdout] 123 | | split: split.to_string(), [INFO] [stdout] 124 | | conn_pool, [INFO] [stdout] ... | [INFO] [stdout] 129 | | phantom: PhantomData, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataset/sqlite.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 268 | db_file: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | let manager = SqliteConnectionManager::file(db_file).with_flags(sqlite_flags); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | Pool::new(manager).map_err(SqliteDatasetError::ConnectionPool) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `burn-dataset` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "3438cffe887f6d240783e690063da1983dc58b07af285d3a2ea496b2ca4278ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3438cffe887f6d240783e690063da1983dc58b07af285d3a2ea496b2ca4278ed", kill_on_drop: false }` [INFO] [stdout] 3438cffe887f6d240783e690063da1983dc58b07af285d3a2ea496b2ca4278ed