[INFO] fetching crate bundle_tool 0.3.2... [INFO] checking bundle_tool-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bundle_tool 0.3.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bundle_tool 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bundle_tool 0.3.2 [INFO] finished tweaking crates.io crate bundle_tool 0.3.2 [INFO] tweaked toml for crates.io crate bundle_tool 0.3.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate bundle_tool 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41736b825d3ea1e0316da80ef3f909f00b3d7839a87e978f7702ad784eec058c [INFO] running `Command { std: "docker" "start" "-a" "41736b825d3ea1e0316da80ef3f909f00b3d7839a87e978f7702ad784eec058c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41736b825d3ea1e0316da80ef3f909f00b3d7839a87e978f7702ad784eec058c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41736b825d3ea1e0316da80ef3f909f00b3d7839a87e978f7702ad784eec058c", kill_on_drop: false }` [INFO] [stdout] 41736b825d3ea1e0316da80ef3f909f00b3d7839a87e978f7702ad784eec058c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34f83e603e329e5d324ac671e9396b6ae706d8775bbb32099bcb4aa839dfb71b [INFO] running `Command { std: "docker" "start" "-a" "34f83e603e329e5d324ac671e9396b6ae706d8775bbb32099bcb4aa839dfb71b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking is_executable v1.0.1 [INFO] [stderr] Checking pathdiff v0.2.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking plist v1.1.0 [INFO] [stderr] Compiling clap_derive v3.0.0-rc.0 [INFO] [stderr] Checking clap v3.0.0-rc.0 [INFO] [stderr] Checking bundle_tool v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 138 | fn wrap_error(self, operation: FileOperation, path: F) -> ToolResult [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | self.map_err(|e| ToolError::FileOperation { [INFO] [stdout] | ______________________^ [INFO] [stdout] 143 | | operation, [INFO] [stdout] 144 | | path: path(), [INFO] [stdout] 145 | | source_path: None, [INFO] [stdout] 146 | | source: e, [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:160:22 [INFO] [stdout] | [INFO] [stdout] 151 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | operation: FileOperation, [INFO] [stdout] 153 | path: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | source_path: G, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | self.map_err(|e| ToolError::FileOperation { [INFO] [stdout] | ______________________^ [INFO] [stdout] 161 | | operation, [INFO] [stdout] 162 | | path: path(), [INFO] [stdout] 163 | | source_path: Some(source_path()), [INFO] [stdout] 164 | | source: e, [INFO] [stdout] 165 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 170 | fn wrap_error(self, path: F) -> ToolResult [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | self.map_err(|e| ToolError::Plist { [INFO] [stdout] | ______________________^ [INFO] [stdout] 175 | | path: path(), [INFO] [stdout] 176 | | error: e, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/codesign.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 160 | let plist = plist::Value::from_file(info_plist).wrap_error(|| Some(info_plist.into()))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Err(ToolError::OtherError("Malformed info.plist".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/codesign.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 172 | let plist = plist::Value::from_file(&info_plist).wrap_error(|| Some(info_plist))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Err(ToolError::OtherError("Malformed info.plist".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/notarize.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 76 | let mut command = Command::new("xcrun"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let plist = plist::Value::from_reader_xml(res.as_bytes()).wrap_error(|| None)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Err(ToolError::OtherError(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 109 | | "Malformed notarization response: {:}", [INFO] [stdout] 110 | | res, [INFO] [stdout] 111 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bundle_tool` (bin "cargo-bundle-tool") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:142:22 [INFO] [stdout] | [INFO] [stdout] 138 | fn wrap_error(self, operation: FileOperation, path: F) -> ToolResult [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | self.map_err(|e| ToolError::FileOperation { [INFO] [stdout] | ______________________^ [INFO] [stdout] 143 | | operation, [INFO] [stdout] 144 | | path: path(), [INFO] [stdout] 145 | | source_path: None, [INFO] [stdout] 146 | | source: e, [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:160:22 [INFO] [stdout] | [INFO] [stdout] 151 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | operation: FileOperation, [INFO] [stdout] 153 | path: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | source_path: G, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | self.map_err(|e| ToolError::FileOperation { [INFO] [stdout] | ______________________^ [INFO] [stdout] 161 | | operation, [INFO] [stdout] 162 | | path: path(), [INFO] [stdout] 163 | | source_path: Some(source_path()), [INFO] [stdout] 164 | | source: e, [INFO] [stdout] 165 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 170 | fn wrap_error(self, path: F) -> ToolResult [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | self.map_err(|e| ToolError::Plist { [INFO] [stdout] | ______________________^ [INFO] [stdout] 175 | | path: path(), [INFO] [stdout] 176 | | error: e, [INFO] [stdout] 177 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/codesign.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 160 | let plist = plist::Value::from_file(info_plist).wrap_error(|| Some(info_plist.into()))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Err(ToolError::OtherError("Malformed info.plist".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/codesign.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 172 | let plist = plist::Value::from_file(&info_plist).wrap_error(|| Some(info_plist))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Err(ToolError::OtherError("Malformed info.plist".into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macos/notarize.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 76 | let mut command = Command::new("xcrun"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let plist = plist::Value::from_reader_xml(res.as_bytes()).wrap_error(|| None)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Err(ToolError::OtherError(format!( [INFO] [stdout] | _____________^ [INFO] [stdout] 109 | | "Malformed notarization response: {:}", [INFO] [stdout] 110 | | res, [INFO] [stdout] 111 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bundle_tool` (bin "cargo-bundle-tool" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "34f83e603e329e5d324ac671e9396b6ae706d8775bbb32099bcb4aa839dfb71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34f83e603e329e5d324ac671e9396b6ae706d8775bbb32099bcb4aa839dfb71b", kill_on_drop: false }` [INFO] [stdout] 34f83e603e329e5d324ac671e9396b6ae706d8775bbb32099bcb4aa839dfb71b