[INFO] fetching crate bulut 0.3.0... [INFO] checking bulut-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bulut 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bulut 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bulut 0.3.0 [INFO] finished tweaking crates.io crate bulut 0.3.0 [INFO] tweaked toml for crates.io crate bulut 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate bulut 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0093a29298f4bb53f1c14765587c9af5dc52fad73d895f3e42e33d015718e5f [INFO] running `Command { std: "docker" "start" "-a" "a0093a29298f4bb53f1c14765587c9af5dc52fad73d895f3e42e33d015718e5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0093a29298f4bb53f1c14765587c9af5dc52fad73d895f3e42e33d015718e5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0093a29298f4bb53f1c14765587c9af5dc52fad73d895f3e42e33d015718e5f", kill_on_drop: false }` [INFO] [stdout] a0093a29298f4bb53f1c14765587c9af5dc52fad73d895f3e42e33d015718e5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73d35374fe0470f9d6278fbc2a33d2281be474df5ce3e93852e28b768f16af22 [INFO] running `Command { std: "docker" "start" "-a" "73d35374fe0470f9d6278fbc2a33d2281be474df5ce3e93852e28b768f16af22", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking bulut v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/error.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | match self.clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `VmError` does not implement `Clone`, so calling `clone` on `&VmError` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 13 - match self.clone() { [INFO] [stdout] 13 + match self { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `VmError`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 4 + #[derive(Clone)] [INFO] [stdout] 5 | pub enum VmError { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn from_native(f: Box) -> Value + Send>) -> Function { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Function::Native(NativeFunction(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_info.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(obj: Box) -> ObjectInfo { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | native_ref_info: ObjectNativeRefInfo { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 34 | | n_refs: Rc::new(Cell::new(0)), [INFO] [stdout] 35 | | gc_notified: false, [INFO] [stdout] 36 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_info.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn downcast_from(other: ObjectHandle<'a>) -> Option> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Some(TypedObjectHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 119 | | _handle: other, [INFO] [stdout] 120 | | value, [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/error.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | match self.clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `VmError` does not implement `Clone`, so calling `clone` on `&VmError` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 13 - match self.clone() { [INFO] [stdout] 13 + match self { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `VmError`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 4 + #[derive(Clone)] [INFO] [stdout] 5 | pub enum VmError { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn from_native(f: Box) -> Value + Send>) -> Function { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Function::Native(NativeFunction(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_info.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(obj: Box) -> ObjectInfo { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | native_ref_info: ObjectNativeRefInfo { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 34 | | n_refs: Rc::new(Cell::new(0)), [INFO] [stdout] 35 | | gc_notified: false, [INFO] [stdout] 36 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_info.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn downcast_from(other: ObjectHandle<'a>) -> Option> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Some(TypedObjectHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 119 | | _handle: other, [INFO] [stdout] 120 | | value, [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bulut` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bulut` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "73d35374fe0470f9d6278fbc2a33d2281be474df5ce3e93852e28b768f16af22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73d35374fe0470f9d6278fbc2a33d2281be474df5ce3e93852e28b768f16af22", kill_on_drop: false }` [INFO] [stdout] 73d35374fe0470f9d6278fbc2a33d2281be474df5ce3e93852e28b768f16af22