[INFO] fetching crate bullet_stream 0.2.0... [INFO] checking bullet_stream-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bullet_stream 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bullet_stream 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bullet_stream 0.2.0 [INFO] finished tweaking crates.io crate bullet_stream 0.2.0 [INFO] tweaked toml for crates.io crate bullet_stream 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate bullet_stream 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0244d5b401eaa92d95a1a499e5d8ed5439bc7a25ed98ba09af922264a2b38dc [INFO] running `Command { std: "docker" "start" "-a" "d0244d5b401eaa92d95a1a499e5d8ed5439bc7a25ed98ba09af922264a2b38dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0244d5b401eaa92d95a1a499e5d8ed5439bc7a25ed98ba09af922264a2b38dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0244d5b401eaa92d95a1a499e5d8ed5439bc7a25ed98ba09af922264a2b38dc", kill_on_drop: false }` [INFO] [stdout] d0244d5b401eaa92d95a1a499e5d8ed5439bc7a25ed98ba09af922264a2b38dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cb7c49e1e7081fbcaa6363045b920661b28192f2586f2ff6cc306307198bdb1 [INFO] running `Command { std: "docker" "start" "-a" "2cb7c49e1e7081fbcaa6363045b920661b28192f2586f2ff6cc306307198bdb1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking winnow v0.6.9 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking uriparse v0.6.4 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking bullet_stream v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:20 [INFO] [stdout] | [INFO] [stdout] 346 | pub fn new(io: W) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | Self { [INFO] [stdout] 348 | state: state::Header { [INFO] [stdout] | ____________________^ [INFO] [stdout] 349 | | write: ParagraphInspectWrite::new(io), [INFO] [stdout] 350 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 411 | pub fn without_header(self) -> Print> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 414 | state: state::Bullet { [INFO] [stdout] | ____________________^ [INFO] [stdout] 415 | | write: self.state.write, [INFO] [stdout] 416 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:448:20 [INFO] [stdout] | [INFO] [stdout] 443 | pub fn bullet(mut self, s: impl AsRef) -> Print> { [INFO] [stdout] | -------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | state: state::SubBullet { [INFO] [stdout] | ____________________^ [INFO] [stdout] 449 | | write: self.state.write, [INFO] [stdout] 450 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:510:20 [INFO] [stdout] | [INFO] [stdout] 498 | pub fn done(self) -> Print> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | let duration = self.state.started.elapsed(); [INFO] [stdout] 500 | let mut io = match self.state.write.stop() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 501 | Ok(io) => io, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | Err(e) => std::panic::resume_unwind(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | state: state::SubBullet { write: io }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:574:20 [INFO] [stdout] | [INFO] [stdout] 568 | pub fn start_stream(mut self, s: impl AsRef) -> Print> { [INFO] [stdout] | -------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 574 | state: state::Stream { [INFO] [stdout] | ____________________^ [INFO] [stdout] 575 | | started: Instant::now(), [INFO] [stdout] 576 | | write: line_mapped(self.state.write, |mut line| { [INFO] [stdout] 577 | | // Avoid adding trailing whitespace to the line, if there was none already. [INFO] [stdout] ... | [INFO] [stdout] 586 | | }), [INFO] [stdout] 587 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:613:20 [INFO] [stdout] | [INFO] [stdout] 603 | pub fn start_timer(mut self, s: impl AsRef) -> Print> { [INFO] [stdout] | -------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | state: state::Background { [INFO] [stdout] | ____________________^ [INFO] [stdout] 614 | | started: Instant::now(), [INFO] [stdout] 615 | | write: background_printer::print_interval( [INFO] [stdout] 616 | | self.state.write, [INFO] [stdout] ... | [INFO] [stdout] 621 | | ), [INFO] [stdout] 622 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:689:21 [INFO] [stdout] | [INFO] [stdout] 685 | |sender| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 689 | Box::new(Self::format_stream_writer(sender.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:690:21 [INFO] [stdout] | [INFO] [stdout] 685 | |sender| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 690 | Box::new(Self::format_stream_writer(sender.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:724:20 [INFO] [stdout] | [INFO] [stdout] 721 | pub fn done(self) -> Print> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 724 | state: state::Bullet { [INFO] [stdout] | ____________________^ [INFO] [stdout] 725 | | write: self.state.write, [INFO] [stdout] 726 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/background_printer.rs:132:15 [INFO] [stdout] | [INFO] [stdout] 129 | pub(crate) fn stop(mut self) -> std::thread::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | match self.join_handle.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 200 | pub(crate) fn mpsc_stream_to_output(mut stream: S, mut output: L) -> F [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | thread::scope(|scope| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 207 | | let (send, recv) = mpsc::channel::>(); [INFO] [stdout] 208 | | // The receiver is moved into the background thread where it waits on input from the senders. [INFO] [stdout] 209 | | scope.spawn(move || { [INFO] [stdout] ... | [INFO] [stdout] 224 | | out [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:56:20 [INFO] [stdout] | [INFO] [stdout] 51 | w: W, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | marker_byte: u8, [INFO] [stdout] 53 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | inner: Some(w), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 51 | w: W, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | marker_byte: u8, [INFO] [stdout] 53 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | mapping_fn: Arc::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bullet_stream` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2cb7c49e1e7081fbcaa6363045b920661b28192f2586f2ff6cc306307198bdb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cb7c49e1e7081fbcaa6363045b920661b28192f2586f2ff6cc306307198bdb1", kill_on_drop: false }` [INFO] [stdout] 2cb7c49e1e7081fbcaa6363045b920661b28192f2586f2ff6cc306307198bdb1