[INFO] fetching crate buildkite-jobify 0.7.0... [INFO] checking buildkite-jobify-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate buildkite-jobify 0.7.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate buildkite-jobify 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate buildkite-jobify 0.7.0 [INFO] finished tweaking crates.io crate buildkite-jobify 0.7.0 [INFO] tweaked toml for crates.io crate buildkite-jobify 0.7.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate buildkite-jobify 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de347bb136a05d3187023e6edb3cd8ebdcb6fc79d31791e44dc28a2b7c182c3b [INFO] running `Command { std: "docker" "start" "-a" "de347bb136a05d3187023e6edb3cd8ebdcb6fc79d31791e44dc28a2b7c182c3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de347bb136a05d3187023e6edb3cd8ebdcb6fc79d31791e44dc28a2b7c182c3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de347bb136a05d3187023e6edb3cd8ebdcb6fc79d31791e44dc28a2b7c182c3b", kill_on_drop: false }` [INFO] [stdout] de347bb136a05d3187023e6edb3cd8ebdcb6fc79d31791e44dc28a2b7c182c3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b1b4ad8d1a1464d4d86ea2a84dcdf1181810fcd96cf9396d5a8b2cbb59e5e4b [INFO] running `Command { std: "docker" "start" "-a" "7b1b4ad8d1a1464d4d86ea2a84dcdf1181810fcd96cf9396d5a8b2cbb59e5e4b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling tokio v1.21.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling unreachable v1.0.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Compiling ascii v0.9.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling openssl-src v111.22.0+1.1.1q [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling either v1.8.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.6 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Compiling combine v3.8.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling k8s-openapi v0.15.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Compiling camino v1.1.1 [INFO] [stderr] Checking xdg v2.4.1 [INFO] [stderr] Checking ordered-float v2.10.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking xattr v0.2.3 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Checking uuid v1.1.2 [INFO] [stderr] Checking app_dirs2 v2.5.3 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking lru_time_cache v0.11.11 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling graphql-parser v0.4.0 [INFO] [stderr] Checking clap v3.2.21 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stderr] Checking h2 v0.3.14 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.13 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking tame-oauth v0.7.0 [INFO] [stderr] Checking tracing-subscriber v0.3.15 [INFO] [stderr] Compiling graphql-introspection-query v0.2.0 [INFO] [stderr] Compiling graphql_client_codegen v0.11.0 [INFO] [stderr] Compiling graphql_query_derive v0.11.0 [INFO] [stderr] Checking graphql_client v0.11.0 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.11 [INFO] [stderr] Checking buildkite-jobify v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `current_context` is never read [INFO] [stdout] --> src/k8s/config/kube_config.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct KubeConfigLoader { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 11 | pub current_context: Context, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KubeConfigLoader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobifier.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 36 | let kubeconfig = match config::load_kube_config() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(cfg) => cfg, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let kbctl = APIClient::new(kubeconfig); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let spawner = async move { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { sender: tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobifier.rs:621:23 [INFO] [stdout] | [INFO] [stdout] 616 | let client = kbctl.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 621 | match cleanup_jobs(client, ns, pipeline).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/client.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(configuration: Configuration) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | APIClient { [INFO] [stdout] 40 | configuration: Arc::new(configuration), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 37 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let (parts, body) = request.into_parts(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let req_builder = match parts.method { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | _other => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let req = req_builder.headers(parts.headers).body(body); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(req.send().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | Ok(AuthProvider::Oauth2(Arc::new(access))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:123:48 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|(k, v)| (k.clone(), v.clone())), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:123:59 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|(k, v)| (k.clone(), v.clone())), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 148 | let mut client_builder = Client::builder(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let auth_provider = match ( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let hv = header::HeaderValue::from_str(&format!("Basic {}", encoded))?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | _ => anyhow::bail!("unable to find an auth-provider"), [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Ok(Configuration::new( [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | loader.cluster.server, [INFO] [stdout] 199 | | client_builder.build()?, [INFO] [stdout] 200 | | auth_provider, [INFO] [stdout] 201 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 215 | let ca = incluster::load_cert()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let req_ca = Certificate::from_der(&ca.to_der()?)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let client_builder = Client::builder() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Configuration::new(server, client_builder.build()?, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/incluster.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | X509::from_pem(&ca).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 54 | let x509 = X509::from_pem(client_cert)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let pkey = PKey::private_key_from_pem(client_key)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | / Pkcs12::builder() [INFO] [stdout] 58 | | .build(password, "kubeconfig", &pkey, &x509) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 63 | let ca = self.cluster.load_certificate_authority()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Some(ca.and_then(|ca| X509::from_pem(&ca).map_err(Error::from))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | Some(ca.and_then(|ca| X509::from_pem(&ca).map_err(Error::from))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(monitor: Monitor, jobifier: Jobifier) -> Self { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | waiter: mpsc::unbounded(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `buildkite-jobify` (lib) due to 15 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `current_context` is never read [INFO] [stdout] --> src/k8s/config/kube_config.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct KubeConfigLoader { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 11 | pub current_context: Context, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KubeConfigLoader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobifier.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 36 | let kubeconfig = match config::load_kube_config() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(cfg) => cfg, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let kbctl = APIClient::new(kubeconfig); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let spawner = async move { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(Self { sender: tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jobifier.rs:621:23 [INFO] [stdout] | [INFO] [stdout] 616 | let client = kbctl.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 621 | match cleanup_jobs(client, ns, pipeline).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/client.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(configuration: Configuration) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | APIClient { [INFO] [stdout] 40 | configuration: Arc::new(configuration), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 37 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let (parts, body) = request.into_parts(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let req_builder = match parts.method { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | _other => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let req = req_builder.headers(parts.headers).body(body); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | Ok(req.send().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | Ok(AuthProvider::Oauth2(Arc::new(access))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:123:48 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|(k, v)| (k.clone(), v.clone())), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:123:59 [INFO] [stdout] | [INFO] [stdout] 123 | ... .map(|(k, v)| (k.clone(), v.clone())), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 148 | let mut client_builder = Client::builder(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let auth_provider = match ( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let hv = header::HeaderValue::from_str(&format!("Basic {}", encoded))?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | _ => anyhow::bail!("unable to find an auth-provider"), [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Ok(Configuration::new( [INFO] [stdout] | ________^ [INFO] [stdout] 198 | | loader.cluster.server, [INFO] [stdout] 199 | | client_builder.build()?, [INFO] [stdout] 200 | | auth_provider, [INFO] [stdout] 201 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 215 | let ca = incluster::load_cert()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let req_ca = Certificate::from_der(&ca.to_der()?)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let mut headers = header::HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | let client_builder = Client::builder() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Ok(Configuration::new(server, client_builder.build()?, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/incluster.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | X509::from_pem(&ca).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 54 | let x509 = X509::from_pem(client_cert)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let pkey = PKey::private_key_from_pem(client_key)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | / Pkcs12::builder() [INFO] [stdout] 58 | | .build(password, "kubeconfig", &pkey, &x509) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 63 | let ca = self.cluster.load_certificate_authority()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Some(ca.and_then(|ca| X509::from_pem(&ca).map_err(Error::from))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/k8s/config/kube_config.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | Some(ca.and_then(|ca| X509::from_pem(&ca).map_err(Error::from))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(monitor: Monitor, jobifier: Jobifier) -> Self { [INFO] [stdout] | ---------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | waiter: mpsc::unbounded(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `buildkite-jobify` (lib test) due to 15 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7b1b4ad8d1a1464d4d86ea2a84dcdf1181810fcd96cf9396d5a8b2cbb59e5e4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b1b4ad8d1a1464d4d86ea2a84dcdf1181810fcd96cf9396d5a8b2cbb59e5e4b", kill_on_drop: false }` [INFO] [stdout] 7b1b4ad8d1a1464d4d86ea2a84dcdf1181810fcd96cf9396d5a8b2cbb59e5e4b