[INFO] fetching crate btleplug 0.11.5... [INFO] checking btleplug-0.11.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate btleplug 0.11.5 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate btleplug 0.11.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate btleplug 0.11.5 [INFO] finished tweaking crates.io crate btleplug 0.11.5 [INFO] tweaked toml for crates.io crate btleplug 0.11.5 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate btleplug 0.11.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f07d80d393a508dcbb333fa467aa34c7b4468db3c303445571b599b8737f21b [INFO] running `Command { std: "docker" "start" "-a" "8f07d80d393a508dcbb333fa467aa34c7b4468db3c303445571b599b8737f21b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f07d80d393a508dcbb333fa467aa34c7b4468db3c303445571b599b8737f21b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f07d80d393a508dcbb333fa467aa34c7b4468db3c303445571b599b8737f21b", kill_on_drop: false }` [INFO] [stdout] 8f07d80d393a508dcbb333fa467aa34c7b4468db3c303445571b599b8737f21b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e55891c6322232b9ac1ff15161b885d98eee7b8a8c9d8807d7d9739b60b3fd0 [INFO] running `Command { std: "docker" "start" "-a" "8e55891c6322232b9ac1ff15161b885d98eee7b8a8c9d8807d7d9739b60b3fd0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling thiserror v1.0.53 [INFO] [stderr] Compiling libdbus-sys v0.2.4 [INFO] [stderr] Compiling rustix v0.38.2 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling async-trait v0.1.76 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.53 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking bluez-generated v0.3.0 [INFO] [stderr] Checking dbus-tokio v0.7.6 [INFO] [stderr] Checking bluez-async v0.7.2 [INFO] [stderr] Checking btleplug v0.11.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:54:59 [INFO] [stdout] | [INFO] [stdout] 51 | let session = self.session.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .filter_map(move |event| central_event(event, session.clone(), adapter_id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:83:43 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|device| Peripheral::new(self.session.clone(), device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 111 | fn from(error: BluetoothError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Error::Other(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/manager.rs:27:41 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|adapter| Adapter::new(self.session.clone(), adapter.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn new(session: BluetoothSession, device: DeviceInfo) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | services: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 100 | let services = self.services.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | / get_characteristic( [INFO] [stdout] 102 | | &services, [INFO] [stdout] 103 | | &characteristic.service_uuid, [INFO] [stdout] 104 | | &characteristic.uuid, [INFO] [stdout] 105 | | ) [INFO] [stdout] 106 | | .map(|c| &c.info) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 111 | let services = self.services.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / characteristic [INFO] [stdout] 118 | | .descriptors [INFO] [stdout] 119 | | .get(&descriptor.uuid) [INFO] [stdout] 120 | | .ok_or_else(|| { [INFO] [stdout] 121 | | Error::Other(format!("Descriptor with UUID {} not found.", descriptor.uuid).into()) [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:253:57 [INFO] [stdout] | [INFO] [stdout] 251 | let services = self.services.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Ok(Box::pin(events.filter_map(move |event| { [INFO] [stdout] 253 | ready(value_notification(event, &device_id, services.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `btleplug` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:54:59 [INFO] [stdout] | [INFO] [stdout] 51 | let session = self.session.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .filter_map(move |event| central_event(event, session.clone(), adapter_id.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:83:43 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|device| Peripheral::new(self.session.clone(), device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/adapter.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 111 | fn from(error: BluetoothError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Error::Other(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/manager.rs:27:41 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|adapter| Adapter::new(self.session.clone(), adapter.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) fn new(session: BluetoothSession, device: DeviceInfo) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | services: Arc::new(Mutex::new(HashMap::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 100 | let services = self.services.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | / get_characteristic( [INFO] [stdout] 102 | | &services, [INFO] [stdout] 103 | | &characteristic.service_uuid, [INFO] [stdout] 104 | | &characteristic.uuid, [INFO] [stdout] 105 | | ) [INFO] [stdout] 106 | | .map(|c| &c.info) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 111 | let services = self.services.lock().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / characteristic [INFO] [stdout] 118 | | .descriptors [INFO] [stdout] 119 | | .get(&descriptor.uuid) [INFO] [stdout] 120 | | .ok_or_else(|| { [INFO] [stdout] 121 | | Error::Other(format!("Descriptor with UUID {} not found.", descriptor.uuid).into()) [INFO] [stdout] 122 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluez/peripheral.rs:253:57 [INFO] [stdout] | [INFO] [stdout] 251 | let services = self.services.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Ok(Box::pin(events.filter_map(move |event| { [INFO] [stdout] 253 | ready(value_notification(event, &device_id, services.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `btleplug` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "8e55891c6322232b9ac1ff15161b885d98eee7b8a8c9d8807d7d9739b60b3fd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e55891c6322232b9ac1ff15161b885d98eee7b8a8c9d8807d7d9739b60b3fd0", kill_on_drop: false }` [INFO] [stdout] 8e55891c6322232b9ac1ff15161b885d98eee7b8a8c9d8807d7d9739b60b3fd0