[INFO] crate bsalib 0.1.0 is already in cache [INFO] checking bsalib-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bsalib 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bsalib 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bsalib 0.1.0 [INFO] finished tweaking crates.io crate bsalib 0.1.0 [INFO] tweaked toml for crates.io crate bsalib 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding generics v0.3.2 (latest: v0.5.3) [INFO] [stderr] Adding libflate v1.4.0 (latest: v2.1.0) [INFO] [stderr] Adding libflate_lz77 v1.2.0 (latest: v2.1.0) [INFO] [stderr] Adding macro-attr-2018 v1.1.2 (latest: v3.0.0) [INFO] [stderr] Adding newtype-derive-2018 v0.0.3 (latest: v0.2.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04a6ebc05ff0ee842a510be14d0b08016856885f084d2bb7e7e037f846947983 [INFO] running `Command { std: "docker" "start" "-a" "04a6ebc05ff0ee842a510be14d0b08016856885f084d2bb7e7e037f846947983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04a6ebc05ff0ee842a510be14d0b08016856885f084d2bb7e7e037f846947983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04a6ebc05ff0ee842a510be14d0b08016856885f084d2bb7e7e037f846947983", kill_on_drop: false }` [INFO] [stdout] 04a6ebc05ff0ee842a510be14d0b08016856885f084d2bb7e7e037f846947983 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ceeedc0cf02d8a752c0e2ebcc8ad6f9e1238c568ac484a8899f03496932ea1a [INFO] running `Command { std: "docker" "start" "-a" "1ceeedc0cf02d8a752c0e2ebcc8ad6f9e1238c568ac484a8899f03496932ea1a", kill_on_drop: false }` [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking generics v0.3.2 [INFO] [stderr] Checking macro-attr-2018 v1.1.2 [INFO] [stderr] Compiling lz4-sys v1.10.0 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking newtype-derive-2018 v0.0.3 [INFO] [stderr] Checking libflate_lz77 v1.2.0 [INFO] [stderr] Checking libflate v1.4.0 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking lz4 v1.26.0 [INFO] [stderr] Checking bsalib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `arbitrary_enum_discriminant` has been stable since 1.66.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:73 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(associated_type_defaults, wrapping_int_impl, specialization, arbitrary_enum_discriminant)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `arbitrary_enum_discriminant` has been stable since 1.66.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:73 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(associated_type_defaults, wrapping_int_impl, specialization, arbitrary_enum_discriminant)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:530:25 [INFO] [stdout] | [INFO] [stdout] 530 | .map(|(dir, mut pdr)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:586:24 [INFO] [stdout] | [INFO] [stdout] 586 | for (file, mut fr) in dir.files.iter().zip(&mut pfcr.data.files) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:530:25 [INFO] [stdout] | [INFO] [stdout] 530 | .map(|(dir, mut pdr)| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/v10x.rs:586:24 [INFO] [stdout] | [INFO] [stdout] 586 | for (file, mut fr) in dir.files.iter().zip(&mut pfcr.data.files) { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 129 | for a in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 | while let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn size_many(vals: I) -> usize [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | where I::Item: Writable { [INFO] [stdout] 138 | vals.into_iter().map(|val| val.size()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(data: A, mut out: W) -> Result { [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Ok(Self { position, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:167:19 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new_empty(out: W) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | where A: Default { [INFO] [stdout] 167 | Self::new(A::default(), out) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | FileRecord::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 64 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ZString::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 78 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | u64::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v10x.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 160 | fn read_here(mut reader: R, _: &()) -> Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | bin::read_struct::(&mut reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v10x.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 205 | pub(crate) fn open(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let header = V10XHeader::::read0(&mut reader)?; [INFO] [stdout] 207 | Ok(V10XReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | reader, [INFO] [stdout] 209 | | header, [INFO] [stdout] 210 | | phantom_t: PhantomData, [INFO] [stdout] 211 | | phantom_rdr: PhantomData, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bsalib` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/bin.rs:129:18 [INFO] [stdout] | [INFO] [stdout] 129 | for a in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 129 | while let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(a) = self { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn size_many(vals: I) -> usize [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | where I::Item: Writable { [INFO] [stdout] 138 | vals.into_iter().map(|val| val.size()).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(data: A, mut out: W) -> Result { [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Ok(Self { position, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin.rs:167:19 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new_empty(out: W) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | where A: Default { [INFO] [stdout] 167 | Self::new(A::default(), out) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | FileRecord::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 64 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ZString::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v001.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 78 | fn read_here(reader: R, header: &Header) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | u64::read_many0(reader, header.num_files as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v10x.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 160 | fn read_here(mut reader: R, _: &()) -> Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | bin::read_struct::(&mut reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v10x.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 205 | pub(crate) fn open(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let header = V10XHeader::::read0(&mut reader)?; [INFO] [stdout] 207 | Ok(V10XReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | reader, [INFO] [stdout] 209 | | header, [INFO] [stdout] 210 | | phantom_t: PhantomData, [INFO] [stdout] 211 | | phantom_rdr: PhantomData, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bsalib` (lib test) due to 9 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1ceeedc0cf02d8a752c0e2ebcc8ad6f9e1238c568ac484a8899f03496932ea1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ceeedc0cf02d8a752c0e2ebcc8ad6f9e1238c568ac484a8899f03496932ea1a", kill_on_drop: false }` [INFO] [stdout] 1ceeedc0cf02d8a752c0e2ebcc8ad6f9e1238c568ac484a8899f03496932ea1a