[INFO] fetching crate brio 0.2.0... [INFO] checking brio-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate brio 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate brio 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate brio 0.2.0 [INFO] finished tweaking crates.io crate brio 0.2.0 [INFO] tweaked toml for crates.io crate brio 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate brio 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ec06ef7448af045de72eabba7170dadfe1d389f51feefee19074317d21ee021 [INFO] running `Command { std: "docker" "start" "-a" "1ec06ef7448af045de72eabba7170dadfe1d389f51feefee19074317d21ee021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ec06ef7448af045de72eabba7170dadfe1d389f51feefee19074317d21ee021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ec06ef7448af045de72eabba7170dadfe1d389f51feefee19074317d21ee021", kill_on_drop: false }` [INFO] [stdout] 1ec06ef7448af045de72eabba7170dadfe1d389f51feefee19074317d21ee021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8b0fe9f0cecb90807f2ae83e1200a4f88ccb0888a08044a6e89ca600dabec06 [INFO] running `Command { std: "docker" "start" "-a" "a8b0fe9f0cecb90807f2ae83e1200a4f88ccb0888a08044a6e89ca600dabec06", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling memchr v2.3.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http v0.2.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking async-task v1.3.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking async-std v1.5.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling tokio-macros v0.2.4 [INFO] [stderr] Compiling pin-project-internal v0.4.8 [INFO] [stderr] Checking tokio v0.2.11 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Checking pin-project v0.4.8 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking h2 v0.2.1 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking brio v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `or_patterns` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(or_patterns)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `exclusive_range_pattern` has been stable since 1.80.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(exclusive_range_pattern)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `extend` is never read [INFO] [stdout] --> src/body.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct ChunkedBody { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | extend: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `config` is never read [INFO] [stdout] --> src/router.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Router { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub(crate) config: Routes, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn run(self, port: u32) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let router = Arc::new(self.router); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | task::block_on(server::accept_loop("127.0.0.1", port, router)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:18 [INFO] [stdout] | [INFO] [stdout] 115 | fn handle(&self, ctx: Ctx) -> BoxFuture { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 119 | | let path = format!("{}{}", src, filepath); [INFO] [stdout] 120 | | match fs::canonicalize(path).await { [INFO] [stdout] 121 | | Ok(path) => match async_std::fs::File::open(path).await { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] 142 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:117:27 [INFO] [stdout] | [INFO] [stdout] 117 | let src = self.src.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 65 | fn run<'a>(&'a self, req: Request) -> BoxFuture<'a, Response> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let fut = (self)(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Box::pin(async move { fut.await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 66 | let fut = (self)(req); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Box::pin(async move { fut.await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 46 | fn spawn_and_log_error(fut: F) -> task::JoinHandle<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | task::spawn(async move { [INFO] [stdout] | _________________^ [INFO] [stdout] 51 | | if let Err(e) = fut.await { [INFO] [stdout] 52 | | error!("{}", e) [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `brio` (lib) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a8b0fe9f0cecb90807f2ae83e1200a4f88ccb0888a08044a6e89ca600dabec06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8b0fe9f0cecb90807f2ae83e1200a4f88ccb0888a08044a6e89ca600dabec06", kill_on_drop: false }` [INFO] [stdout] a8b0fe9f0cecb90807f2ae83e1200a4f88ccb0888a08044a6e89ca600dabec06