[INFO] fetching crate brightness-ctl 0.1.2... [INFO] checking brightness-ctl-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate brightness-ctl 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate brightness-ctl 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate brightness-ctl 0.1.2 [INFO] finished tweaking crates.io crate brightness-ctl 0.1.2 [INFO] tweaked toml for crates.io crate brightness-ctl 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate brightness-ctl 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbf104a2f9509726fa0022ee380f7cb322c52c26835325bafc05b9c3da0db8f9 [INFO] running `Command { std: "docker" "start" "-a" "cbf104a2f9509726fa0022ee380f7cb322c52c26835325bafc05b9c3da0db8f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbf104a2f9509726fa0022ee380f7cb322c52c26835325bafc05b9c3da0db8f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf104a2f9509726fa0022ee380f7cb322c52c26835325bafc05b9c3da0db8f9", kill_on_drop: false }` [INFO] [stdout] cbf104a2f9509726fa0022ee380f7cb322c52c26835325bafc05b9c3da0db8f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6913a35aeb6cc0573505ffc2a8f10aab716443dbc2460f8e9b642339562e7d6b [INFO] running `Command { std: "docker" "start" "-a" "6913a35aeb6cc0573505ffc2a8f10aab716443dbc2460f8e9b642339562e7d6b", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking notify-rust v4.10.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.2 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking brightness-ctl v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:159:6 [INFO] [stdout] | [INFO] [stdout] 144 | fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | max, [INFO] [stdout] 161 | | value, [INFO] [stdout] 162 | | file, [INFO] [stdout] 163 | | path: path_brightness, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:187:6 [INFO] [stdout] | [INFO] [stdout] 185 | let dir = std::fs::read_dir(path) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | .map_err(|e| log::error!("Failed to open directory {path}: {e}"))?; [INFO] [stdout] 187 | Ok(dir.filter_map(move |entry| { [INFO] [stdout] | ____________^ [INFO] [stdout] 188 | | let entry = entry [INFO] [stdout] 189 | | .map_err(|e| log::error!("Failed to read entry of {path}: {e}")) [INFO] [stdout] 190 | | .ok()?; [INFO] [stdout] 191 | | Some(entry.path()) [INFO] [stdout] 192 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:159:6 [INFO] [stdout] | [INFO] [stdout] 144 | fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | max, [INFO] [stdout] 161 | | value, [INFO] [stdout] 162 | | file, [INFO] [stdout] 163 | | path: path_brightness, [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:187:6 [INFO] [stdout] | [INFO] [stdout] 185 | let dir = std::fs::read_dir(path) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | .map_err(|e| log::error!("Failed to open directory {path}: {e}"))?; [INFO] [stdout] 187 | Ok(dir.filter_map(move |entry| { [INFO] [stdout] | ____________^ [INFO] [stdout] 188 | | let entry = entry [INFO] [stdout] 189 | | .map_err(|e| log::error!("Failed to read entry of {path}: {e}")) [INFO] [stdout] 190 | | .ok()?; [INFO] [stdout] 191 | | Some(entry.path()) [INFO] [stdout] 192 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `brightness-ctl` (bin "brightness-ctl") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `brightness-ctl` (bin "brightness-ctl" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6913a35aeb6cc0573505ffc2a8f10aab716443dbc2460f8e9b642339562e7d6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6913a35aeb6cc0573505ffc2a8f10aab716443dbc2460f8e9b642339562e7d6b", kill_on_drop: false }` [INFO] [stdout] 6913a35aeb6cc0573505ffc2a8f10aab716443dbc2460f8e9b642339562e7d6b