[INFO] fetching crate branchy 0.2.1... [INFO] checking branchy-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate branchy 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate branchy 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate branchy 0.2.1 [INFO] finished tweaking crates.io crate branchy 0.2.1 [INFO] tweaked toml for crates.io crate branchy 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a0e835d0031efb87310a1ee1b9413a7a444a79ec57b279403c78d99eb8daca9 [INFO] running `Command { std: "docker" "start" "-a" "0a0e835d0031efb87310a1ee1b9413a7a444a79ec57b279403c78d99eb8daca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a0e835d0031efb87310a1ee1b9413a7a444a79ec57b279403c78d99eb8daca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a0e835d0031efb87310a1ee1b9413a7a444a79ec57b279403c78d99eb8daca9", kill_on_drop: false }` [INFO] [stdout] 0a0e835d0031efb87310a1ee1b9413a7a444a79ec57b279403c78d99eb8daca9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19a2670c66f1d8f9d07803b7d2141c9f64399d185f80acceca2b558dbbb936f5 [INFO] running `Command { std: "docker" "start" "-a" "19a2670c66f1d8f9d07803b7d2141c9f64399d185f80acceca2b558dbbb936f5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking branchy v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn from(rules: Rs) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 127 | | rules: rules.into_iter().collect(), [INFO] [stdout] 128 | | rule_selector: UniformRandomRuleSelector, [INFO] [stdout] 129 | | logger: NullExpansionLogger, [INFO] [stdout] 130 | | max_iterations: DEFAULT_MAX_ITERATIONS [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn with_rule_selector(self, rule_selector: NewRS) -> ExpanderBuilder [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 181 | | rules: self.config.rules, [INFO] [stdout] 182 | | rule_selector, [INFO] [stdout] 183 | | logger: self.config.logger, [INFO] [stdout] 184 | | max_iterations: self.config.max_iterations [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn with_logger(self, logger: NewEL) -> ExpanderBuilder [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 194 | | rules: self.config.rules, [INFO] [stdout] 195 | | rule_selector: self.config.rule_selector, [INFO] [stdout] 196 | | logger, [INFO] [stdout] 197 | | max_iterations: self.config.max_iterations [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn with_max_iterations(self, max_iterations: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | Self{ [INFO] [stdout] 204 | config: ExpanderConfig { [INFO] [stdout] | _____________________^ [INFO] [stdout] 205 | | max_iterations, [INFO] [stdout] 206 | | ..self.config [INFO] [stdout] 207 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 235 | mut input: Vec>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Err(Error::max_iterations_reached(input, max_iterations)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:251:40 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|(idx, symbol)| (idx, symbol.clone().unwrap_nonterm())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/error.rs:108:26 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn nonterm_expansion_failed(state: Vec>, expanded_nonterm_value: Nt) -> Self { [INFO] [stdout] | ------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Self::new(state, ErrorKind::NontermExpansionFailed(expanded_nonterm_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/error.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn max_iterations_reached(state: Vec>, iterations: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Self::new(state, ErrorKind::MaxIterationsReached(iterations)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `branchy` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn from(rules: Rs) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 127 | | rules: rules.into_iter().collect(), [INFO] [stdout] 128 | | rule_selector: UniformRandomRuleSelector, [INFO] [stdout] 129 | | logger: NullExpansionLogger, [INFO] [stdout] 130 | | max_iterations: DEFAULT_MAX_ITERATIONS [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:180:21 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn with_rule_selector(self, rule_selector: NewRS) -> ExpanderBuilder [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 181 | | rules: self.config.rules, [INFO] [stdout] 182 | | rule_selector, [INFO] [stdout] 183 | | logger: self.config.logger, [INFO] [stdout] 184 | | max_iterations: self.config.max_iterations [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:193:21 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn with_logger(self, logger: NewEL) -> ExpanderBuilder [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | config: ExpanderConfig{ [INFO] [stdout] | _____________________^ [INFO] [stdout] 194 | | rules: self.config.rules, [INFO] [stdout] 195 | | rule_selector: self.config.rule_selector, [INFO] [stdout] 196 | | logger, [INFO] [stdout] 197 | | max_iterations: self.config.max_iterations [INFO] [stdout] 198 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn with_max_iterations(self, max_iterations: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | Self{ [INFO] [stdout] 204 | config: ExpanderConfig { [INFO] [stdout] | _____________________^ [INFO] [stdout] 205 | | max_iterations, [INFO] [stdout] 206 | | ..self.config [INFO] [stdout] 207 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 235 | mut input: Vec>, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Err(Error::max_iterations_reached(input, max_iterations)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion.rs:251:40 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|(idx, symbol)| (idx, symbol.clone().unwrap_nonterm())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/error.rs:108:26 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn nonterm_expansion_failed(state: Vec>, expanded_nonterm_value: Nt) -> Self { [INFO] [stdout] | ------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Self::new(state, ErrorKind::NontermExpansionFailed(expanded_nonterm_value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/error.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn max_iterations_reached(state: Vec>, iterations: usize) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Self::new(state, ErrorKind::MaxIterationsReached(iterations)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `branchy` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "19a2670c66f1d8f9d07803b7d2141c9f64399d185f80acceca2b558dbbb936f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19a2670c66f1d8f9d07803b7d2141c9f64399d185f80acceca2b558dbbb936f5", kill_on_drop: false }` [INFO] [stdout] 19a2670c66f1d8f9d07803b7d2141c9f64399d185f80acceca2b558dbbb936f5