[INFO] fetching crate br-mysql 0.0.4... [INFO] checking br-mysql-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate br-mysql 0.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate br-mysql 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate br-mysql 0.0.4 [INFO] finished tweaking crates.io crate br-mysql 0.0.4 [INFO] tweaked toml for crates.io crate br-mysql 0.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate br-mysql 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6850b73e87999579666090c2610160ba30ee3c17c7b23b09bd81c66e85d3583 [INFO] running `Command { std: "docker" "start" "-a" "a6850b73e87999579666090c2610160ba30ee3c17c7b23b09bd81c66e85d3583", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6850b73e87999579666090c2610160ba30ee3c17c7b23b09bd81c66e85d3583", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6850b73e87999579666090c2610160ba30ee3c17c7b23b09bd81c66e85d3583", kill_on_drop: false }` [INFO] [stdout] a6850b73e87999579666090c2610160ba30ee3c17c7b23b09bd81c66e85d3583 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 405d5e99afa8cd1fc4c65b5405c9d6929ddd2a23d725af8f0e37b0a37dd0c630 [INFO] running `Command { std: "docker" "start" "-a" "405d5e99afa8cd1fc4c65b5405c9d6929ddd2a23d725af8f0e37b0a37dd0c630", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking br-mysql v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/packet.rs:187:25 [INFO] [stdout] | [INFO] [stdout] 187 | let index = buf.remove(0); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/packet.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | let index = buf.remove(0); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/packet.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | let index = buf.remove(0); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:256:17 [INFO] [stdout] | [INFO] [stdout] 256 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/packet.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | let mut length = data.remove(0) as usize; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/comm.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 174 | pub enum CapabilityFlags { [INFO] [stdout] | --------------- variants in this enum [INFO] [stdout] 175 | ClientLongPassword, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 176 | ClientFoundRows, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 177 | ClientLongFlag, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 178 | ClientConnectWithDb, [INFO] [stdout] 179 | ClientNoSchema, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 180 | ClientCompress, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 181 | ClientOdbc, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 182 | ClientLocalFiles, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 183 | [INFO] [stdout] 184 | ClientIgnoreSpace, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 185 | ClientProtocol41, [INFO] [stdout] 186 | ClientInteractive, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 187 | ClientSsl, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 188 | ClientIgnoreSigpipe, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 189 | [INFO] [stdout] 190 | ClientTransactions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 191 | ClientReserved, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 192 | ClientSecureConnection, [INFO] [stdout] 193 | ClientMultiStatements, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 194 | [INFO] [stdout] 195 | ClientMultiResults, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 196 | ClientPsMultiResults, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 201 | ClientCanHandleExpiredPasswords, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 202 | ClientSessionTrack, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 203 | ClientDeprecateEof, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 204 | ClientOptionalResultsetMetadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | ClientQueryAttributes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 208 | MultiFactorAuthentication, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 209 | [INFO] [stdout] 210 | ClientProgressObsolete, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 211 | ClientSslVerifyServerCert, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 212 | ClientRememberOptions, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 213 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CapabilityFlags` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CLIENT_QUERY_ATTRIBUTES` is never used [INFO] [stdout] --> src/comm.rs:249:7 [INFO] [stdout] | [INFO] [stdout] 249 | const CLIENT_QUERY_ATTRIBUTES: u32 = 1 << 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/comm.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 251 | impl CapabilityFlags { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 273 | pub fn from(flags: u32) -> CapabilityFlags { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `COM_CHANGE_USER`, `COM_STMT_FETCH`, and `COM_STMT_FETCHS` are never used [INFO] [stdout] --> src/comm.rs:393:15 [INFO] [stdout] | [INFO] [stdout] 385 | impl Command { [INFO] [stdout] | ------------ associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 393 | pub const COM_CHANGE_USER: u8 = 0x11; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 398 | pub const COM_STMT_FETCH: u8 = 0x19; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 399 | /// 返回的最大行数 [INFO] [stdout] 400 | pub const COM_STMT_FETCHS: u8 = 0x22; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `UTF8_MB4_GENERAL_CI` is never used [INFO] [stdout] --> src/character_set.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 6 | impl Charset { [INFO] [stdout] | ------------ associated constant in this implementation [INFO] [stdout] 7 | pub const NONE: u8 = 0; [INFO] [stdout] 8 | pub const UTF8_MB4_GENERAL_CI: u8 = 45; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `last_insert_id`, `database`, `table`, and `character_set` are never read [INFO] [stdout] --> src/response.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Response { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | last_insert_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | database: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 23 | table: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | character_set: u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Response` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(config: JsonValue) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self { config, pool: HashMap::new() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 103 | let mut that = Response::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(that.row.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:479:12 [INFO] [stdout] | [INFO] [stdout] 405 | pub fn rows(mut data: Vec>, response: Response) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | let mut that = response; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 479 | Ok(that.row.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `br-mysql` (lib) due to 4 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "405d5e99afa8cd1fc4c65b5405c9d6929ddd2a23d725af8f0e37b0a37dd0c630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "405d5e99afa8cd1fc4c65b5405c9d6929ddd2a23d725af8f0e37b0a37dd0c630", kill_on_drop: false }` [INFO] [stdout] 405d5e99afa8cd1fc4c65b5405c9d6929ddd2a23d725af8f0e37b0a37dd0c630