[INFO] fetching crate br-http 0.4.9... [INFO] checking br-http-0.4.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate br-http 0.4.9 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate br-http 0.4.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate br-http 0.4.9 [INFO] finished tweaking crates.io crate br-http 0.4.9 [INFO] tweaked toml for crates.io crate br-http 0.4.9 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate br-http 0.4.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bca114dabafe0472e81be75306fc5a6def44f21a8a7bd49718fe28c93fd236a9 [INFO] running `Command { std: "docker" "start" "-a" "bca114dabafe0472e81be75306fc5a6def44f21a8a7bd49718fe28c93fd236a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bca114dabafe0472e81be75306fc5a6def44f21a8a7bd49718fe28c93fd236a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bca114dabafe0472e81be75306fc5a6def44f21a8a7bd49718fe28c93fd236a9", kill_on_drop: false }` [INFO] [stdout] bca114dabafe0472e81be75306fc5a6def44f21a8a7bd49718fe28c93fd236a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37d41c07b31c41fdab0420ded62eb6c30d43d3f06de0090ace69f4fc1e55e03c [INFO] running `Command { std: "docker" "start" "-a" "37d41c07b31c41fdab0420ded62eb6c30d43d3f06de0090ace69f4fc1e55e03c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking rand v0.9.0-alpha.2 [INFO] [stderr] Checking cookie_store v0.21.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking br-http v0.4.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:133:62 [INFO] [stdout] | [INFO] [stdout] 133 | form = Some(form.take().unwrap().text(key.clone(), value.to_string().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:136:62 [INFO] [stdout] | [INFO] [stdout] 136 | form = Some(form.take().unwrap().file(key.clone(), path.to_string().clone()).unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 182 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut request = match self.method { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | match request.send() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:133:62 [INFO] [stdout] | [INFO] [stdout] 133 | form = Some(form.take().unwrap().text(key.clone(), value.to_string().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:136:62 [INFO] [stdout] | [INFO] [stdout] 136 | form = Some(form.take().unwrap().file(key.clone(), path.to_string().clone()).unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 182 | let client = reqwest::blocking::Client::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let mut request = match self.method { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | match request.send() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `br-http` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `br-http` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "37d41c07b31c41fdab0420ded62eb6c30d43d3f06de0090ace69f4fc1e55e03c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37d41c07b31c41fdab0420ded62eb6c30d43d3f06de0090ace69f4fc1e55e03c", kill_on_drop: false }` [INFO] [stdout] 37d41c07b31c41fdab0420ded62eb6c30d43d3f06de0090ace69f4fc1e55e03c