[INFO] fetching crate bp-wallet 0.11.0-beta.7... [INFO] checking bp-wallet-0.11.0-beta.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bp-wallet 0.11.0-beta.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate bp-wallet 0.11.0-beta.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate bp-wallet 0.11.0-beta.7 [INFO] finished tweaking crates.io crate bp-wallet 0.11.0-beta.7 [INFO] tweaked toml for crates.io crate bp-wallet 0.11.0-beta.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate bp-wallet 0.11.0-beta.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90e418ab1daecebed1ecbcdf48d1dcb009ef7d812737b6f7bf6872d58d865bbd [INFO] running `Command { std: "docker" "start" "-a" "90e418ab1daecebed1ecbcdf48d1dcb009ef7d812737b6f7bf6872d58d865bbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90e418ab1daecebed1ecbcdf48d1dcb009ef7d812737b6f7bf6872d58d865bbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90e418ab1daecebed1ecbcdf48d1dcb009ef7d812737b6f7bf6872d58d865bbd", kill_on_drop: false }` [INFO] [stdout] 90e418ab1daecebed1ecbcdf48d1dcb009ef7d812737b6f7bf6872d58d865bbd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e55ac20ca2f07655b83183309697931d34a73e2371e5cfb4f77ba402b846c1f [INFO] running `Command { std: "docker" "start" "-a" "2e55ac20ca2f07655b83183309697931d34a73e2371e5cfb4f77ba402b846c1f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking amplify_num v0.5.3 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Checking mnemonic v1.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking amplify_apfloat v0.3.1 [INFO] [stderr] Checking amplify_syn v2.0.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling amplify_derive v4.0.1 [INFO] [stderr] Compiling strict_encoding_derive v2.7.0-rc.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking amplify v4.7.0 [INFO] [stderr] Checking strict_encoding v2.7.0-rc.1 [INFO] [stderr] Checking baid64 v0.2.2 [INFO] [stderr] Compiling commit_encoding_derive v0.11.0-beta.7 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking vesper-lang v0.1.0 [INFO] [stderr] Checking strict_types v2.7.0-rc.1 [INFO] [stderr] Checking commit_verify v0.11.0-beta.7 [INFO] [stderr] Checking bp-consensus v0.11.0-beta.7 [INFO] [stderr] Checking bp-invoice v0.11.0-beta.7 [INFO] [stderr] Checking bp-derive v0.11.0-beta.7 [INFO] [stderr] Checking descriptors v0.11.0-beta.7 [INFO] [stderr] Checking psbt v0.11.0-beta.7 [INFO] [stderr] Checking bp-std v0.11.0-beta.7 [INFO] [stderr] Checking bp-wallet v0.11.0-beta.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn ok(result: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | err: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:39:61 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn err(ok: T, err: E) -> Self { MayError { ok, err: Some(err) } } [INFO] [stdout] | ----- ------ ^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn ok(result: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | err: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:39:61 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn err(ok: T, err: E) -> Self { MayError { ok, err: Some(err) } } [INFO] [stdout] | ----- ------ ^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 314 | pub fn new_layer1(descr: D, network: Network) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | Wallet { [INFO] [stdout] 316 | descr: WalletDescr::new_standard(descr, network), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:332:20 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new_layer2(descr: D, l2_descr: L2::Descr, layer2: L2, network: Network) -> Self { [INFO] [stdout] | -------- ------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | Wallet { [INFO] [stdout] 332 | descr: WalletDescr::new_layer2(descr, l2_descr, network), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new_layer2(descr: D, l2_descr: L2::Descr, layer2: L2, network: Network) -> Self { [INFO] [stdout] | -------- ------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | cache: WalletCache::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 393 | fn last_published_derivation_index(&self, keychain: impl Into) -> NormalIndex { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let keychain = keychain.into(); [INFO] [stdout] 395 | self.address_coins() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 433 | let map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | self.coins().fold(map, |mut acc, txo| { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 454 | selector: impl Fn(&WalletUtxo) -> bool + 'a, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | / self.all_utxos() [INFO] [stdout] 458 | | .filter(selector) [INFO] [stdout] 459 | | .take_while(move |utxo| { [INFO] [stdout] 460 | | if selected <= up_to { [INFO] [stdout] ... | [INFO] [stdout] 465 | | } [INFO] [stdout] 466 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 314 | pub fn new_layer1(descr: D, network: Network) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | Wallet { [INFO] [stdout] 316 | descr: WalletDescr::new_standard(descr, network), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:332:20 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new_layer2(descr: D, l2_descr: L2::Descr, layer2: L2, network: Network) -> Self { [INFO] [stdout] | -------- ------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | Wallet { [INFO] [stdout] 332 | descr: WalletDescr::new_layer2(descr, l2_descr, network), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn new_layer2(descr: D, l2_descr: L2::Descr, layer2: L2, network: Network) -> Self { [INFO] [stdout] | -------- ------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | cache: WalletCache::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 393 | fn last_published_derivation_index(&self, keychain: impl Into) -> NormalIndex { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 394 | let keychain = keychain.into(); [INFO] [stdout] 395 | self.address_coins() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 433 | let map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | self.coins().fold(map, |mut acc, txo| { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 454 | selector: impl Fn(&WalletUtxo) -> bool + 'a, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | / self.all_utxos() [INFO] [stdout] 458 | | .filter(selector) [INFO] [stdout] 459 | | .take_while(move |utxo| { [INFO] [stdout] 460 | | if selected <= up_to { [INFO] [stdout] ... | [INFO] [stdout] 465 | | } [INFO] [stdout] 466 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bp-wallet` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `bp-wallet` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "2e55ac20ca2f07655b83183309697931d34a73e2371e5cfb4f77ba402b846c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e55ac20ca2f07655b83183309697931d34a73e2371e5cfb4f77ba402b846c1f", kill_on_drop: false }` [INFO] [stdout] 2e55ac20ca2f07655b83183309697931d34a73e2371e5cfb4f77ba402b846c1f