[INFO] fetching crate boxxy 0.13.1... [INFO] checking boxxy-0.13.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boxxy 0.13.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate boxxy 0.13.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boxxy 0.13.1 [INFO] finished tweaking crates.io crate boxxy 0.13.1 [INFO] tweaked toml for crates.io crate boxxy 0.13.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate boxxy 0.13.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28e5881c439984e7f4cb860c42b0f3784c856b61bba5f0633f78aec024db4259 [INFO] running `Command { std: "docker" "start" "-a" "28e5881c439984e7f4cb860c42b0f3784c856b61bba5f0633f78aec024db4259", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28e5881c439984e7f4cb860c42b0f3784c856b61bba5f0633f78aec024db4259", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28e5881c439984e7f4cb860c42b0f3784c856b61bba5f0633f78aec024db4259", kill_on_drop: false }` [INFO] [stdout] 28e5881c439984e7f4cb860c42b0f3784c856b61bba5f0633f78aec024db4259 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20e868cd9809733883062489606bd54a2aed54ee2d435b1896547b6904a01944 [INFO] running `Command { std: "docker" "start" "-a" "20e868cd9809733883062489606bd54a2aed54ee2d435b1896547b6904a01944", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling io-lifetimes v0.7.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling rustix v0.35.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking elf v0.0.10 [INFO] [stderr] Checking pem v1.1.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking close_fds v0.3.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustyline v10.0.0 [INFO] [stderr] Checking ctrlc v3.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling clap_derive v3.2.7 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking caps v0.5.3 [INFO] [stderr] Checking clap v3.2.12 [INFO] [stderr] Checking boxxy v0.13.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn fancy(toolbox: Arc>) -> Interface { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut rl = Editor::new().expect("Failed to create readline editor"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let c = CmdCompleter::new(toolbox); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Interface::Fancy((io::stdin(), io::stdout(), rl)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn file(input: Option, output: Option) -> Interface { [INFO] [stdout] | ------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let input = input.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let output = output.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | Interface::File(BufStream::new(RW(input, output))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 132 | let input = input.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:133:47 [INFO] [stdout] | [INFO] [stdout] 133 | let output = output.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:139:27 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn rw_pair(input: Box, output: Box) -> Interface { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Interface::RWPair(BufStream::new(RW(input, output))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|x| CString::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi/exports.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 9 | let shell = Shell::new(Toolbox::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Box::into_raw(Box::new(shell)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/ffi/exports.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | Box::from_raw(target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 50 | let _ = Box::from_raw(target); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn fancy(toolbox: Arc>) -> Interface { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut rl = Editor::new().expect("Failed to create readline editor"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let c = CmdCompleter::new(toolbox); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Interface::Fancy((io::stdin(), io::stdout(), rl)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn file(input: Option, output: Option) -> Interface { [INFO] [stdout] | ------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let input = input.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let output = output.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | Interface::File(BufStream::new(RW(input, output))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 132 | let input = input.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:133:47 [INFO] [stdout] | [INFO] [stdout] 133 | let output = output.unwrap_or_else(|| File::open("/dev/null").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ctrl.rs:139:27 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn rw_pair(input: Box, output: Box) -> Interface { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Interface::RWPair(BufStream::new(RW(input, output))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi/mod.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|x| CString::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi/exports.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 9 | let shell = Shell::new(Toolbox::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Box::into_raw(Box::new(shell)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/ffi/exports.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | Box::from_raw(target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 50 | let _ = Box::from_raw(target); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boxxy` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boxxy` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "20e868cd9809733883062489606bd54a2aed54ee2d435b1896547b6904a01944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20e868cd9809733883062489606bd54a2aed54ee2d435b1896547b6904a01944", kill_on_drop: false }` [INFO] [stdout] 20e868cd9809733883062489606bd54a2aed54ee2d435b1896547b6904a01944