[INFO] fetching crate botfair 0.3.1... [INFO] checking botfair-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate botfair 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate botfair 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate botfair 0.3.1 [INFO] finished tweaking crates.io crate botfair 0.3.1 [INFO] tweaked toml for crates.io crate botfair 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 206 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding base64 v0.10.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding cookie v0.12.0 (latest: v0.18.1) [INFO] [stderr] Adding cookie_store v0.7.0 (latest: v0.21.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding ct-logs v0.6.0 (latest: v0.9.0) [INFO] [stderr] Adding dtoa v0.4.8 (latest: v1.0.9) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.1.26 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.1.21 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.1.0 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.12.36 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.17.1 (latest: v0.27.2) [INFO] [stderr] Adding hyper-tls v0.3.2 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding idna v0.2.3 (latest: v1.0.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itoa v0.4.8 (latest: v1.0.11) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding publicsuffix v1.5.6 (latest: v2.2.3) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding reqwest v0.9.24 (latest: v0.12.7) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding rustls v0.16.0 (latest: v0.23.12) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding serde_urlencoded v0.5.5 (latest: v0.7.1) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding string v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-rustls v0.10.3 (latest: v0.26.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding uuid v0.7.4 (latest: v1.10.0) [INFO] [stderr] Adding want v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding webpki-roots v0.17.0 (latest: v0.26.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winreg v0.6.2 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87c8c716f0aa448453ba6983b962006ff9cd3c71fc1089600701f88640aaccbe [INFO] running `Command { std: "docker" "start" "-a" "87c8c716f0aa448453ba6983b962006ff9cd3c71fc1089600701f88640aaccbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87c8c716f0aa448453ba6983b962006ff9cd3c71fc1089600701f88640aaccbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87c8c716f0aa448453ba6983b962006ff9cd3c71fc1089600701f88640aaccbe", kill_on_drop: false }` [INFO] [stdout] 87c8c716f0aa448453ba6983b962006ff9cd3c71fc1089600701f88640aaccbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e711f0589349cd699eb8718372a730bc7965bd9e6449affe426fc4ab9f31789 [INFO] running `Command { std: "docker" "start" "-a" "4e711f0589349cd699eb8718372a730bc7965bd9e6449affe426fc4ab9f31789", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking parking_lot_core v0.6.3 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling hyper v0.12.36 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking try_from v0.3.2 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking ct-logs v0.6.0 [INFO] [stderr] Checking rustls v0.16.0 [INFO] [stderr] Checking webpki-roots v0.17.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tokio-rustls v0.10.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking hyper-rustls v0.17.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking hyper-tls v0.3.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking cookie_store v0.7.0 [INFO] [stderr] Checking reqwest v0.9.24 [INFO] [stderr] Checking botfair v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `token` and `product` are never read [INFO] [stdout] --> src/client.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 415 | struct KeepAliveResponse { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 416 | token: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 417 | product: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeepAliveResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/json_rpc.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct RpcError { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | code: i32, // TODO are these ever meaningful? [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 104 | let client: reqwest::Client = match &proxy_uri { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Some(uri) => { [INFO] [stdout] 106 | let proxy = reqwest::Proxy::all(uri)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let session_token = Arc::new(RwLock::new(None)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | [INFO] [stdout] 114 | let destructor = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let session_token = session_token.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let proxy_uri = proxy_uri.clone(); [INFO] [stdout] 117 | let (tx, rx) = mpsc::sync_channel(0); // rendezvous channel [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(BFClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | client, [INFO] [stdout] 126 | | destructor, [INFO] [stdout] 127 | | session_token, [INFO] [stdout] 128 | | creds, [INFO] [stdout] 129 | | proxy_uri, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 206 | let mut http_response: reqwest::Response = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let maybe_http_response = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let rpc_response: RpcResponse = match http_response.json() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | match rpc_response.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_rpc.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | match (self.error, self.result) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `botfair` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `token` and `product` are never read [INFO] [stdout] --> src/client.rs:416:5 [INFO] [stdout] | [INFO] [stdout] 415 | struct KeepAliveResponse { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] 416 | token: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 417 | product: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeepAliveResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/json_rpc.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct RpcError { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | code: i32, // TODO are these ever meaningful? [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RpcError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 104 | let client: reqwest::Client = match &proxy_uri { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Some(uri) => { [INFO] [stdout] 106 | let proxy = reqwest::Proxy::all(uri)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let session_token = Arc::new(RwLock::new(None)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | [INFO] [stdout] 114 | let destructor = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let session_token = session_token.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let proxy_uri = proxy_uri.clone(); [INFO] [stdout] 117 | let (tx, rx) = mpsc::sync_channel(0); // rendezvous channel [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(BFClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | client, [INFO] [stdout] 126 | | destructor, [INFO] [stdout] 127 | | session_token, [INFO] [stdout] 128 | | creds, [INFO] [stdout] 129 | | proxy_uri, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 206 | let mut http_response: reqwest::Response = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let maybe_http_response = self [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | let rpc_response: RpcResponse = match http_response.json() { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | match rpc_response.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_rpc.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | match (self.error, self.result) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `botfair` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4e711f0589349cd699eb8718372a730bc7965bd9e6449affe426fc4ab9f31789", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e711f0589349cd699eb8718372a730bc7965bd9e6449affe426fc4ab9f31789", kill_on_drop: false }` [INFO] [stdout] 4e711f0589349cd699eb8718372a730bc7965bd9e6449affe426fc4ab9f31789