[INFO] fetching crate bosh-rs 0.4.0... [INFO] checking bosh-rs-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bosh-rs 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate bosh-rs 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bosh-rs 0.4.0 [INFO] finished tweaking crates.io crate bosh-rs 0.4.0 [INFO] tweaked toml for crates.io crate bosh-rs 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e55901683c36bfa57f107c911ab016aca6d002f4b68b2921bd7ec347ec278ae [INFO] running `Command { std: "docker" "start" "-a" "7e55901683c36bfa57f107c911ab016aca6d002f4b68b2921bd7ec347ec278ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e55901683c36bfa57f107c911ab016aca6d002f4b68b2921bd7ec347ec278ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e55901683c36bfa57f107c911ab016aca6d002f4b68b2921bd7ec347ec278ae", kill_on_drop: false }` [INFO] [stdout] 7e55901683c36bfa57f107c911ab016aca6d002f4b68b2921bd7ec347ec278ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a76ec664ab1e54ae85b715d457aba1a7e9e7d4d1b80f2d39862d9d376120cec2 [INFO] running `Command { std: "docker" "start" "-a" "a76ec664ab1e54ae85b715d457aba1a7e9e7d4d1b80f2d39862d9d376120cec2", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking read-from v0.5.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bosh-rs v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/serialization/lrcom.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | line_type: line.borrow().line_type.into(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `line::Line` does not implement `Borrow`, so calling `borrow` on `&line::Line` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 109 - line_type: line.borrow().line_type.into(), [INFO] [stdout] 109 + line_type: line.line_type.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `line::Line`, implement `Clone` for it [INFO] [stdout] --> src/game/line.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Clone)] [INFO] [stdout] 31 | pub struct Line { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialization/trk.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 73 | fn read_from(mut input: R) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let features: HashSet = String::from_utf8_lossy(features_string.as_slice()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(TrkHeader { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | version, [INFO] [stdout] 124 | | features, [INFO] [stdout] 125 | | song, [INFO] [stdout] 126 | | start_position, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bosh-rs` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/serialization/lrcom.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | line_type: line.borrow().line_type.into(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `line::Line` does not implement `Borrow`, so calling `borrow` on `&line::Line` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 109 - line_type: line.borrow().line_type.into(), [INFO] [stdout] 109 + line_type: line.line_type.into(), [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `line::Line`, implement `Clone` for it [INFO] [stdout] --> src/game/line.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Clone)] [INFO] [stdout] 31 | pub struct Line { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialization/trk.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 73 | fn read_from(mut input: R) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let features: HashSet = String::from_utf8_lossy(features_string.as_slice()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(TrkHeader { [INFO] [stdout] | ____________^ [INFO] [stdout] 123 | | version, [INFO] [stdout] 124 | | features, [INFO] [stdout] 125 | | song, [INFO] [stdout] 126 | | start_position, [INFO] [stdout] 127 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bosh-rs` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a76ec664ab1e54ae85b715d457aba1a7e9e7d4d1b80f2d39862d9d376120cec2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a76ec664ab1e54ae85b715d457aba1a7e9e7d4d1b80f2d39862d9d376120cec2", kill_on_drop: false }` [INFO] [stdout] a76ec664ab1e54ae85b715d457aba1a7e9e7d4d1b80f2d39862d9d376120cec2