[INFO] fetching crate borrow_mutex 0.1.1... [INFO] checking borrow_mutex-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate borrow_mutex 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate borrow_mutex 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate borrow_mutex 0.1.1 [INFO] finished tweaking crates.io crate borrow_mutex 0.1.1 [INFO] tweaked toml for crates.io crate borrow_mutex 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-fs v1.6.0 (latest: v2.1.2) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-net v1.8.0 (latest: v2.0.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding smol v1.3.0 (latest: v2.0.1) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82acafca1171d8a52f40f092c203ae9c31e94cb3f6077121de773154907d846a [INFO] running `Command { std: "docker" "start" "-a" "82acafca1171d8a52f40f092c203ae9c31e94cb3f6077121de773154907d846a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82acafca1171d8a52f40f092c203ae9c31e94cb3f6077121de773154907d846a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82acafca1171d8a52f40f092c203ae9c31e94cb3f6077121de773154907d846a", kill_on_drop: false }` [INFO] [stdout] 82acafca1171d8a52f40f092c203ae9c31e94cb3f6077121de773154907d846a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0775c78ff73f13d5ba67a55b2f6d7587e7ff64fd42522d4b896fca7e8174f00 [INFO] running `Command { std: "docker" "start" "-a" "c0775c78ff73f13d5ba67a55b2f6d7587e7ff64fd42522d4b896fca7e8174f00", kill_on_drop: false }` [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking borrow_mutex v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/mpmc_spam.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 40 | let thread_stat_handles = (0..num_threads) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / thread_stat_handles [INFO] [stdout] 87 | | .into_iter() [INFO] [stdout] 88 | | .map(|t| t.join()) [INFO] [stdout] 89 | | .collect::>>() [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `borrow_mutex` (test "mpmc_spam") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_basic_mt.rs:23:37 [INFO] [stdout] | [INFO] [stdout] 21 | let t1_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let t1 = std::thread::spawn(|| { [INFO] [stdout] 23 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 24 | | let mut test = TestObject { counter: 1 }; [INFO] [stdout] 25 | | [INFO] [stdout] 26 | | eprintln!("t1 thread: {:?}", std::thread::current()); [INFO] [stdout] ... | [INFO] [stdout] 45 | | t1_mutex.terminate().await; [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_basic_mt.rs:51:37 [INFO] [stdout] | [INFO] [stdout] 49 | let t2_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let t2 = std::thread::spawn(|| { [INFO] [stdout] 51 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 52 | | eprintln!("t2 thread: {:?}", std::thread::current()); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | while let Ok(mut test) = t2_mutex.request_borrow().await { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_basic_mt.rs:73:37 [INFO] [stdout] | [INFO] [stdout] 71 | let t1_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let t1 = std::thread::spawn(|| { [INFO] [stdout] 73 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 74 | | let mut test = TestObject { counter: 1 }; [INFO] [stdout] 75 | | [INFO] [stdout] 76 | | eprintln!("t1 thread: {:?}", std::thread::current()); [INFO] [stdout] ... | [INFO] [stdout] 95 | | t1_mutex.terminate().await; [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_basic_mt.rs:103:41 [INFO] [stdout] | [INFO] [stdout] 101 | let t_mutex = mutex.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let t: std::thread::JoinHandle<()> = std::thread::spawn(move || { [INFO] [stdout] 103 | futures::executor::block_on(async move { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 104 | | eprintln!("t{n} thread: {:?}", std::thread::current()); [INFO] [stdout] 105 | | [INFO] [stdout] 106 | | while let Ok(mut test) = t_mutex.request_borrow().await { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `borrow_mutex` (test "borrow_basic_mt") due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:103:37 [INFO] [stdout] | [INFO] [stdout] 101 | let f1_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let f1 = move || { [INFO] [stdout] 103 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 104 | | let mut test = TestObject { counter: 1 }; [INFO] [stdout] 105 | | loop { [INFO] [stdout] 106 | | if test.counter >= 20 { [INFO] [stdout] ... | [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:126:37 [INFO] [stdout] | [INFO] [stdout] 124 | let f2_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let f2 = move || { [INFO] [stdout] 126 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 127 | | let mut test = AnotherTestObject { [INFO] [stdout] 128 | | is_even: false, [INFO] [stdout] 129 | | another_counter: 1, [INFO] [stdout] ... | [INFO] [stdout] 148 | | } [INFO] [stdout] 149 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 152 | let tborrower_mutex = mutex.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let tborrower = std::thread::spawn(|| { [INFO] [stdout] 154 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 155 | | while let Ok(mut any) = tborrower_mutex.request_borrow().await { [INFO] [stdout] 156 | | if let Some(test) = any.downcast_mut::() { [INFO] [stdout] 157 | | test.counter += 1; [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:185:37 [INFO] [stdout] | [INFO] [stdout] 183 | let f1_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let f1 = move || { [INFO] [stdout] 185 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 186 | | let mut test = TestObject { counter: 1 }; [INFO] [stdout] 187 | | loop { [INFO] [stdout] 188 | | if test.counter >= 20 { [INFO] [stdout] ... | [INFO] [stdout] 202 | | } [INFO] [stdout] 203 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 206 | let f2_mutex = mutex.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let f2 = move || { [INFO] [stdout] 208 | futures::executor::block_on(async move { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 209 | | let mut test = AnotherTestObject { [INFO] [stdout] 210 | | is_even: false, [INFO] [stdout] 211 | | another_counter: 1, [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/borrow_dyn.rs:239:41 [INFO] [stdout] | [INFO] [stdout] 237 | let tborrower_mutex = mutex.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let tborrower = std::thread::spawn(move || { [INFO] [stdout] 239 | futures::executor::block_on(async move { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 240 | | while let Ok(mut any) = tborrower_mutex.request_borrow().await { [INFO] [stdout] 241 | | if let Some(test) = any.downcast_mut::() { [INFO] [stdout] 242 | | test.counter += 1; [INFO] [stdout] ... | [INFO] [stdout] 252 | | } [INFO] [stdout] 253 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `borrow_mutex` (test "borrow_dyn") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "c0775c78ff73f13d5ba67a55b2f6d7587e7ff64fd42522d4b896fca7e8174f00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0775c78ff73f13d5ba67a55b2f6d7587e7ff64fd42522d4b896fca7e8174f00", kill_on_drop: false }` [INFO] [stdout] c0775c78ff73f13d5ba67a55b2f6d7587e7ff64fd42522d4b896fca7e8174f00