[INFO] fetching crate boringdb 0.4.1... [INFO] checking boringdb-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boringdb 0.4.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate boringdb 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boringdb 0.4.1 [INFO] finished tweaking crates.io crate boringdb 0.4.1 [INFO] tweaked toml for crates.io crate boringdb 0.4.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 114 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hashbrown v0.11.2 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.7.0 (latest: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.23.2 (latest: v0.30.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rusqlite v0.26.3 (latest: v0.32.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83dae2f20eea21a053214073633821d35f346c32f36b12f42ba7b64ad433f908 [INFO] running `Command { std: "docker" "start" "-a" "83dae2f20eea21a053214073633821d35f346c32f36b12f42ba7b64ad433f908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83dae2f20eea21a053214073633821d35f346c32f36b12f42ba7b64ad433f908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83dae2f20eea21a053214073633821d35f346c32f36b12f42ba7b64ad433f908", kill_on_drop: false }` [INFO] [stdout] 83dae2f20eea21a053214073633821d35f346c32f36b12f42ba7b64ad433f908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b98b9a4b78e26625312f08039a0c9b59a2821e3e177d9de8870ffba9069ab6e [INFO] running `Command { std: "docker" "start" "-a" "7b98b9a4b78e26625312f08039a0c9b59a2821e3e177d9de8870ffba9069ab6e", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling libsqlite3-sys v0.23.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking genawaiter-macro v0.99.1 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking genawaiter v0.99.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking easy-parallel v3.3.1 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking hashlink v0.7.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking rusqlite v0.26.3 [INFO] [stderr] Checking boringdb v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::sync::Mutex` [INFO] [stdout] --> src/low_level.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::Mutex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Mutex` [INFO] [stdout] --> src/low_level.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::Mutex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `table_name` is never read [INFO] [stdout] --> src/dict.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 11 | struct DictInner { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | table_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `GLOBAL_PSEUDO_TIME` is never used [INFO] [stdout] --> src/globals.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) static GLOBAL_PSEUDO_TIME: AtomicU64 = AtomicU64::new(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open(path: impl Into) -> BoringResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let low_level: LowLevel = LowLevel::open(path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | low_level: Arc::new(low_level), [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 34 | fn write(&self, key: Bytes, value: Bytes) -> BoringResult> { [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / self.low_level [INFO] [stdout] 36 | | .transaction(|txn| { [INFO] [stdout] 37 | | let existing: Option> = txn [INFO] [stdout] 38 | | .prepare_cached(&self.read_statement)? [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | Ok(result.map(|v| v.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 77 | let result: Option> = self.low_level.transaction(move |transaction| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut statement: rusqlite::CachedStatement = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | transaction.prepare_cached(&read_statement)?; [INFO] [stdout] 80 | statement.query_row(&[key], |r| r.get(0)).optional() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 102 | key: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | val: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> BoringResult> { [INFO] [stdout] 105 | self.inner.write(key.into(), val.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 102 | key: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | val: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> BoringResult> { [INFO] [stdout] 105 | self.inner.write(key.into(), val.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub(crate) fn new(low_level: Arc, table_name: &str) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | inner: Arc::new(DictInner::new(low_level, table_name)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/low_level.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open(path: impl Into) -> rusqlite::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let flags: rusqlite::OpenFlags = rusqlite::OpenFlags::default(); [INFO] [stdout] 22 | let (conn_send, conn_recv) = flume::bounded(16); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | conn_send, [INFO] [stdout] 33 | | conn_recv, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/lib.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 75 | range.into_iter().for_each(|index| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `table_name` is never read [INFO] [stdout] --> src/dict.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 11 | struct DictInner { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | table_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `GLOBAL_PSEUDO_TIME` is never used [INFO] [stdout] --> src/globals.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) static GLOBAL_PSEUDO_TIME: AtomicU64 = AtomicU64::new(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open(path: impl Into) -> BoringResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let low_level: LowLevel = LowLevel::open(path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | low_level: Arc::new(low_level), [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 34 | fn write(&self, key: Bytes, value: Bytes) -> BoringResult> { [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / self.low_level [INFO] [stdout] 36 | | .transaction(|txn| { [INFO] [stdout] 37 | | let existing: Option> = txn [INFO] [stdout] 38 | | .prepare_cached(&self.read_statement)? [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | Ok(result.map(|v| v.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 77 | let result: Option> = self.low_level.transaction(move |transaction| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut statement: rusqlite::CachedStatement = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | transaction.prepare_cached(&read_statement)?; [INFO] [stdout] 80 | statement.query_row(&[key], |r| r.get(0)).optional() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 102 | key: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | val: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> BoringResult> { [INFO] [stdout] 105 | self.inner.write(key.into(), val.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boringdb` (lib) due to 9 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 102 | key: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | val: impl Into, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> BoringResult> { [INFO] [stdout] 105 | self.inner.write(key.into(), val.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dict.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub(crate) fn new(low_level: Arc, table_name: &str) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self { [INFO] [stdout] 116 | inner: Arc::new(DictInner::new(low_level, table_name)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/low_level.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open(path: impl Into) -> rusqlite::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let flags: rusqlite::OpenFlags = rusqlite::OpenFlags::default(); [INFO] [stdout] 22 | let (conn_send, conn_recv) = flume::bounded(16); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | conn_send, [INFO] [stdout] 33 | | conn_recv, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/low_level.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 78 | let low_level = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / low_level [INFO] [stdout] 82 | | .transaction(|conn: rusqlite::Transaction| { [INFO] [stdout] 83 | | conn.execute( [INFO] [stdout] 84 | | "create table if not exists test (key blob primary key, value blob)", [INFO] [stdout] ... | [INFO] [stdout] 88 | | Ok(()) [INFO] [stdout] 89 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boringdb` (lib test) due to 10 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7b98b9a4b78e26625312f08039a0c9b59a2821e3e177d9de8870ffba9069ab6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b98b9a4b78e26625312f08039a0c9b59a2821e3e177d9de8870ffba9069ab6e", kill_on_drop: false }` [INFO] [stdout] 7b98b9a4b78e26625312f08039a0c9b59a2821e3e177d9de8870ffba9069ab6e