[INFO] fetching crate boomhammer 0.1.0... [INFO] checking boomhammer-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boomhammer 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate boomhammer 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boomhammer 0.1.0 [INFO] finished tweaking crates.io crate boomhammer 0.1.0 [INFO] tweaked toml for crates.io crate boomhammer 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate boomhammer 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bad82901291e84001d76cbd334422abc81193cc1a16c43fda233f8ac16db440e [INFO] running `Command { std: "docker" "start" "-a" "bad82901291e84001d76cbd334422abc81193cc1a16c43fda233f8ac16db440e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bad82901291e84001d76cbd334422abc81193cc1a16c43fda233f8ac16db440e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bad82901291e84001d76cbd334422abc81193cc1a16c43fda233f8ac16db440e", kill_on_drop: false }` [INFO] [stdout] bad82901291e84001d76cbd334422abc81193cc1a16c43fda233f8ac16db440e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0ef66e5dfa83cfc630d679e465dfce3c681c267ab90219d62e0d92900094f90 [INFO] running `Command { std: "docker" "start" "-a" "a0ef66e5dfa83cfc630d679e465dfce3c681c267ab90219d62e0d92900094f90", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking fancy-duration v0.9.2 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.4 [INFO] [stderr] Checking boomhammer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 53 | let uri: hyper::Uri = url.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let (used, incoming) = channel(1000); [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | used, [INFO] [stdout] 70 | | incoming: Arc::new(Mutex::new(incoming)), [INFO] [stdout] 71 | | addr, [INFO] [stdout] 72 | | uri, [INFO] [stdout] 73 | | drain: false, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:197:35 [INFO] [stdout] | [INFO] [stdout] 194 | let w_close = close.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let worker = rb.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let s = s.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | tokio::spawn(async move { worker.drain(true).worker(w_close, s).await.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 193 | let rb = RequestBuilder::new(args.url.clone())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let s_close = close.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | tokio::spawn(async move { [INFO] [stdout] 200 | / rb.seed_connections(s_close) [INFO] [stdout] 201 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 53 | let uri: hyper::Uri = url.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let (used, incoming) = channel(1000); [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | used, [INFO] [stdout] 70 | | incoming: Arc::new(Mutex::new(incoming)), [INFO] [stdout] 71 | | addr, [INFO] [stdout] 72 | | uri, [INFO] [stdout] 73 | | drain: false, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:197:35 [INFO] [stdout] | [INFO] [stdout] 194 | let w_close = close.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let worker = rb.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let s = s.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | tokio::spawn(async move { worker.drain(true).worker(w_close, s).await.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 193 | let rb = RequestBuilder::new(args.url.clone())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let s_close = close.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | tokio::spawn(async move { [INFO] [stdout] 200 | / rb.seed_connections(s_close) [INFO] [stdout] 201 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boomhammer` (bin "boomhammer" test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `boomhammer` (bin "boomhammer") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a0ef66e5dfa83cfc630d679e465dfce3c681c267ab90219d62e0d92900094f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0ef66e5dfa83cfc630d679e465dfce3c681c267ab90219d62e0d92900094f90", kill_on_drop: false }` [INFO] [stdout] a0ef66e5dfa83cfc630d679e465dfce3c681c267ab90219d62e0d92900094f90