[INFO] fetching crate bomper 0.7.0... [INFO] checking bomper-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bomper 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bomper 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bomper 0.7.0 [INFO] finished tweaking crates.io crate bomper 0.7.0 [INFO] tweaked toml for crates.io crate bomper 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate bomper 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94e8a24a6eb933ccc26b599a0a4562b0d026afc00aff4a1965d491837e827302 [INFO] running `Command { std: "docker" "start" "-a" "94e8a24a6eb933ccc26b599a0a4562b0d026afc00aff4a1965d491837e827302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94e8a24a6eb933ccc26b599a0a4562b0d026afc00aff4a1965d491837e827302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94e8a24a6eb933ccc26b599a0a4562b0d026afc00aff4a1965d491837e827302", kill_on_drop: false }` [INFO] [stdout] 94e8a24a6eb933ccc26b599a0a4562b0d026afc00aff4a1965d491837e827302 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42e0834a3513bb401c21246c3892c7bb9a85170a28b28e8cccc73a7dd1f4cb1e [INFO] running `Command { std: "docker" "start" "-a" "42e0834a3513bb401c21246c3892c7bb9a85170a28b28e8cccc73a7dd1f4cb1e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking human_format v1.1.0 [INFO] [stderr] Checking prodash v26.2.2 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking byteyarn v0.2.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking uluru v3.1.0 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking imara-diff v0.1.5 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Checking io-close v0.3.7 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking winnow v0.6.7 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling figment v0.10.18 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking gix-command v0.2.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking inlinable_string v0.1.15 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking indexmap v1.9.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Compiling gix-macros v0.1.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pear v0.2.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking gix-date v0.8.5 [INFO] [stderr] Checking gix-validate v0.8.4 [INFO] [stderr] Checking gix-path v0.10.7 [INFO] [stderr] Checking gix-actor v0.27.0 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Checking gix-mailmap v0.19.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking faster-hex v0.8.1 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking gix-hash v0.13.3 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking gix-config-value v0.14.6 [INFO] [stderr] Checking gix-packetline-blocking v0.16.6 [INFO] [stderr] Checking gix-sec v0.10.6 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking gix-features v0.35.0 [INFO] [stderr] Checking gix-hashtable v0.4.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking gix-object v0.37.0 [INFO] [stderr] Checking gix-fs v0.7.0 [INFO] [stderr] Checking gix-commitgraph v0.21.0 [INFO] [stderr] Checking gix-glob v0.13.0 [INFO] [stderr] Checking gix-url v0.24.0 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking cargo-lock v8.0.3 [INFO] [stderr] Checking gix-attributes v0.19.0 [INFO] [stderr] Checking gix-ignore v0.8.0 [INFO] [stderr] Checking gix-revwalk v0.8.0 [INFO] [stderr] Checking gix-diff v0.36.0 [INFO] [stderr] Checking gix-traverse v0.33.0 [INFO] [stderr] Checking gix-filter v0.5.0 [INFO] [stderr] Checking gix-pathspec v0.3.0 [INFO] [stderr] Checking gix-revision v0.22.0 [INFO] [stderr] Checking gix-negotiate v0.8.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking gix-prompt v0.7.0 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking gix-refspec v0.18.0 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking gix-credentials v0.20.0 [INFO] [stderr] Checking gix-tempfile v10.0.0 [INFO] [stderr] Checking gix-worktree-stream v0.5.0 [INFO] [stderr] Checking gix-lock v10.0.0 [INFO] [stderr] Checking gix-pack v0.43.0 [INFO] [stderr] Checking gix-archive v0.5.0 [INFO] [stderr] Checking gix-index v0.25.0 [INFO] [stderr] Checking gix-ref v0.37.0 [INFO] [stderr] Checking cargo_toml v0.15.3 [INFO] [stderr] Checking gix-worktree v0.26.0 [INFO] [stderr] Checking gix-status v0.1.0 [INFO] [stderr] Checking gix-odb v0.53.0 [INFO] [stderr] Checking gix-worktree-state v0.3.0 [INFO] [stderr] Checking gix-config v0.30.0 [INFO] [stderr] Checking gix-discover v0.25.0 [INFO] [stderr] Checking gix-submodule v0.4.0 [INFO] [stderr] Checking gix v0.54.1 [INFO] [stderr] Checking project-base-directory v0.3.0 [INFO] [stderr] Checking bomper v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 36 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let metadata = get_workspace_metadata()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mut lockfile = cargo_lock::Lockfile::load(&self.lock_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let packages = match &self.replace_mode { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let new_version = cargo_lock::Version::from_str(&self.versions.new_version)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let old_version = cargo_lock::Version::from_str(&self.versions.old_version)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:188:8 [INFO] [stdout] | [INFO] [stdout] 178 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Some(FileReplacer { [INFO] [stdout] | ________^ [INFO] [stdout] 189 | | path: cargo_toml_path.into(), [INFO] [stdout] 190 | | temp_file, [INFO] [stdout] 191 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:243:8 [INFO] [stdout] | [INFO] [stdout] 233 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(Some(FileReplacer { [INFO] [stdout] | ________^ [INFO] [stdout] 244 | | path: cargo_toml_path.into(), [INFO] [stdout] 245 | | temp_file, [INFO] [stdout] 246 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 28 | let regex = regex::bytes::RegexBuilder::new(&expr).build()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let verification_regex = regex::bytes::Regex::new(verification_regex)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | path, [INFO] [stdout] 33 | | regex, [INFO] [stdout] 34 | | verification_regex, [INFO] [stdout] 35 | | new_data: String::from(new_content).into_bytes(), [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let mut target_map = unsafe { MmapMut::map_mut(file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(FileReplacer { [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | path: self.path, [INFO] [stdout] 129 | | temp_file, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 137 | fn determine_replacements(self) -> Result>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let source_file = File::open(&self.path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let source_meta = fs::metadata(&self.path)?; [INFO] [stdout] 142 | let source_buf = unsafe { Mmap::map(&source_file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let replacer = self.get_replacement(&source_buf, offsets, source_meta.permissions())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/simple.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | let regex = regex::bytes::RegexBuilder::new(&search_text).build()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | path, [INFO] [stdout] 20 | | regex, [INFO] [stdout] 21 | | new_data: String::from(new_content).into_bytes(), [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/simple.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 27 | fn determine_replacements(self) -> Result>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let source_file = File::open(&self.path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let source_meta = fs::metadata(&self.path)?; [INFO] [stdout] 32 | let source_map = unsafe { Mmap::map(&source_file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bomper` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 36 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | let metadata = get_workspace_metadata()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mut lockfile = cargo_lock::Lockfile::load(&self.lock_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let packages = match &self.replace_mode { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let new_version = cargo_lock::Version::from_str(&self.versions.new_version)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let old_version = cargo_lock::Version::from_str(&self.versions.old_version)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:188:8 [INFO] [stdout] | [INFO] [stdout] 178 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Ok(Some(FileReplacer { [INFO] [stdout] | ________^ [INFO] [stdout] 189 | | path: cargo_toml_path.into(), [INFO] [stdout] 190 | | temp_file, [INFO] [stdout] 191 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/cargo.rs:243:8 [INFO] [stdout] | [INFO] [stdout] 233 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Ok(Some(FileReplacer { [INFO] [stdout] | ________^ [INFO] [stdout] 244 | | path: cargo_toml_path.into(), [INFO] [stdout] 245 | | temp_file, [INFO] [stdout] 246 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 28 | let regex = regex::bytes::RegexBuilder::new(&expr).build()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let verification_regex = regex::bytes::Regex::new(verification_regex)?; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | path, [INFO] [stdout] 33 | | regex, [INFO] [stdout] 34 | | verification_regex, [INFO] [stdout] 35 | | new_data: String::from(new_content).into_bytes(), [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let mut target_map = unsafe { MmapMut::map_mut(file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok(FileReplacer { [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | path: self.path, [INFO] [stdout] 129 | | temp_file, [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/search.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 137 | fn determine_replacements(self) -> Result>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | [INFO] [stdout] 140 | let source_file = File::open(&self.path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let source_meta = fs::metadata(&self.path)?; [INFO] [stdout] 142 | let source_buf = unsafe { Mmap::map(&source_file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let replacer = self.get_replacement(&source_buf, offsets, source_meta.permissions())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/simple.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | let regex = regex::bytes::RegexBuilder::new(&search_text).build()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | path, [INFO] [stdout] 20 | | regex, [INFO] [stdout] 21 | | new_data: String::from(new_content).into_bytes(), [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replacers/simple.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 27 | fn determine_replacements(self) -> Result>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut replacers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let source_file = File::open(&self.path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let source_meta = fs::metadata(&self.path)?; [INFO] [stdout] 32 | let source_map = unsafe { Mmap::map(&source_file)? }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let temp_file = tempfile::NamedTempFile::new_in( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Some(replacers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:377:17 [INFO] [stdout] | [INFO] [stdout] 376 | .map(|replacer| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | jail.strip_path(replacer.path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bomper` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "42e0834a3513bb401c21246c3892c7bb9a85170a28b28e8cccc73a7dd1f4cb1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42e0834a3513bb401c21246c3892c7bb9a85170a28b28e8cccc73a7dd1f4cb1e", kill_on_drop: false }` [INFO] [stdout] 42e0834a3513bb401c21246c3892c7bb9a85170a28b28e8cccc73a7dd1f4cb1e