[INFO] fetching crate boltz-client 0.1.2... [INFO] checking boltz-client-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boltz-client 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate boltz-client 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boltz-client 0.1.2 [INFO] finished tweaking crates.io crate boltz-client 0.1.2 [INFO] tweaked toml for crates.io crate boltz-client 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bech32 v0.10.0-beta (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin v0.31.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin-internals v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (latest: v0.14.0) [INFO] [stderr] Adding electrum-client v0.19.0 (latest: v0.21.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lightning v0.0.118 (latest: v0.0.123) [INFO] [stderr] Adding lightning-invoice v0.26.0 (latest: v0.31.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1-zkp v0.10.1 (latest: v0.11.0) [INFO] [stderr] Adding secp256k1-zkp-sys v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding unicode-normalization v0.1.22 (latest: v0.1.23) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37adcd0a2f5eea66bc281cd50d49dac06940a07e58a5fe9372c5de7b2f2260c7 [INFO] running `Command { std: "docker" "start" "-a" "37adcd0a2f5eea66bc281cd50d49dac06940a07e58a5fe9372c5de7b2f2260c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37adcd0a2f5eea66bc281cd50d49dac06940a07e58a5fe9372c5de7b2f2260c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37adcd0a2f5eea66bc281cd50d49dac06940a07e58a5fe9372c5de7b2f2260c7", kill_on_drop: false }` [INFO] [stdout] 37adcd0a2f5eea66bc281cd50d49dac06940a07e58a5fe9372c5de7b2f2260c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b005296190b1622ce6c263284f798b4c9173406c2f138375101c43dd149495c3 [INFO] running `Command { std: "docker" "start" "-a" "b005296190b1622ce6c263284f798b4c9173406c2f138375101c43dd149495c3", kill_on_drop: false }` [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling secp256k1-zkp-sys v0.9.1 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Compiling bitcoin v0.31.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bech32 v0.10.0-beta [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking bip39 v2.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking lightning v0.0.118 [INFO] [stderr] Checking secp256k1-zkp v0.10.1 [INFO] [stderr] Checking elements v0.24.1 [INFO] [stderr] Checking electrum-client v0.19.0 [INFO] [stderr] Checking lightning-invoice v0.26.0 [INFO] [stderr] Checking boltz-client v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/bitcoin.rs:615:15 [INFO] [stdout] | [INFO] [stdout] 614 | let electrum_client = network_config.build_client()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | match electrum_client.transaction_broadcast(&signed_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/boltz.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 132 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | }; [INFO] [stdout] 134 | match ureq::post(&url).send_json(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/boltz.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 161 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | }; [INFO] [stdout] 163 | match ureq::post(&url).send_json(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/liquid.rs:943:15 [INFO] [stdout] | [INFO] [stdout] 938 | signed_tx: Transaction, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 941 | let electrum_client = network_config.build_client()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 942 | let serialized = serialize(&signed_tx); [INFO] [stdout] 943 | match electrum_client.transaction_broadcast_raw(&serialized) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/secrets.rs:336:15 [INFO] [stdout] | [INFO] [stdout] 327 | pub fn read_from_file>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | match serde_json::from_str(&contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boltz-client` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/bitcoin.rs:615:15 [INFO] [stdout] | [INFO] [stdout] 614 | let electrum_client = network_config.build_client()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 615 | match electrum_client.transaction_broadcast(&signed_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/boltz.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 132 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | }; [INFO] [stdout] 134 | match ureq::post(&url).send_json(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/boltz.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 161 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | }; [INFO] [stdout] 163 | match ureq::post(&url).send_json(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/swaps/liquid.rs:943:15 [INFO] [stdout] | [INFO] [stdout] 938 | signed_tx: Transaction, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 941 | let electrum_client = network_config.build_client()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 942 | let serialized = serialize(&signed_tx); [INFO] [stdout] 943 | match electrum_client.transaction_broadcast_raw(&serialized) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/secrets.rs:336:15 [INFO] [stdout] | [INFO] [stdout] 327 | pub fn read_from_file>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | Err(e) => return Err(S5Error::new(ErrorKind::Input, &e.to_string())), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | match serde_json::from_str(&contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/util/secrets.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | file.write_to_file(base_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 538 | let _ = file.write_to_file(base_path); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boltz-client` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b005296190b1622ce6c263284f798b4c9173406c2f138375101c43dd149495c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b005296190b1622ce6c263284f798b4c9173406c2f138375101c43dd149495c3", kill_on_drop: false }` [INFO] [stdout] b005296190b1622ce6c263284f798b4c9173406c2f138375101c43dd149495c3