[INFO] fetching crate boa_string 0.19.0... [INFO] checking boa_string-0.19.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boa_string 0.19.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate boa_string 0.19.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boa_string 0.19.0 [INFO] finished tweaking crates.io crate boa_string 0.19.0 [INFO] tweaked toml for crates.io crate boa_string 0.19.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 102ef0d6eecf7f05e35cfdff48608104324b719aef16bd3d7a3f0d8e532726ff [INFO] running `Command { std: "docker" "start" "-a" "102ef0d6eecf7f05e35cfdff48608104324b719aef16bd3d7a3f0d8e532726ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "102ef0d6eecf7f05e35cfdff48608104324b719aef16bd3d7a3f0d8e532726ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "102ef0d6eecf7f05e35cfdff48608104324b719aef16bd3d7a3f0d8e532726ff", kill_on_drop: false }` [INFO] [stdout] 102ef0d6eecf7f05e35cfdff48608104324b719aef16bd3d7a3f0d8e532726ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c80fe20a91e11dfa84b3091c0a1b5aa0906686b32f4de20d36d9395c8d02d66a [INFO] running `Command { std: "docker" "start" "-a" "c80fe20a91e11dfa84b3091c0a1b5aa0906686b32f4de20d36d9395c8d02d66a", kill_on_drop: false }` [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking boa_string v0.19.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W unused-qualifications` [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 50 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 50 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 66 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 66 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 66 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 77 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 77 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | const DATA_OFFSET: usize = std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 186 - const DATA_OFFSET: usize = std::mem::size_of::(); [INFO] [stdout] 186 + const DATA_OFFSET: usize = size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W unused-qualifications` [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 50 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 50 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 66 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 66 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 66 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/tagged.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 77 - debug_assert!(std::mem::align_of::() >= 2); [INFO] [stdout] 77 + debug_assert!(align_of::() >= 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | const DATA_OFFSET: usize = std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 186 - const DATA_OFFSET: usize = std::mem::size_of::(); [INFO] [stdout] 186 + const DATA_OFFSET: usize = size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 303 | let string = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | StaticJsStrings::get_string(&string.as_str()).unwrap_or(string) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:33 [INFO] [stdout] | [INFO] [stdout] 383 | fn new(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Self { [INFO] [stdout] 385 | codepoints: iterator.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 848 | pub fn get_expect<'a, I>(&'a self, index: I) -> I::Value [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 852 | self.get(index).expect("Index out of bounds") [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_string` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 303 | let string = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | StaticJsStrings::get_string(&string.as_str()).unwrap_or(string) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:33 [INFO] [stdout] | [INFO] [stdout] 383 | fn new(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | Self { [INFO] [stdout] 385 | codepoints: iterator.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 848 | pub fn get_expect<'a, I>(&'a self, index: I) -> I::Value [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 852 | self.get(index).expect("Index out of bounds") [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_string` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c80fe20a91e11dfa84b3091c0a1b5aa0906686b32f4de20d36d9395c8d02d66a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c80fe20a91e11dfa84b3091c0a1b5aa0906686b32f4de20d36d9395c8d02d66a", kill_on_drop: false }` [INFO] [stdout] c80fe20a91e11dfa84b3091c0a1b5aa0906686b32f4de20d36d9395c8d02d66a