[INFO] fetching crate boa_gc 0.19.0... [INFO] checking boa_gc-0.19.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate boa_gc 0.19.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate boa_gc 0.19.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate boa_gc 0.19.0 [INFO] finished tweaking crates.io crate boa_gc 0.19.0 [INFO] tweaked toml for crates.io crate boa_gc 0.19.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2ea0e21200310ab81f03503d415a197b2009780367db444ea882f3d53e4c36c [INFO] running `Command { std: "docker" "start" "-a" "a2ea0e21200310ab81f03503d415a197b2009780367db444ea882f3d53e4c36c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2ea0e21200310ab81f03503d415a197b2009780367db444ea882f3d53e4c36c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2ea0e21200310ab81f03503d415a197b2009780367db444ea882f3d53e4c36c", kill_on_drop: false }` [INFO] [stdout] a2ea0e21200310ab81f03503d415a197b2009780367db444ea882f3d53e4c36c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b84d1f94116836fe0afb21091e9fe7c192455d0293ced7e3abe1c2646853692c [INFO] running `Command { std: "docker" "start" "-a" "b84d1f94116836fe0afb21091e9fe7c192455d0293ced7e3abe1c2646853692c", kill_on_drop: false }` [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking boa_profiler v0.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling boa_macros v0.19.0 [INFO] [stderr] Checking boa_gc v0.19.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/internals/vtable.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | size: std::mem::size_of::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W unused-qualifications` [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 51 - size: std::mem::size_of::>(), [INFO] [stdout] 51 + size: size_of::>(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 134 | let element_size = mem::size_of_val::>(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 134 - let element_size = mem::size_of_val::>(&value); [INFO] [stdout] 134 + let element_size = size_of_val::>(&value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | let element_size = mem::size_of_val::>(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 154 - let element_size = mem::size_of_val::>(&value); [INFO] [stdout] 154 + let element_size = size_of_val::>(&value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:529:41 [INFO] [stdout] | [INFO] [stdout] 529 | let unallocated_bytes = mem::size_of_val(&*unmarked_eph); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 529 - let unallocated_bytes = mem::size_of_val(&*unmarked_eph); [INFO] [stdout] 529 + let unallocated_bytes = size_of_val(&*unmarked_eph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/test/allocation.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | const SIZE: usize = std::mem::size_of::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 46 - const SIZE: usize = std::mem::size_of::>(); [INFO] [stdout] 46 + const SIZE: usize = size_of::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/test/weak.rs:157:25 [INFO] [stdout] | [INFO] [stdout] 157 | let root_size = std::mem::size_of::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 157 - let root_size = std::mem::size_of::>(); [INFO] [stdout] 157 + let root_size = size_of::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/test/weak.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 186 | let root_size = std::mem::size_of::>>>>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 186 - let root_size = std::mem::size_of::>>>>(); [INFO] [stdout] 186 + let root_size = size_of::>>>>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/internals/vtable.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | size: std::mem::size_of::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W unused-qualifications` [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 51 - size: std::mem::size_of::>(), [INFO] [stdout] 51 + size: size_of::>(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 134 | let element_size = mem::size_of_val::>(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 134 - let element_size = mem::size_of_val::>(&value); [INFO] [stdout] 134 + let element_size = size_of_val::>(&value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | let element_size = mem::size_of_val::>(&value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 154 - let element_size = mem::size_of_val::>(&value); [INFO] [stdout] 154 + let element_size = size_of_val::>(&value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:529:41 [INFO] [stdout] | [INFO] [stdout] 529 | let unallocated_bytes = mem::size_of_val(&*unmarked_eph); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 529 - let unallocated_bytes = mem::size_of_val(&*unmarked_eph); [INFO] [stdout] 529 + let unallocated_bytes = size_of_val(&*unmarked_eph); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 132 | fn alloc_gc(value: GcBox) -> NonNull> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 136 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | Self::manage_state(&mut gc); [INFO] [stdout] ... | [INFO] [stdout] 146 | | ptr [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 151 | value: EphemeronBox, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 156 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 157 | | [INFO] [stdout] 158 | | Self::manage_state(&mut gc); [INFO] [stdout] ... | [INFO] [stdout] 166 | | ptr [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 173 | let weak_map = WeakMap { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let weak = WeakGc::new(&weak_map.inner); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 179 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 180 | | [INFO] [stdout] 181 | | let weak_box = WeakMapBox { map: weak }; [INFO] [stdout] ... | [INFO] [stdout] 189 | | weak_map [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 100 | pub const fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | cell: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub(crate) const fn with_hasher(hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | table: RawTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 150 | pub(crate) fn with_capacity_and_hasher(capacity: usize, hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | table: RawTable::with_capacity(capacity), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:317:45 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn insert(&mut self, k: &Gc, v: V) -> Option> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let hash = make_hash_from_gc(&self.hash_builder, k); [INFO] [stdout] 313 | let hasher = make_hasher(&self.hash_builder); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let eph = Ephemeron::new(k, v); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | .find_or_find_insert_slot(hash, equivalent_key(k), hasher) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:342:27 [INFO] [stdout] | [INFO] [stdout] 342 | self.retain(|eph| eph.value().is_some()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/ephemeron_box.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn new(key: &Gc, value: V) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | data: UnsafeCell::new(Some(Data { [INFO] [stdout] | ___________________^ [INFO] [stdout] 23 | | key: key.inner_ptr(), [INFO] [stdout] 24 | | value, [INFO] [stdout] 25 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_gc` (lib) due to 10 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 132 | fn alloc_gc(value: GcBox) -> NonNull> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 136 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 137 | | [INFO] [stdout] 138 | | Self::manage_state(&mut gc); [INFO] [stdout] ... | [INFO] [stdout] 146 | | ptr [INFO] [stdout] 147 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 151 | value: EphemeronBox, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 156 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 157 | | [INFO] [stdout] 158 | | Self::manage_state(&mut gc); [INFO] [stdout] ... | [INFO] [stdout] 166 | | ptr [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 173 | let weak_map = WeakMap { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let weak = WeakGc::new(&weak_map.inner); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | [INFO] [stdout] 178 | BOA_GC.with(|st| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 179 | | let mut gc = st.borrow_mut(); [INFO] [stdout] 180 | | [INFO] [stdout] 181 | | let weak_box = WeakMapBox { map: weak }; [INFO] [stdout] ... | [INFO] [stdout] 189 | | weak_map [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cell.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 100 | pub const fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | cell: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub(crate) const fn with_hasher(hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | table: RawTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 150 | pub(crate) fn with_capacity_and_hasher(capacity: usize, hash_builder: S) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | table: RawTable::with_capacity(capacity), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:317:45 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn insert(&mut self, k: &Gc, v: V) -> Option> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let hash = make_hash_from_gc(&self.hash_builder, k); [INFO] [stdout] 313 | let hasher = make_hasher(&self.hash_builder); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let eph = Ephemeron::new(k, v); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | .find_or_find_insert_slot(hash, equivalent_key(k), hasher) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pointers/weak_map.rs:342:27 [INFO] [stdout] | [INFO] [stdout] 342 | self.retain(|eph| eph.value().is_some()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/ephemeron_box.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn new(key: &Gc, value: V) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | data: UnsafeCell::new(Some(Data { [INFO] [stdout] | ___________________^ [INFO] [stdout] 23 | | key: key.inner_ptr(), [INFO] [stdout] 24 | | value, [INFO] [stdout] 25 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boa_gc` (lib test) due to 10 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b84d1f94116836fe0afb21091e9fe7c192455d0293ced7e3abe1c2646853692c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b84d1f94116836fe0afb21091e9fe7c192455d0293ced7e3abe1c2646853692c", kill_on_drop: false }` [INFO] [stdout] b84d1f94116836fe0afb21091e9fe7c192455d0293ced7e3abe1c2646853692c