[INFO] fetching crate bnf_sampler 0.3.8... [INFO] checking bnf_sampler-0.3.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bnf_sampler 0.3.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bnf_sampler 0.3.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bnf_sampler 0.3.8 [INFO] finished tweaking crates.io crate bnf_sampler 0.3.8 [INFO] tweaked toml for crates.io crate bnf_sampler 0.3.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cb7551c672ee43cffbd5e433bcd0448ceb5de7919cec2eea8665bf535f054ba [INFO] running `Command { std: "docker" "start" "-a" "3cb7551c672ee43cffbd5e433bcd0448ceb5de7919cec2eea8665bf535f054ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cb7551c672ee43cffbd5e433bcd0448ceb5de7919cec2eea8665bf535f054ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cb7551c672ee43cffbd5e433bcd0448ceb5de7919cec2eea8665bf535f054ba", kill_on_drop: false }` [INFO] [stdout] 3cb7551c672ee43cffbd5e433bcd0448ceb5de7919cec2eea8665bf535f054ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 855b72bc857b0c0406c46f9c008ff9d94f80120374ba226f37f3c5718ca5a26e [INFO] running `Command { std: "docker" "start" "-a" "855b72bc857b0c0406c46f9c008ff9d94f80120374ba226f37f3c5718ca5a26e", kill_on_drop: false }` [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling libmimalloc-sys v0.1.39 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking qp-trie v0.8.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking mimalloc v0.1.43 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bnf v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bnf_sampler v0.3.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `SliceU8Wrapper` is never constructed [INFO] [stdout] --> src/utils.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) struct SliceU8Wrapper<'a>(pub &'a [u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:280:71 [INFO] [stdout] | [INFO] [stdout] 280 | .map(|(key, value)| (nonterminal_to_terminal_id[key], value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 179 | grammar: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | start_nonterminal: String, [INFO] [stdout] 181 | vocabulary: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | .ok_or(anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 190 | | "Start_nonterminal {start_nonterminal} is not defined in the BNF schema." [INFO] [stdout] 191 | | ))?, [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let tokens_buffer = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Vec::from_iter(vocabulary.token_to_id.iter().map(|(k, v)| (k.clone(), *v))); [INFO] [stdout] 197 | Ok(Sampler { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 198 | | stacks, [INFO] [stdout] 199 | | grammar, [INFO] [stdout] 200 | | vocabulary, [INFO] [stdout] ... | [INFO] [stdout] 206 | | start_nonterminal, [INFO] [stdout] 207 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:196:72 [INFO] [stdout] | [INFO] [stdout] 196 | Vec::from_iter(vocabulary.token_to_id.iter().map(|(k, v)| (k.clone(), *v))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn read_rwkv_world_vocab(path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let path = path.as_ref(); [INFO] [stdout] 92 | let file = File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut token_to_id = Trie::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Arc::new(Vocabulary { [INFO] [stdout] | ________^ [INFO] [stdout] 125 | | token_to_id, [INFO] [stdout] 126 | | id_to_token_string, [INFO] [stdout] 127 | | id_to_token, [INFO] [stdout] 128 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bnf_sampler` (lib test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `SliceU8Wrapper` is never constructed [INFO] [stdout] --> src/utils.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | pub(crate) struct SliceU8Wrapper<'a>(pub &'a [u8]); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grammar.rs:280:71 [INFO] [stdout] | [INFO] [stdout] 280 | .map(|(key, value)| (nonterminal_to_terminal_id[key], value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 179 | grammar: Arc, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | start_nonterminal: String, [INFO] [stdout] 181 | vocabulary: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | .ok_or(anyhow!( [INFO] [stdout] | ________________________- [INFO] [stdout] 190 | | "Start_nonterminal {start_nonterminal} is not defined in the BNF schema." [INFO] [stdout] 191 | | ))?, [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let tokens_buffer = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Vec::from_iter(vocabulary.token_to_id.iter().map(|(k, v)| (k.clone(), *v))); [INFO] [stdout] 197 | Ok(Sampler { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 198 | | stacks, [INFO] [stdout] 199 | | grammar, [INFO] [stdout] 200 | | vocabulary, [INFO] [stdout] ... | [INFO] [stdout] 206 | | start_nonterminal, [INFO] [stdout] 207 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:196:72 [INFO] [stdout] | [INFO] [stdout] 196 | Vec::from_iter(vocabulary.token_to_id.iter().map(|(k, v)| (k.clone(), *v))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:124:8 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn read_rwkv_world_vocab(path: impl AsRef) -> Result, Error> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let path = path.as_ref(); [INFO] [stdout] 92 | let file = File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut token_to_id = Trie::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Arc::new(Vocabulary { [INFO] [stdout] | ________^ [INFO] [stdout] 125 | | token_to_id, [INFO] [stdout] 126 | | id_to_token_string, [INFO] [stdout] 127 | | id_to_token, [INFO] [stdout] 128 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bnf_sampler` (lib) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "855b72bc857b0c0406c46f9c008ff9d94f80120374ba226f37f3c5718ca5a26e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "855b72bc857b0c0406c46f9c008ff9d94f80120374ba226f37f3c5718ca5a26e", kill_on_drop: false }` [INFO] [stdout] 855b72bc857b0c0406c46f9c008ff9d94f80120374ba226f37f3c5718ca5a26e