[INFO] fetching crate bluefile 0.2.1... [INFO] checking bluefile-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bluefile 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bluefile 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bluefile 0.2.1 [INFO] finished tweaking crates.io crate bluefile 0.2.1 [INFO] tweaked toml for crates.io crate bluefile 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28fab58c5f87c75a77e73ffd8f0a19e301823ab00cd2ed34ff963a92a1e77e19 [INFO] running `Command { std: "docker" "start" "-a" "28fab58c5f87c75a77e73ffd8f0a19e301823ab00cd2ed34ff963a92a1e77e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28fab58c5f87c75a77e73ffd8f0a19e301823ab00cd2ed34ff963a92a1e77e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28fab58c5f87c75a77e73ffd8f0a19e301823ab00cd2ed34ff963a92a1e77e19", kill_on_drop: false }` [INFO] [stdout] 28fab58c5f87c75a77e73ffd8f0a19e301823ab00cd2ed34ff963a92a1e77e19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e92119fc18dd31c00a96673c682a6f6f731081e8324a79ca213feba6ad5d8b85 [INFO] running `Command { std: "docker" "start" "-a" "e92119fc18dd31c00a96673c682a6f6f731081e8324a79ca213feba6ad5d8b85", kill_on_drop: false }` [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking bluefile v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/data_type.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | _ => Err(Error::UnknownDataTypeError), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/data_type.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 144 | DataType{rank: Rank::Scalar, format: Format::Byte} => Ok(DataValue::SB(byte_to_i8(buf[0])?)), [INFO] [stdout] | -------------------------------------------------- matches some of the same values [INFO] [stdout] 145 | DataType{rank: Rank::Scalar, format: Format::Int} => Ok(DataValue::SI(bytes_to_i16(buf, endianness)?)), [INFO] [stdout] | ------------------------------------------------- matches some of the same values [INFO] [stdout] 146 | DataType{rank: Rank::Scalar, format: Format::Long} => Ok(DataValue::SL(bytes_to_i32(buf, endianness)?)), [INFO] [stdout] | -------------------------------------------------- matches some of the same values [INFO] [stdout] 147 | DataType{rank: Rank::Scalar, format: Format::LongLong} => Ok(DataValue::SX(bytes_to_i64(buf, endianness)?)), [INFO] [stdout] | ------------------------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 156 | _ => Err(Error::UnknownDataTypeError), [INFO] [stdout] | ^ ...and 8 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `offset` is never read [INFO] [stdout] --> src/bluefile.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct ExtHeaderIter { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `offset` and `adjunct` are never read [INFO] [stdout] --> src/type1000.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Type1000DataIter { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | adjunct: Type1000Adjunct, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `offset` and `adjunct` are never read [INFO] [stdout] --> src/type2000.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Type2000DataIter { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | adjunct: Type2000Adjunct, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluefile.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 40 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(ExtHeaderIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | reader, [INFO] [stdout] 49 | | consumed: 0, [INFO] [stdout] 50 | | offset, [INFO] [stdout] 51 | | size, [INFO] [stdout] 52 | | endianness, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type1000.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 45 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Type1000DataIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | reader, [INFO] [stdout] 57 | | consumed: 0, [INFO] [stdout] 58 | | offset, [INFO] [stdout] ... | [INFO] [stdout] 63 | | buf, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type2000.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 49 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Type2000DataIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | reader, [INFO] [stdout] 61 | | consumed: 0, [INFO] [stdout] 62 | | offset, [INFO] [stdout] ... | [INFO] [stdout] 67 | | buf, [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bluefile` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/data_type.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | _ => Err(Error::UnknownDataTypeError), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/data_type.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 144 | DataType{rank: Rank::Scalar, format: Format::Byte} => Ok(DataValue::SB(byte_to_i8(buf[0])?)), [INFO] [stdout] | -------------------------------------------------- matches some of the same values [INFO] [stdout] 145 | DataType{rank: Rank::Scalar, format: Format::Int} => Ok(DataValue::SI(bytes_to_i16(buf, endianness)?)), [INFO] [stdout] | ------------------------------------------------- matches some of the same values [INFO] [stdout] 146 | DataType{rank: Rank::Scalar, format: Format::Long} => Ok(DataValue::SL(bytes_to_i32(buf, endianness)?)), [INFO] [stdout] | -------------------------------------------------- matches some of the same values [INFO] [stdout] 147 | DataType{rank: Rank::Scalar, format: Format::LongLong} => Ok(DataValue::SX(bytes_to_i64(buf, endianness)?)), [INFO] [stdout] | ------------------------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 156 | _ => Err(Error::UnknownDataTypeError), [INFO] [stdout] | ^ ...and 8 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `offset` is never read [INFO] [stdout] --> src/bluefile.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct ExtHeaderIter { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `offset` and `adjunct` are never read [INFO] [stdout] --> src/type1000.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub struct Type1000DataIter { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | adjunct: Type1000Adjunct, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `offset` and `adjunct` are never read [INFO] [stdout] --> src/type2000.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Type2000DataIter { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | offset: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | adjunct: Type2000Adjunct, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bluefile.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 40 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(ExtHeaderIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | reader, [INFO] [stdout] 49 | | consumed: 0, [INFO] [stdout] 50 | | offset, [INFO] [stdout] 51 | | size, [INFO] [stdout] 52 | | endianness, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type1000.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 45 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Type1000DataIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | reader, [INFO] [stdout] 57 | | consumed: 0, [INFO] [stdout] 58 | | offset, [INFO] [stdout] ... | [INFO] [stdout] 63 | | buf, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/type2000.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 49 | let file = open_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Type2000DataIter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | reader, [INFO] [stdout] 61 | | consumed: 0, [INFO] [stdout] 62 | | offset, [INFO] [stdout] ... | [INFO] [stdout] 67 | | buf, [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bluefile` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e92119fc18dd31c00a96673c682a6f6f731081e8324a79ca213feba6ad5d8b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e92119fc18dd31c00a96673c682a6f6f731081e8324a79ca213feba6ad5d8b85", kill_on_drop: false }` [INFO] [stdout] e92119fc18dd31c00a96673c682a6f6f731081e8324a79ca213feba6ad5d8b85