[INFO] fetching crate bloxberg 0.1.0... [INFO] checking bloxberg-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bloxberg 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate bloxberg 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bloxberg 0.1.0 [INFO] finished tweaking crates.io crate bloxberg 0.1.0 [INFO] tweaked toml for crates.io crate bloxberg 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate bloxberg 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 322f1cb5583dadee6a8abc0de8f014d465077f2d086b9439a1e12cd267c960a0 [INFO] running `Command { std: "docker" "start" "-a" "322f1cb5583dadee6a8abc0de8f014d465077f2d086b9439a1e12cd267c960a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "322f1cb5583dadee6a8abc0de8f014d465077f2d086b9439a1e12cd267c960a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "322f1cb5583dadee6a8abc0de8f014d465077f2d086b9439a1e12cd267c960a0", kill_on_drop: false }` [INFO] [stdout] 322f1cb5583dadee6a8abc0de8f014d465077f2d086b9439a1e12cd267c960a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f9472b772a665e26ec1874432bd9778162413bb66bd93b8a4d7e4a3a477f19c [INFO] running `Command { std: "docker" "start" "-a" "5f9472b772a665e26ec1874432bd9778162413bb66bd93b8a4d7e4a3a477f19c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling cc v1.0.61 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling capstone-sys v0.11.0 [INFO] [stderr] Checking termion v1.5.5 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking capstone v0.7.0 [INFO] [stderr] Checking bloxberg v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `byte_range` is never used [INFO] [stdout] --> src/cell.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 154 | impl Cell { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 172 | pub const fn byte_range(&self) -> Range { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_empty` is never used [INFO] [stdout] --> src/editor.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 34 | impl Line { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `cell_index_at_cursor`, `escape_non_printable`, and `draw_line_ascii` are never used [INFO] [stdout] --> src/editor.rs:150:8 [INFO] [stdout] | [INFO] [stdout] 88 | impl<'d, W: Write> Editor<'d, W> { [INFO] [stdout] | -------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 150 | fn cell_index_at_cursor(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 537 | fn escape_non_printable(chr: char) -> char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 623 | fn draw_line_ascii(&self, range: Range) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_store.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn file(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mmap = unsafe { MmapOptions::new().map_copy(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Ok(DataStore::File(mmap, file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_store.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | let mmap = MmapOptions::new().len(n_bytes).map_anon()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(DataStore::Anon(mmap)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Terminal { [INFO] [stdout] 33 | writer: RefCell::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(data_store: &'d mut DataStore, writer: W, width: usize, height: usize) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | terminal: Terminal::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:120:26 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(data_store: &'d mut DataStore, writer: W, width: usize, height: usize) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | disasm_view: DisasmView::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bloxberg` (bin "bloxberg") due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `byte_range` is never used [INFO] [stdout] --> src/cell.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 154 | impl Cell { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 172 | pub const fn byte_range(&self) -> Range { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_empty` is never used [INFO] [stdout] --> src/editor.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 34 | impl Line { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `cell_index_at_cursor`, `escape_non_printable`, and `draw_line_ascii` are never used [INFO] [stdout] --> src/editor.rs:150:8 [INFO] [stdout] | [INFO] [stdout] 88 | impl<'d, W: Write> Editor<'d, W> { [INFO] [stdout] | -------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 150 | fn cell_index_at_cursor(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 537 | fn escape_non_printable(chr: char) -> char { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 623 | fn draw_line_ascii(&self, range: Range) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_store.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn file(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mmap = unsafe { MmapOptions::new().map_copy(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Ok(DataStore::File(mmap, file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_store.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | let mmap = MmapOptions::new().len(n_bytes).map_anon()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(DataStore::Anon(mmap)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Terminal { [INFO] [stdout] 33 | writer: RefCell::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(data_store: &'d mut DataStore, writer: W, width: usize, height: usize) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | terminal: Terminal::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:120:26 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(data_store: &'d mut DataStore, writer: W, width: usize, height: usize) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | disasm_view: DisasmView::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bloxberg` (bin "bloxberg" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5f9472b772a665e26ec1874432bd9778162413bb66bd93b8a4d7e4a3a477f19c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f9472b772a665e26ec1874432bd9778162413bb66bd93b8a4d7e4a3a477f19c", kill_on_drop: false }` [INFO] [stdout] 5f9472b772a665e26ec1874432bd9778162413bb66bd93b8a4d7e4a3a477f19c