[INFO] fetching crate blorb 0.1.0... [INFO] checking blorb-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blorb 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate blorb 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blorb 0.1.0 [INFO] finished tweaking crates.io crate blorb 0.1.0 [INFO] tweaked toml for crates.io crate blorb 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding byteorder v0.5.3 (latest: v1.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19327a0bcbbce5cdf8c1a4a1106b0149405725e286a1372835bc338740f05367 [INFO] running `Command { std: "docker" "start" "-a" "19327a0bcbbce5cdf8c1a4a1106b0149405725e286a1372835bc338740f05367", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19327a0bcbbce5cdf8c1a4a1106b0149405725e286a1372835bc338740f05367", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19327a0bcbbce5cdf8c1a4a1106b0149405725e286a1372835bc338740f05367", kill_on_drop: false }` [INFO] [stdout] 19327a0bcbbce5cdf8c1a4a1106b0149405725e286a1372835bc338740f05367 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96fa35b066628e1d2b9706c091552e6475b15db54cf3ce547eefd3ce868d4a9e [INFO] running `Command { std: "docker" "start" "-a" "96fa35b066628e1d2b9706c091552e6475b15db54cf3ce547eefd3ce868d4a9e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking blorb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | let form = try!(Blorb::load_chunk_data(&mut file)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | let id = try!(Blorb::load_4bw(&mut file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | try!(Blorb::load_chunk(&mut file)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | try!(self.file.seek(SeekFrom::Start(entry.start as u64))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | let meta = try!(Blorb::load_chunk_data(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:158:27 [INFO] [stdout] | [INFO] [stdout] 158 | let num = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:161:33 [INFO] [stdout] | [INFO] [stdout] 161 | let entry = try!(Blorb::load_index_entry(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | let usage = try!(Blorb::load_4bw(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 183 | let num = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | let start = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | let id = try!(Blorb::load_4bw(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let len = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | try!(file.take(4).read_to_string(&mut id)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | let form = try!(Blorb::load_chunk_data(&mut file)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | let id = try!(Blorb::load_4bw(&mut file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | try!(Blorb::load_chunk(&mut file)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | try!(self.file.seek(SeekFrom::Start(entry.start as u64))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | let meta = try!(Blorb::load_chunk_data(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:158:27 [INFO] [stdout] | [INFO] [stdout] 158 | let num = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:161:33 [INFO] [stdout] | [INFO] [stdout] 161 | let entry = try!(Blorb::load_index_entry(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | let usage = try!(Blorb::load_4bw(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 183 | let num = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | let start = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:203:18 [INFO] [stdout] | [INFO] [stdout] 203 | let id = try!(Blorb::load_4bw(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:204:19 [INFO] [stdout] | [INFO] [stdout] 204 | let len = try!(file.read_u32::()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/blorb.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | try!(file.take(4).read_to_string(&mut id)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blorb.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn from_file(file: R) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut file = file; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | [INFO] [stdout] 112 | let form = try!(Blorb::load_chunk_data(&mut file)); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let id = try!(Blorb::load_4bw(&mut file)); [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | try!(Blorb::load_chunk(&mut file)) { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Blorb{ [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | len: form.len, [INFO] [stdout] 131 | | index: index, [INFO] [stdout] 132 | | file: file, [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blorb` (lib) due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blorb.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn from_file(file: R) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut file = file; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | [INFO] [stdout] 112 | let form = try!(Blorb::load_chunk_data(&mut file)); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let id = try!(Blorb::load_4bw(&mut file)); [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | try!(Blorb::load_chunk(&mut file)) { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Blorb{ [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | len: form.len, [INFO] [stdout] 131 | | index: index, [INFO] [stdout] 132 | | file: file, [INFO] [stdout] 133 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blorb` (lib test) due to 2 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "96fa35b066628e1d2b9706c091552e6475b15db54cf3ce547eefd3ce868d4a9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96fa35b066628e1d2b9706c091552e6475b15db54cf3ce547eefd3ce868d4a9e", kill_on_drop: false }` [INFO] [stdout] 96fa35b066628e1d2b9706c091552e6475b15db54cf3ce547eefd3ce868d4a9e