[INFO] fetching crate blocks_iterator 1.0.4... [INFO] checking blocks_iterator-1.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blocks_iterator 1.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate blocks_iterator 1.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blocks_iterator 1.0.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate blocks_iterator 1.0.4 [INFO] tweaked toml for crates.io crate blocks_iterator 1.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate blocks_iterator 1.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bd6879cb1dbbb9e566595ae819ef2d156c84aad40a752ac26cb3c54fdb98c36 [INFO] running `Command { std: "docker" "start" "-a" "0bd6879cb1dbbb9e566595ae819ef2d156c84aad40a752ac26cb3c54fdb98c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bd6879cb1dbbb9e566595ae819ef2d156c84aad40a752ac26cb3c54fdb98c36", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bd6879cb1dbbb9e566595ae819ef2d156c84aad40a752ac26cb3c54fdb98c36", kill_on_drop: false }` [INFO] [stdout] 0bd6879cb1dbbb9e566595ae819ef2d156c84aad40a752ac26cb3c54fdb98c36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8780f4cc68558684601ef506a4b08cffa8e17500a4a15f25401b821c55a3aa68 [INFO] running `Command { std: "docker" "start" "-a" "8780f4cc68558684601ef506a4b08cffa8e17500a4a15f25401b821c55a3aa68", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.181 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling serde_derive v1.0.181 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling cc v1.0.81 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Compiling bitcoin v0.30.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking regex-automata v0.3.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling rustix v0.38.6 [INFO] [stderr] Checking bitcoin_hashes v0.12.0 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking tempfile v3.7.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking bitcoin_slices v0.6.2 [INFO] [stderr] Checking blocks_iterator v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 86 | fn iterate(config: Config, channel: SyncSender>) -> JoinHandle<()> { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | let now = Instant::now(); [INFO] [stdout] 89 | | let early_stop = Arc::new(AtomicBool::new(false)); [INFO] [stdout] ... | [INFO] [stdout] 145 | | info!("Total time elapsed: {}s", now.elapsed().as_secs()); [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/compute_txids.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 27 | receiver: Receiver>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 32 | | info!("starting compute tx ids"); [INFO] [stdout] 33 | | let mut now = Instant::now(); [INFO] [stdout] 34 | | let mut busy_time = Duration::default(); [INFO] [stdout] ... | [INFO] [stdout] 57 | | sender.send(None).expect("augment: cannot send none"); [INFO] [stdout] 58 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/fee.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 25 | receiver: Receiver>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | mut utxo: T, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | info!( [INFO] [stdout] 32 | | "starting fee processer. start_at_height:{}", [INFO] [stdout] 33 | | start_at_height [INFO] [stdout] ... | [INFO] [stdout] 113 | | sender.send(None).expect("fee: cannot send none"); [INFO] [stdout] 114 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/read_detect.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 68 | early_stop: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | sender: SyncSender>>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | info!("starting read_detect"); [INFO] [stdout] 76 | | [INFO] [stdout] 77 | | let mut now = Instant::now(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/reorder.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 98 | early_stop: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | receiver: Receiver>>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut blocks = OutOfOrderBlocks::new(max_reorg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 108 | | info!("starting reorder"); [INFO] [stdout] 109 | | [INFO] [stdout] 110 | | let mut bench = PeriodCounter::new(Duration::from_secs(10)); [INFO] [stdout] ... | [INFO] [stdout] 198 | | // } [INFO] [stdout] 199 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blocks_iterator` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 86 | fn iterate(config: Config, channel: SyncSender>) -> JoinHandle<()> { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | let now = Instant::now(); [INFO] [stdout] 89 | | let early_stop = Arc::new(AtomicBool::new(false)); [INFO] [stdout] ... | [INFO] [stdout] 145 | | info!("Total time elapsed: {}s", now.elapsed().as_secs()); [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/compute_txids.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 27 | receiver: Receiver>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 32 | | info!("starting compute tx ids"); [INFO] [stdout] 33 | | let mut now = Instant::now(); [INFO] [stdout] 34 | | let mut busy_time = Duration::default(); [INFO] [stdout] ... | [INFO] [stdout] 57 | | sender.send(None).expect("augment: cannot send none"); [INFO] [stdout] 58 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/fee.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 25 | receiver: Receiver>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | mut utxo: T, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | info!( [INFO] [stdout] 32 | | "starting fee processer. start_at_height:{}", [INFO] [stdout] 33 | | start_at_height [INFO] [stdout] ... | [INFO] [stdout] 113 | | sender.send(None).expect("fee: cannot send none"); [INFO] [stdout] 114 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/read_detect.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 68 | early_stop: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | sender: SyncSender>>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | info!("starting read_detect"); [INFO] [stdout] 76 | | [INFO] [stdout] 77 | | let mut now = Instant::now(); [INFO] [stdout] ... | [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stages/reorder.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 98 | early_stop: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | receiver: Receiver>>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | sender: SyncSender>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let mut blocks = OutOfOrderBlocks::new(max_reorg); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | join: Some(std::thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 108 | | info!("starting reorder"); [INFO] [stdout] 109 | | [INFO] [stdout] 110 | | let mut bench = PeriodCounter::new(Duration::from_secs(10)); [INFO] [stdout] ... | [INFO] [stdout] 198 | | // } [INFO] [stdout] 199 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blocks_iterator` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8780f4cc68558684601ef506a4b08cffa8e17500a4a15f25401b821c55a3aa68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8780f4cc68558684601ef506a4b08cffa8e17500a4a15f25401b821c55a3aa68", kill_on_drop: false }` [INFO] [stdout] 8780f4cc68558684601ef506a4b08cffa8e17500a4a15f25401b821c55a3aa68