[INFO] fetching crate blocking-permit 1.3.3... [INFO] checking blocking-permit-1.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blocking-permit 1.3.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate blocking-permit 1.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blocking-permit 1.3.3 [INFO] finished tweaking crates.io crate blocking-permit 1.3.3 [INFO] tweaked toml for crates.io crate blocking-permit 1.3.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v1.1.0 (latest: v1.7.1) [INFO] [stderr] Adding futures-intrusive v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding lazy_static v1.4.0 (latest: v1.5.0) [INFO] [stderr] Adding log v0.4.14 (latest: v0.4.22) [INFO] [stderr] Adding num_cpus v1.13.1 (latest: v1.16.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding tempfile v3.2.0 (latest: v3.12.0) [INFO] [stderr] Adding tokio v1.12.0 (latest: v1.40.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8505d8725eef3355618aac2a6ec4c93345ad2217d4e447b02e0fe2946545f2e1 [INFO] running `Command { std: "docker" "start" "-a" "8505d8725eef3355618aac2a6ec4c93345ad2217d4e447b02e0fe2946545f2e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8505d8725eef3355618aac2a6ec4c93345ad2217d4e447b02e0fe2946545f2e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8505d8725eef3355618aac2a6ec4c93345ad2217d4e447b02e0fe2946545f2e1", kill_on_drop: false }` [INFO] [stdout] 8505d8725eef3355618aac2a6ec4c93345ad2217d4e447b02e0fe2946545f2e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d61b8a654ba373d4c860a187bfeba3037a63a96c88f61b5cbac2a2a91cbfc792 [INFO] running `Command { std: "docker" "start" "-a" "d61b8a654ba373d4c860a187bfeba3037a63a96c88f61b5cbac2a2a91cbfc792", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling tao-log v1.0.1 [INFO] [stderr] Compiling blocking-permit v1.3.3 (/opt/rustwide/workdir) [INFO] [stderr] Compiling piccolog v1.0.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> build.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::all))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bytes`, `cleaver`, `current-thread`, `default`, `futures-channel`, `futures-intrusive`, `tangential`, `tokio`, `tokio-omnibus`, `tokio-oneshot`, `tokio-semaphore`, `tokio-threaded`, and `yield-stream` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blocking-permit` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn register_dispatch_pool(pool: DispatchPool) -> Option { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | POOL.with(|p| p.replace(Some(pool))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn register_dispatch_pool(pool: DispatchPool) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | POOL.with(|p| p.replace(Some(pool))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | POOL.with(|p| p.replace(None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | POOL.with(|p| p.borrow().is_some()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn dispatch(f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | POOL.with(|p| { [INFO] [stdout] | _______________^ [INFO] [stdout] 50 | | if let Some(pool) = p.borrow().as_ref() { [INFO] [stdout] 51 | | pool.spawn(Box::new(f)); [INFO] [stdout] 52 | | None [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn dispatch_rx(f: F) -> DispatchRx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | POOL.with(|p| { [INFO] [stdout] | _______________^ [INFO] [stdout] 93 | | if let Some(pool) = p.borrow().as_ref() { [INFO] [stdout] 94 | | let (tx, rx) = oneshot::channel(); [INFO] [stdout] 95 | | pool.spawn(Box::new(|| { [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "d61b8a654ba373d4c860a187bfeba3037a63a96c88f61b5cbac2a2a91cbfc792", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d61b8a654ba373d4c860a187bfeba3037a63a96c88f61b5cbac2a2a91cbfc792", kill_on_drop: false }` [INFO] [stdout] d61b8a654ba373d4c860a187bfeba3037a63a96c88f61b5cbac2a2a91cbfc792