[INFO] fetching crate blobary 0.3.0... [INFO] checking blobary-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blobary 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate blobary 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blobary 0.3.0 [INFO] finished tweaking crates.io crate blobary 0.3.0 [INFO] tweaked toml for crates.io crate blobary 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 172 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding attohttpc v0.22.0 (latest: v0.28.0) [INFO] [stderr] Adding aws-creds v0.34.1 (latest: v0.38.0) [INFO] [stderr] Adding aws-region v0.25.5 (latest: v0.26.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding cap-primitives v2.0.1 (latest: v3.2.0) [INFO] [stderr] Adding cap-std v2.0.1 (latest: v3.2.0) [INFO] [stderr] Adding cap-tempfile v2.0.1 (latest: v3.2.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding dlv-list v0.3.0 (latest: v0.5.2) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding infer v0.15.0 (latest: v0.16.0) [INFO] [stderr] Adding libsqlite3-sys v0.26.0 (latest: v0.30.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding ordered-multimap v0.4.3 (latest: v0.7.3) [INFO] [stderr] Adding quick-xml v0.26.0 (latest: v0.36.1) [INFO] [stderr] Adding redis v0.23.3 (latest: v0.26.1) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rusqlite v0.29.0 (latest: v0.32.1) [INFO] [stderr] Adding rust-ini v0.18.0 (latest: v0.21.1) [INFO] [stderr] Adding rust-s3 v0.33.0 (latest: v0.35.1) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.22.6 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7c4407973c2abcf515c84999bdc3a1b1897a47e4ef28380f7bd925e492a9e12 [INFO] running `Command { std: "docker" "start" "-a" "c7c4407973c2abcf515c84999bdc3a1b1897a47e4ef28380f7bd925e492a9e12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7c4407973c2abcf515c84999bdc3a1b1897a47e4ef28380f7bd925e492a9e12", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7c4407973c2abcf515c84999bdc3a1b1897a47e4ef28380f7bd925e492a9e12", kill_on_drop: false }` [INFO] [stdout] c7c4407973c2abcf515c84999bdc3a1b1897a47e4ef28380f7bd925e492a9e12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e612c90e8e776f0fa54fd1949889c3754d80cb23622da04b28d1722240be59c1 [INFO] running `Command { std: "docker" "start" "-a" "e612c90e8e776f0fa54fd1949889c3754d80cb23622da04b28d1722240be59c1", kill_on_drop: false }` [INFO] [stderr] Compiling io-lifetimes v2.0.3 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling io-extras v0.18.2 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Compiling cap-primitives v2.0.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Compiling libsqlite3-sys v0.26.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling cap-std v2.0.1 [INFO] [stderr] Checking ambient-authority v0.0.2 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking aws-region v0.25.5 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking webpki-roots v0.22.6 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking infer v0.15.0 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking rusqlite v0.29.0 [INFO] [stderr] Checking fs-set-times v0.20.1 [INFO] [stderr] Checking cap-tempfile v2.0.1 [INFO] [stderr] Checking redis v0.23.3 [INFO] [stderr] Checking attohttpc v0.22.0 [INFO] [stderr] Checking aws-creds v0.34.1 [INFO] [stderr] Checking rust-s3 v0.33.0 [INFO] [stderr] Checking blobary v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `compress::*` [INFO] [stdout] --> src/lib.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use compress::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `filter::*` [INFO] [stdout] --> src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use filter::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `compress::*` [INFO] [stdout] --> src/lib.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub use compress::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `filter::*` [INFO] [stdout] --> src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use filter::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn open_path(path: impl AsRef, options: BlobStoreOptions) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Self::open_dir(Dir::open_ambient_dir(path, ambient_authority())?, options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn open_dir(dir: Dir, options: BlobStoreOptions) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut index_file = dir.open_with(INDEX_FILE_NAME, index_options)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | dir, [INFO] [stdout] 77 | | index_file: RefCell::new(Box::new(index_file)), [INFO] [stdout] 78 | | lookup_id, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 123 | let mut temp_file = TempFile::new(&self.dir)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let mut blob_hasher = BlobHasher::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut index_file = self.index_file.borrow_mut(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 163 | | true, [INFO] [stdout] 164 | | Blob { [INFO] [stdout] 165 | | id: blob_id, [INFO] [stdout] ... | [INFO] [stdout] 169 | | }, [INFO] [stdout] 170 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(error: redis::RedisError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::Other(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 53 | fn put_file(&mut self, path: impl AsRef) -> Result<(bool, Blob)> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | self.put(&mut std::fs::File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/temp/store.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 58 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok((true, blob)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn open(url: impl AsRef, _options: BlobStoreOptions) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let client = redis::Client::open(url.as_ref())?; [INFO] [stdout] 21 | let connection = client.get_connection()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | connection: RefCell::new(connection), [INFO] [stdout] 24 | | count_key: "blobs:id".to_string(), [INFO] [stdout] 25 | | index_key: "blobs:index".to_string(), [INFO] [stdout] 26 | | store_key: "blobs:store".to_string(), [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(conn.zcard(&self.index_key).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 46 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match cmd.query(&mut conn) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:108:15 [INFO] [stdout] | [INFO] [stdout] 106 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let blob_hash_str = blob_hash.to_hex(); [INFO] [stdout] 108 | match conn.zscore::<&str, &str, Option>(&self.index_key, blob_hash_str.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 116 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | match conn.zrangebyscore::<&str, BlobID, BlobID, Vec>( [INFO] [stdout] | _______________^ [INFO] [stdout] 118 | | &self.index_key, [INFO] [stdout] 119 | | blob_id, [INFO] [stdout] 120 | | blob_id, [INFO] [stdout] 121 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/store.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 22 | bucket: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | prefix: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let bucket = s3::Bucket::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | bucket, [INFO] [stdout] 33 | | prefix: prefix.as_ref().to_string(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/store.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 89 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | .bucket [INFO] [stdout] 99 | | .put_object(blob_path.as_str(), buffer.as_slice()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blobary` (lib test) due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn open_path(path: impl AsRef, options: BlobStoreOptions) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Self::open_dir(Dir::open_ambient_dir(path, ambient_authority())?, options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn open_dir(dir: Dir, options: BlobStoreOptions) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut index_file = dir.open_with(INDEX_FILE_NAME, index_options)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | dir, [INFO] [stdout] 77 | | index_file: RefCell::new(Box::new(index_file)), [INFO] [stdout] 78 | | lookup_id, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/store.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 123 | let mut temp_file = TempFile::new(&self.dir)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let mut blob_hasher = BlobHasher::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut index_file = self.index_file.borrow_mut(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 163 | | true, [INFO] [stdout] 164 | | Blob { [INFO] [stdout] 165 | | id: blob_id, [INFO] [stdout] ... | [INFO] [stdout] 169 | | }, [INFO] [stdout] 170 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(error: redis::RedisError) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::Other(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 53 | fn put_file(&mut self, path: impl AsRef) -> Result<(bool, Blob)> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | self.put(&mut std::fs::File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/temp/store.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 58 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok((true, blob)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn open(url: impl AsRef, _options: BlobStoreOptions) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let client = redis::Client::open(url.as_ref())?; [INFO] [stdout] 21 | let connection = client.get_connection()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | connection: RefCell::new(connection), [INFO] [stdout] 24 | | count_key: "blobs:id".to_string(), [INFO] [stdout] 25 | | index_key: "blobs:index".to_string(), [INFO] [stdout] 26 | | store_key: "blobs:store".to_string(), [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(conn.zcard(&self.index_key).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 46 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match cmd.query(&mut conn) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:108:15 [INFO] [stdout] | [INFO] [stdout] 106 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let blob_hash_str = blob_hash.to_hex(); [INFO] [stdout] 108 | match conn.zscore::<&str, &str, Option>(&self.index_key, blob_hash_str.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis/store.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 116 | let mut conn = self.connection.borrow_mut(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | match conn.zrangebyscore::<&str, BlobID, BlobID, Vec>( [INFO] [stdout] | _______________^ [INFO] [stdout] 118 | | &self.index_key, [INFO] [stdout] 119 | | blob_id, [INFO] [stdout] 120 | | blob_id, [INFO] [stdout] 121 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/store.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 22 | bucket: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | prefix: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let bucket = s3::Bucket::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | bucket, [INFO] [stdout] 33 | | prefix: prefix.as_ref().to_string(), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3/store.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 89 | let blob = Blob { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | .bucket [INFO] [stdout] 99 | | .put_object(blob_path.as_str(), buffer.as_slice()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blobary` (lib) due to 14 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e612c90e8e776f0fa54fd1949889c3754d80cb23622da04b28d1722240be59c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e612c90e8e776f0fa54fd1949889c3754d80cb23622da04b28d1722240be59c1", kill_on_drop: false }` [INFO] [stdout] e612c90e8e776f0fa54fd1949889c3754d80cb23622da04b28d1722240be59c1